Re: RFR: JDK-8236128: Allow jpackage create installers for services [v2]
On Thu, 14 Apr 2022 21:04:52 GMT, Alexey Semenyuk wrote: >> Implementation of [JDK-8275062: "Allow jpackage create installers for >> services"](https://bugs.openjdk.java.net/browse/JDK-8275062) >> CSR > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 121 commits: > > - Merge branch 'master' into JDK-8236128 > - Whitespace cleanup > - Whitespace cleanup > - JDK-8236128: Allow jpackage create installers for services > - Sync l10n files. Fix copyright year > - Minor formatting fix > - Merge fix > - Merge fixed > - Merge branch 'master' into JDK-8236128 > - Merge branch 'JDK-8236128' of https://github.com/alexeysemenyukoracle/jdk > into JDK-8236128 > - ... and 111 more: > https://git.openjdk.java.net/jdk/compare/f4edb59a...1a3d7cf5 Approved - PR: https://git.openjdk.java.net/jdk/pull/7793
Re: [jdk18] RFR: 8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to build with GCC 6.3.0
On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev wrote: > Seems like a missing include. C++ docs say `offsetof` is from ``, > adding that include explicitly fixes the build. Seems to only happen with > older GCCs, but it seems to be a happy accident it works on newer ones, > probably through the transitive include somewhere. > > Additional testing: > - [x] Linux x86_64 fastdebug `tools/jpackage` tests > - [x] Linux x86_64 release `tools/jpackage` tests it requires @alexeysemenyukoracle review (owner of JDK-8274856 changeset) - PR: https://git.openjdk.java.net/jdk18/pull/74
Re: RFR: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional
On Thu, 11 Nov 2021 04:07:18 GMT, Alexey Semenyuk wrote: > 8276084: Linux DEB Bundler: release number in outputted .deb file should be > optional @andyherrick please review - PR: https://git.openjdk.java.net/jdk/pull/6345
Re: RFR: 8274856: Failing jpackage tests with fastdebug/release build
On Fri, 5 Nov 2021 19:58:01 GMT, Alexey Semenyuk wrote: > The fix is to isolate C++ calls in the separate forked child process on > Linux. > This change requires the passing of JLI command line arguments and values of > environment variables between two processes. @andyherrick please review - PR: https://git.openjdk.java.net/jdk/pull/6283
Re: RFR: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional
On Thu, 11 Nov 2021 04:07:18 GMT, Alexey Semenyuk wrote: > 8276084: Linux DEB Bundler: release number in outputted .deb file should be > optional @sashamatveev please review - PR: https://git.openjdk.java.net/jdk/pull/6345
Re: [jdk17] RFR: 8269185: Directories in /opt/runtimepackagetest and /path/to/jdk-17 are different
On Sat, 3 Jul 2021 00:03:55 GMT, Alexander Matveev wrote: >> Disable stripping to prevent rpmbuild from modifying executables > > Marked as reviewed by almatvee (Reviewer). @sashamatveev @herrick please review - PR: https://git.openjdk.java.net/jdk17/pull/207
Re: [jdk17] RFR: 8269036: tools/jpackage/share/AppImagePackageTest.java failed with "hdiutil: create failed - Resource busy"
On Tue, 22 Jun 2021 21:59:43 GMT, Alexander Matveev wrote: > Looks like another "Resource busy" issue similar to recent fixes for "hdiutil > convert" and "hdiutil detach". Workaround in same way by repeating "create" > command. Modified RetryExecutor to pass write to file flag, otherwise > "hdiutil create" might deadlock. > Also, repeat is done only for creating DMG using size instead of creating > from app image. In some cases create DMG from app image might run for very > long time and eventually fail, this is why fallback to create DMG from size > was added. @andyherrick please review - PR: https://git.openjdk.java.net/jdk17/pull/122
Re: RFR: JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution.
On Tue, 23 Mar 2021 19:40:38 GMT, Kevin Rushforth wrote: >>> Looks good, although i see the following wasn't backed out: >>> >>> ``` >>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns >>> ``` >> >> yes - look again - it was renamed back to java.icns (the 12'th or 22 files >> changed above) > > As long as there are no transient build/test failures, it will be fine. I was > just comparing the results with what `git revert > 11c8c78c47f21fcd87a5969a859b5c4fced5e47d` generated and noticed this > difference. @sashamatveev please review - PR: https://git.openjdk.java.net/jdk/pull/3159
Re: RFR: JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution.
On Tue, 23 Mar 2021 20:42:22 GMT, Victor Dyakov wrote: >> As long as there are no transient build/test failures, it will be fine. I >> was just comparing the results with what `git revert >> 11c8c78c47f21fcd87a5969a859b5c4fced5e47d` generated and noticed this >> difference. > > @sashamatveev please review @alexeysemenyukoracle please review - PR: https://git.openjdk.java.net/jdk/pull/3159
Re: RFR: 8263536: Add missing @compile tags to jpackage tests [v2]
On Sat, 13 Mar 2021 00:52:44 GMT, Kevin Rushforth wrote: >> Marked as reviewed by almatvee (Committer). > > Since you are removing the problem listing, would it be better to use the > parent bug ID -- 8263474 -- rather than a sub-task? How do you plan to > resolve the parent bug? Manually as "Delivered"? Something else? ..and deproblemlist mach5 failed tests - PR: https://git.openjdk.java.net/jdk/pull/2975
