Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v12]
On Thu, 5 May 2022 09:35:42 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview). >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the HotSpot VM are disabled by default and >> require running with `--enable-preview` to enable. >> >> The patch has support for x64 and aarch64 on the usual operating systems >> (Linux, macOS, and Windows). There are stubs (calling _Unimplemented_) for >> zero and some of the other ports. Additional ports can be contributed via >> PRs against the fibers branch in the loom repo. >> >> There are changes in many areas. To reduce notifications/mails, the labels >> have been trimmed down for now to hotspot, serviceability and core-libs. We >> can add additional labels, if required, as the PR progresses. >> >> The changes include a refresh of java.util.concurrent and ForkJoinPool from >> Doug Lea's CVS. These changes will probably be proposed and integrated in >> advance of this PR. >> >> The changes include some non-exposed and low-level infrastructure to support >> the (in draft) JEPs for Structured Concurrency and Extent Locals. This is to >> make life a bit easier and avoid having to separate VM changes and juggle >> branches at this time. > > Alan Bateman has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 19 commits: > > - Refresh 12aa09ce7efd48425cc080d0b8761aca0f3e215f > - Merge with 1bb4de2e2868a539846ec48dd43fd623c2ba69a5 > - Refresh d77f7a49af75bcc5b20686805ff82a93a20dde05 > - Merge with 4b2c82200fdc01de868cf414e40a4d891e753f89 > - Refresh 6091080db743ece5f1b2111fcc35a5f2179a403a > - Merge with cfcba1fccc8e3e6a68e1cb1826b70e076d5d83c4 > - Refresh ee9fa8ed05ec22de7a13383052d68aa8aa7832ec > - Merge with jdk-19+20 > - Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e > - Refresh 8d8f0a2fd646e57fe6b4e8ab669f836dc46dda69 > - ... and 9 more: > https://git.openjdk.java.net/jdk/compare/1bb4de2e...86bea8ec Studied the java.io package edits, the new JFR events and the new jcmd dump_to_file functionality. Looks good! - Marked as reviewed by coffeys (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8166
Re: RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() [v2]
On Wed, 16 Mar 2022 16:31:36 GMT, Ravi Reddy wrote: >> Hi All, >> >> This review request contains fix for infinite loop issue in >> DeflaterOutputStream.finish() in an exception scenario. >> 1. The issue is with 'finished' flag not getting set to correct value when >> there is an IOException in >> DeflaterOutputStream.finish() which will result in Infinite loops for >> next write operations on the same deflater. >> 2. Tighten the condition(to close deflater) in ZipOutputStream using an >> already existing 'finish' flag in Deflater class. >> 3. Added Inflater exception scenarios also to the test case, renaming test >> case to CloseInflaterDeflaterTest.java from CloseDeflaterTest.java >> >> Thanks, >> Ravi > > Ravi Reddy has updated the pull request incrementally with one additional > commit since the last revision: > > Modified write(byte []b) to write(byte[] b) to maintain same signature > across the test case Marked as reviewed by coffeys (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7804
Re: RFR: 8278794: Infinite loop in DeflaterOutputStream.finish()
On Sun, 13 Mar 2022 14:08:57 GMT, Ravi Reddy wrote:
> Hi All,
>
> This review request contains fix for infinite loop issue in
> DeflaterOutputStream.finish() in an exception scenario.
> 1. The issue is with 'finished' flag not getting set to correct value when
> there is an IOException in
> DeflaterOutputStream.finish() which will result in Infinite loops for
> next write operations on the same deflater.
> 2. Tighten the condition(to close deflater) in ZipOutputStream using an
> already existing 'finish' flag in Deflater class.
> 3. Added Inflater exception scenarios also to the test case, renaming test
> case to CloseInflaterDeflaterTest.java from CloseDeflaterTest.java
>
> Thanks,
> Ravi
Looks like a good approach to solve reported issue.
test/jdk/java/util/zip/CloseInflaterDeflaterTest.java line 58:
> 56: }
> 57: @Override
> 58: public void write(byte b[]) throws IOException {}
Let's be consistant with style and use "byte[] b"
Same with line 70
-
Marked as reviewed by coffeys (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7804
Re: RFR: 8278851: Correct signer logic for jars signed with multiple digestalgs
On Thu, 13 Jan 2022 13:56:14 GMT, Sean Mullan wrote: >> src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java >> line 212: >> >>> 210: >>> 211: CodeSigner[] entrySigners = sigFileSigners.get(name); >>> 212: Map permittedAlgs = >> >> maybe permittedAlgsChecker as variable name ? the Map contains both >> permitted and non-permitted algs. > > `Checker` sounds like it going to do something. But I agree the name could be > better. I was mostly being consistent with the `permittedAlgs` variable in > `SignatureFileVerifier`. Maybe `algsPermittedStatus`? yes, algsPermittedStatus sounds better. Thanks. >> src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java >> line 239: >> >>> 237: >>> 238: // A non-disabled algorithm was used. >>> 239: disabledAlgs = false; >> >> this usage doesn't seem right. I think it's always set to false no matter >> what algs are detected. > > If all algs are disabled, it will never get here, because it will either > continue on line 231 or 234. Ah yes - I was reading the scope of for loop incorrectly. Thanks for clarifying! - PR: https://git.openjdk.java.net/jdk/pull/7056
Re: RFR: 8278851: Correct signer logic for jars signed with multiple digestalgs
On Wed, 12 Jan 2022 21:57:22 GMT, Sean Mullan wrote: > If a JAR is signed with multiple digest algorithms and one of the digest > algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly > returning null indicating that the jar entry has no signers. > > This fixes the issue such that an entry is considered signed if at least one > of the digest algorithms is not disabled and the digest match passes. This > makes the fix consistent with how multiple digest algorithms are handled in > the Signature File. This also fixes an issue in the > `ManifestEntryVerifier.getParams()` method in which it was incorrectly > checking the algorithm constraints against all signers of a JAR when it > should check them only against the signers of the entry that is being > verified. > > An additional cache has also been added to avoid checking if the digest > algorithm is disabled more than once for entries signed by the same set of > signers. Marked as reviewed by coffeys (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7056
Re: RFR: 8278851: Correct signer logic for jars signed with multiple digestalgs
On Wed, 12 Jan 2022 21:57:22 GMT, Sean Mullan wrote: > If a JAR is signed with multiple digest algorithms and one of the digest > algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly > returning null indicating that the jar entry has no signers. > > This fixes the issue such that an entry is considered signed if at least one > of the digest algorithms is not disabled and the digest match passes. This > makes the fix consistent with how multiple digest algorithms are handled in > the Signature File. This also fixes an issue in the > `ManifestEntryVerifier.getParams()` method in which it was incorrectly > checking the algorithm constraints against all signers of a JAR when it > should check them only against the signers of the entry that is being > verified. > > An additional cache has also been added to avoid checking if the digest > algorithm is disabled more than once for entries signed by the same set of > signers. src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java line 212: > 210: > 211: CodeSigner[] entrySigners = sigFileSigners.get(name); > 212: Map permittedAlgs = maybe permittedAlgsChecker as variable name ? the Map contains both permitted and non-permitted algs. src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java line 239: > 237: > 238: // A non-disabled algorithm was used. > 239: disabledAlgs = false; this usage doesn't seem right. I think it's always set to false no matter what algs are detected. - PR: https://git.openjdk.java.net/jdk/pull/7056
Re: RFR: 8193682: Infinite loop in ZipOutputStream.close() [v14]
On Wed, 1 Dec 2021 05:35:11 GMT, Ravi Reddy wrote: >> Hi all, >> >> Please review this fix for Infinite loop in ZipOutputStream.close(). >> The main issue here is when ever there is an exception during close >> operations on GZip we are not setting the deflator to a finished state which >> is leading to an infinite loop when we try writing on the same GZip >> instance( since we use while(!def.finished()) inside the write operation). >> >> Thanks, >> Ravi > > Ravi Reddy has updated the pull request incrementally with one additional > commit since the last revision: > > Change in test case name from GZipLoopTest.java to CloseDeflaterTest , > moved testcase to util/zip/ Marked as reviewed by coffeys (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5522
Re: RFR: 8193682: Infinite loop in ZipOutputStream.close() [v13]
On Thu, 18 Nov 2021 19:09:18 GMT, Ravi Reddy wrote: >> Hi all, >> >> Please review this fix for Infinite loop in ZipOutputStream.close(). >> The main issue here is when ever there is an exception during close >> operations on GZip we are not setting the deflator to a finished state which >> is leading to an infinite loop when we try writing on the same GZip >> instance( since we use while(!def.finished()) inside the write operation). >> >> Thanks, >> Ravi > > Ravi Reddy has updated the pull request incrementally with one additional > commit since the last revision: > > Added ZipException case to handle failure CopyZipFile.java - Only close the > deflater incase of IOException not in ZipException case scenario could you move the test up one directory to java/util/zip ? I don't think it's particular to GZIP any longer. Also perhaps a rename to something like CloseDeflaterTest etc. - PR: https://git.openjdk.java.net/jdk/pull/5522
Re: RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v4]
On Wed, 24 Nov 2021 16:56:35 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>>Signed-off-by: Andrew Leonard
>> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>>Signed-off-by: Andrew Leonard
>> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>>Signed-off-by: Andrew Leonard
>> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>>Signed-off-by: Andrew Leonard
>> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>>Signed-off-by: Andrew Leonard
>
> src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 2290:
>
>> 2288: private void setSourceDate(ZipEntry e, long origTime) {
>> 2289: if (sourceDate != -1) {
>> 2290: e.setTimeLocal(LocalDateTime.ofEpochSecond(sourceDate, 0,
>> ZoneOffset.UTC));
>
> The above could potentially throw a DateTimeException which may be OK but I
> would sanity check there are no issues
For files with large number of entries, alot of LocalDateTime Objects are being
created here. Would there be an efficiency gain by converting sourceDate
variable to be of type LocalDateTime and simply pass it to the s.setTimeLocal
call here. The LocalDateTime Object could be constructed at init time (may be
null) and can be static etc.
Same for jmod code ?
-
PR: https://git.openjdk.java.net/jdk/pull/6481
Re: RFR: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766
On Wed, 3 Nov 2021 07:05:08 GMT, Yoshiki Sato wrote: > Please review this PR to update the TimeZoneNames files. @naotoj @coffeys > > Some short name changes are not integrated to the JDK. It was detected by the > change made in JDK-8275766. > - Africa/Juba change was done by 2017c > - Africa/Windhoek changes were done by 2018e > - Antarctica/Macquarie change was done by 2017a Marked as reviewed by coffeys (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6226
Re: RFR: 8275766: (tz) Update Timezone Data to 2021e
On Thu, 28 Oct 2021 01:02:27 GMT, Yoshiki Sato wrote: > Please review the integration of tzdata2021e (including tzdata2021d) to the > JDK. > The fix has passed all relevant JTREG regression tests and JCK tests. > > 8275754: (tz) Update Timezone Data to 2021d > 8275849: TestZoneInfo310.java fails with tzdata2021e Marked as reviewed by coffeys (Reviewer). I think you've enough Reviewers already but yes, this looks fine. - PR: https://git.openjdk.java.net/jdk/pull/6144
Re: RFR: JDK-8276236: Table headers missing in Formatter api docs
On Mon, 1 Nov 2021 15:59:22 GMT, Ludvig Janiuk wrote: > Adds table headers to all tables in Formatter api docs. I inferred the header > "Unicode" for the columns that contained unicode > codepoints. > > Formatter api docs: > https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html LGTM - Marked as reviewed by coffeys (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6195
Re: RFR: 8193682: Infinite loop in ZipOutputStream.close() [v3]
On Tue, 12 Oct 2021 14:46:33 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/util/zip/DeflaterOutputStream.java line 256:
>>
>>> 254: } catch (Exception e) {
>>> 255: def.end();
>>> 256: out.close();
>>
>> out.close not needed with try with resources.
>
> This changes deflate to close the compressor and the output stream when there
> is an I/O exception. I expect this will need a spec change or a
> re-examination of the issue to see if there are alternatives.
the out.close() call could be removed I guess. Leave it for user code to handle
etc. Safer for spec also.
Main goal is to break the looping of the deflate call. The usesDefaultDeflater
boolean might be useful in helping determine if def.end() should be called or
not. If that boolean is false, then maybe we could just alter the input buffer
by setting it to a size 0 buffer (ZipUtils.defaultBuf) -- worth a look.
-
PR: https://git.openjdk.java.net/jdk/pull/5522
Re: RFR: 8193682: Infinite loop in ZipOutputStream.close() [v3]
On Tue, 12 Oct 2021 14:10:53 GMT, jmehrens wrote:
>> Ravi Reddy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8193682 : Infinite loop in ZipOutputStream.close()
>
> src/java.base/share/classes/java/util/zip/DeflaterOutputStream.java line 252:
>
>> 250: int len = def.deflate(buf, 0, buf.length);
>> 251: if (len > 0) {
>> 252: try {
>
> Shouldn't this use try with resources:
> try (out) { ...
the output stream is only closed if an exception is raised though ?
-
PR: https://git.openjdk.java.net/jdk/pull/5522
Re: RFR: 8193682: Infinite loop in ZipOutputStream.close() [v3]
On Tue, 12 Oct 2021 13:28:21 GMT, Ravi Reddy wrote: >> Hi all, >> >> Please review this fix for Infinite loop in ZipOutputStream.close(). >> The main issue here is when ever there is an exception during close >> operations on GZip we are not setting the deflator to a finished state which >> is leading to an infinite loop when we try writing on the same GZip >> instance( since we use while(!def.finished()) inside the write operation). >> >> Thanks, >> Ravi > > Ravi Reddy has updated the pull request incrementally with one additional > commit since the last revision: > > 8193682 : Infinite loop in ZipOutputStream.close() test/jdk/java/util/zip/GZIP/GZipLoopTest.java line 55: > 53: private static Random rand = new Random(); > 54: > 55: @Test I think we can condense the test code to aid maintenance - please consider using DataProvider - PR: https://git.openjdk.java.net/jdk/pull/5522
Re: RFR: 8274407: (tz) Update Timezone Data to 2021c
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote: > This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c > level. Note that the tz data is "as is", as released by IANA. No `merged > links` are retracted. > The PR also fixes two issues along with the 2021c upgrade. Marked as reviewed by coffeys (Reviewer). pre-1970 data for some time zones is lost or becomes inaccurate with this tzdata release. Do we plan to release-note that point ? - PR: https://git.openjdk.java.net/jdk/pull/5832
RFR: 8273826: Correct Manifest file name and NPE checks
Use correct manifest file name in the Manifest verifier checks. Also - extra null check The test doesn't reproduce the exact issue reported but should prevent future regressions in this area. - Commit messages: - 8273826: Correct Manifest file name and NPE checks Changes: https://git.openjdk.java.net/jdk/pull/5841/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5841&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273826 Stats: 137 lines in 5 files changed: 127 ins; 2 del; 8 mod Patch: https://git.openjdk.java.net/jdk/pull/5841.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5841/head:pull/5841 PR: https://git.openjdk.java.net/jdk/pull/5841
[jdk17] Integrated: 8269034: AccessControlException for SunPKCS11 daemon threads
On Tue, 22 Jun 2021 13:26:41 GMT, Sean Coffey wrote: > Sufficient permissions missing if this code was ever to run with > SecurityManager. > > Cleanest approach appears to be use of InnocuousThread to create the > cleaner/poller threads. > Test case coverage extended to cover the SecurityManager scenario. > > Reviewer request: @valeriepeng This pull request has now been integrated. Changeset: 0d745ae8 Author:Sean Coffey URL: https://git.openjdk.java.net/jdk17/commit/0d745ae8fde5cab290dc8c695d2906f9a98c491c Stats: 95 lines in 5 files changed: 53 ins; 17 del; 25 mod 8269034: AccessControlException for SunPKCS11 daemon threads Reviewed-by: valeriep - PR: https://git.openjdk.java.net/jdk17/pull/117
Re: [jdk17] RFR: 8269034: AccessControlException for SunPKCS11 daemon threads [v3]
> Sufficient permissions missing if this code was ever to run with > SecurityManager. > > Cleanest approach appears to be use of InnocuousThread to create the > cleaner/poller threads. > Test case coverage extended to cover the SecurityManager scenario. > > Reviewer request: @valeriepeng Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Edits from review - Merge remote-tracking branch 'origin/master' into pkcs11-perms - Move TokenPoller to Runnable - 8269034: AccessControlException for SunPKCS11 daemon threads - Changes: - all: https://git.openjdk.java.net/jdk17/pull/117/files - new: https://git.openjdk.java.net/jdk17/pull/117/files/03af6494..e961ff09 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17&pr=117&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk17&pr=117&range=01-02 Stats: 3102 lines in 121 files changed: 2073 ins; 670 del; 359 mod Patch: https://git.openjdk.java.net/jdk17/pull/117.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/117/head:pull/117 PR: https://git.openjdk.java.net/jdk17/pull/117
Re: [jdk17] RFR: 8269034: AccessControlException for SunPKCS11 daemon threads [v2]
> Sufficient permissions missing if this code was ever to run with > SecurityManager. > > Cleanest approach appears to be use of InnocuousThread to create the > cleaner/poller threads. > Test case coverage extended to cover the SecurityManager scenario. > > Reviewer request: @valeriepeng Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Move TokenPoller to Runnable - Changes: - all: https://git.openjdk.java.net/jdk17/pull/117/files - new: https://git.openjdk.java.net/jdk17/pull/117/files/2a168946..03af6494 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17&pr=117&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17&pr=117&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17/pull/117.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/117/head:pull/117 PR: https://git.openjdk.java.net/jdk17/pull/117
[jdk17] RFR: 8269034: AccessControlException for SunPKCS11 daemon threads
Sufficient permissions missing if this code was ever to run with SecurityManager. Cleanest approach appears to be use of InnocuousThread to create the cleaner/poller threads. Test case coverage extended to cover the SecurityManager scenario. Reviewer request: @valeriepeng - Commit messages: - 8269034: AccessControlException for SunPKCS11 daemon threads Changes: https://git.openjdk.java.net/jdk17/pull/117/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=117&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269034 Stats: 112 lines in 5 files changed: 73 ins; 17 del; 22 mod Patch: https://git.openjdk.java.net/jdk17/pull/117.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/117/head:pull/117 PR: https://git.openjdk.java.net/jdk17/pull/117
Withdrawn: 8269034: AccessControlException for SunPKCS11 daemon threads
On Tue, 22 Jun 2021 12:01:07 GMT, Sean Coffey wrote: > Sufficient permissions missing if this code was ever to run with > SecurityManager. > > Cleanest approach appears to be use of InnocuousThread to create the > cleaner/poller threads. > Test case coverage extended to cover the SecurityManager scenario. > > Reviewer request: @valeriepeng This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/4555
Re: RFR: 8269034: AccessControlException for SunPKCS11 daemon threads
On Tue, 22 Jun 2021 12:01:07 GMT, Sean Coffey wrote: > Sufficient permissions missing if this code was ever to run with > SecurityManager. > > Cleanest approach appears to be use of InnocuousThread to create the > cleaner/poller threads. > Test case coverage extended to cover the SecurityManager scenario. > > Reviewer request: @valeriepeng Please ignore - I'm going to open a PR against jdk17 for this - PR: https://git.openjdk.java.net/jdk/pull/4555
RFR: 8269034: AccessControlException for SunPKCS11 daemon threads
Sufficient permissions missing if this code was ever to run with SecurityManager. Cleanest approach appears to be use of InnocuousThread to create the cleaner/poller threads. Test case coverage extended to cover the SecurityManager scenario. Reviewer request: @valeriepeng - Commit messages: - 8269034: AccessControlException for SunPKCS11 daemon threads Changes: https://git.openjdk.java.net/jdk/pull/4555/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4555&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269034 Stats: 112 lines in 5 files changed: 73 ins; 17 del; 22 mod Patch: https://git.openjdk.java.net/jdk/pull/4555.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4555/head:pull/4555 PR: https://git.openjdk.java.net/jdk/pull/4555
Re: RFR: 8183374: Refactor java/lang/Runtime shell tests to java
On Mon, 19 Apr 2021 15:07:16 GMT, Fernando Guallini wrote: > Refactor the following shell tests to java: > test/jdk/java/lang/RuntimeTests/shutdown/ShutdownHooks.sh > test/jdk/java/lang/Runtime/exec/SetCwd.java > > In addition, the test SetCwd was running itself in separate java subprocesses > in order to exercise Runtime.exec. It was creating a folder structure with > multiple test class copies to distinguish between main and child processes to > prevent an infinite recursion. That logic is simplified now, tests follow the > testng annotations flow whereas the subprocesses entry point is a nested > class main Marked as reviewed by coffeys (Reviewer). Looks fine to me. - PR: https://git.openjdk.java.net/jdk/pull/3572
Re: RFR: 8261160: Add a deserialization JFR event [v5]
On Fri, 12 Feb 2021 16:26:09 GMT, Chris Hegarty wrote: >> This issue adds a new event to improve diagnostic information of Java >> deserialization. The event captures the details of deserialization activity >> from ObjectInputStream. The event details are similar to that of the serial >> filter, but is agnostic of whether a filter is installed or not. The event >> also captures the filter status, if there is one. > > Chris Hegarty has updated the pull request incrementally with one additional > commit since the last revision: > > Split exception into type and message Marked as reviewed by coffeys (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2479
Re: RFR: 8261160: Add a deserialization JFR event [v3]
On Thu, 11 Feb 2021 15:28:07 GMT, Chris Hegarty wrote: >> This issue adds a new event to improve diagnostic information of Java >> deserialization. The event captures the details of deserialization activity >> from ObjectInputStream. The event details are similar to that of the serial >> filter, but is agnostic of whether a filter is installed or not. The event >> also captures the filter status, if there is one. > > Chris Hegarty has updated the pull request incrementally with one additional > commit since the last revision: > > Fix failing test Marked as reviewed by coffeys (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2479
Re: RFR: 8261160: Add a deserialization JFR event
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote: > This issue adds a new event to improve diagnostic information of Java > deserialization. The event captures the details of deserialization activity > from ObjectInputStream. The event details are similar to that of the serial > filter, but is agnostic of whether a filter is installed or not. The event > also captures the filter status, if there is one. Marked as reviewed by coffeys (Reviewer). test/jdk/java/io/Serializable/serialFilter/GlobalFilterTest.java line 50: > 48: * -Dexpected-jdk.serialFilter=java.** GlobalFilterTest > 49: * @run testng/othervm/policy=security.policy GlobalFilterTest > 50: * @run testng/othervm/policy=security.policy You may want to add a "@requires vm.hasJFR" condition to this test - PR: https://git.openjdk.java.net/jdk/pull/2479
Integrated: 8250968: Symlinks attributes not preserved when using jarsigner on zip files
On Mon, 7 Sep 2020 13:48:57 GMT, Sean Coffey wrote: > Continuation of RFR thread from > http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html > > CSR has been approved. This pull request has now been integrated. Changeset: 7686e871 Author: Sean Coffey URL: https://git.openjdk.java.net/jdk/commit/7686e871 Stats: 200 lines in 10 files changed: 1 ins; 162 del; 37 mod 8250968: Symlinks attributes not preserved when using jarsigner on zip files Reviewed-by: lancea, weijun, hchao - PR: https://git.openjdk.java.net/jdk/pull/56
Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files [v2]
> Continuation of RFR thread from > http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html > > CSR has been approved. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Copyright and test clean up - Changes: - all: https://git.openjdk.java.net/jdk/pull/56/files - new: https://git.openjdk.java.net/jdk/pull/56/files/2f656ce0..27cb91f3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=56&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=56&range=00-01 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/56.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/56/head:pull/56 PR: https://git.openjdk.java.net/jdk/pull/56
RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files
Continuation of RFR thread from http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html CSR has been approved. - Commit messages: - JDK-8250968 Changes: https://git.openjdk.java.net/jdk/pull/56/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=56&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8250968 Stats: 198 lines in 10 files changed: 162 ins; 1 del; 35 mod Patch: https://git.openjdk.java.net/jdk/pull/56.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/56/head:pull/56 PR: https://git.openjdk.java.net/jdk/pull/56
Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code
Thanks Mandy. I pushed this change earlier today. If
BasicImageReader.java is being edited again in the near future, we might
be able to make your suggested edits then.
regards,
Sean.
On 22/09/2016 19:23, Mandy Chung wrote:
On Sep 21, 2016, at 8:56 AM, Seán Coffey wrote:
Resurrecting this old review thread. After some internal discussion, I've
dropped the minor edit that was made in StackTraceElementCompositeData. It
could be noisy data for exception purposes. I've corrected the other issues
raised by Alan and Jim has long pushed the changes mentioned below.
webrev : http://cr.openjdk.java.net/~coffeys/webrev.8151832.v3/webrev/
The change looks okay.
src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java
189 throw new IOException("The image file \"" + name + "\" is not
" +
190 "the correct version. Major: " + result.getMajorVersion()
+
191 ". Minor: " + result.getMinorVersion());
One suggestion for this exception message to:
throw new IOException("The image file \"" + name + "\” version “ +
result.getMajorVersion() + "." + result.getMinorVersion() +
“ not supported”);
No need for a new webrev and you can update this before you push.
Mandy
Re: RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code
On 22/09/2016 14:14, Alan Bateman wrote: This looks okay to me. You may want to change the bug message to drop "thrown by jigsaw code" as most of the changed files are jimage or other areas. Thanks Alan - Yes - will correct that before I push then. regards, Sean.
Re: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() doesn't return true on ppc
Sounds good Volker. Good catch.
regards,
Sean.
On 13/09/2016 13:09, Volker Simonis wrote:
Hi Sean,
thanks a lot for the fast response. I've updated the bug entry as
requested and will push the change - maybe with the following
potential improvement:
@Hiroshi: also maybe not that performance relevant, I think we should
we also fix sun/security/provider/ByteArrayAccess.java which contains
the same construct:
// Return whether this platform supports full speed int/long memory access
// at unaligned addresses.
// This code was copied from java.nio.Bits because there is no equivalent
// public API.
private static boolean unaligned() {
String arch = java.security.AccessController.doPrivileged
(new sun.security.action.GetPropertyAction("os.arch", ""));
return arch.equals("i386") || arch.equals("x86") ||
arch.equals("amd64")
|| arch.equals("x86_64");
}
Regards,
Volker
Re: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() doesn't return true on ppc
Hi Volker, The fix looks fine to me. Please add the '9-na' label to the bug report. Also add a suitable noreg- label. It would also be useful to link the issue to JDK-8158260 Approved for jdk8u-dev. regards, Sean. On 13/09/2016 09:37, Volker Simonis wrote: Hi Alan, Sean, can we please get a review for this rather trivial change? jira: https://bugs.openjdk.java.net/browse/JDK-8165231 webrev: http://cr.openjdk.java.net/~gromero/8165231/ As outlined in Hiroshi's initial mail, we can not simply downport the solution used in jdk9 for querying the unaligned access support in nio because of differences in Unsafe. So this is a jsk8u-only change. But I think it is simple enough and doesn't affect any other platform except ppc to justify it. As nobody from the ppc porting team is jdk8u reviewer, I kindly ask you for a review and the permission to integrate into jdk8u. Thanks a lot and best regards, Volker On Thu, Sep 1, 2016 at 5:06 PM, Doerr, Martin wrote: Hi Hiroshi, thanks for providing a fix. The fix 8158260: PPC64: unaligned Unsafe.getInt can lead to the generation of illegal instructions was downported to 8, so I think your change is good. Best regards, Martin From: Hiroshi H Horii [mailto:ho...@jp.ibm.com] Sent: Donnerstag, 1. September 2016 16:27 To: jdk8u-...@openjdk.java.net; ppc-aix-port-...@openjdk.java.net Cc: Gustavo Bueno Romero ; Volker Simonis (volker.simo...@gmail.com) ; Doerr, Martin Subject: RFR(m): java.nio.Bits.unaligned() doesn't return true on ppc Dear all: Can I please request reviews for the following change? This change was created for JDK 8. Some open sources (such as Spark 2.0) check java.nio.Bits.unaligned() to recognize support of unaligned memory access in platform. Though ppc64 and ppc64le support it, unaligned() returns false. In JDK 9, this method returns unalignedAccess() of jdk.internal.misc.Unsafe that doesn't exist in JDK8. jira: https://bugs.openjdk.java.net/browse/JDK-8165231 webrev: http://cr.openjdk.java.net/~gromero/8165231/ (Due to my login issue to the cs.openjdk.java.net, Gustavo thankfully created this webrev.) Regards, Hiroshi --- Hiroshi Horii, Ph.D. IBM Research - Tokyo
RFR: 8149450: LdapCtx.processReturnCode() throwing Null Pointer Exception
Looking to fix this issue. Better checks for the referrrals field. bugID : https://bugs.openjdk.java.net/browse/JDK-8149450 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8149450.jdk9/webrev/ regards, Sean.
hg: jdk8/tl/corba: 8035618: Four api/org_omg/CORBA TCK tests fail under plugin only
Changeset: 0683ee308085 Author:coffeys Date: 2014-02-26 23:04 + URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0683ee308085 8035618: Four api/org_omg/CORBA TCK tests fail under plugin only Reviewed-by: mchung, chegar ! src/share/classes/com/sun/corba/se/spi/orb/ORB.java
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 46c727d6ecc2 Author:aefimov Date: 2013-12-30 16:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c727d6ecc2 8025051: Update resource files for TimeZone display names Reviewed-by: okutsu, mfang ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/java/util/Calendar/GenericTimeZoneNamesTest.sh ! test/sun/util/resources/TimeZone/Bug6317929.java + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNamesTest.java + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_de.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_de_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_es.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_es_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_fr.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_fr_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_it.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_it_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ja.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ja_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ko.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ko_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_pt_BR.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_pt_BR_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_sv.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_sv_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_CN.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_CN_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_TW.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_TW_short.properties Changeset: c0970860803e Author:coffeys Date: 2014-01-03 16:45 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0970860803e Merge
hg: jdk8/tl/corba: 8029231: Update copyright years for files in corba repository for 2013
Changeset: 5ca1b4c282b8 Author:ssides Date: 2013-12-23 18:42 + URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5ca1b4c282b8 8029231: Update copyright years for files in corba repository for 2013 Reviewed-by: mchung, coffeys ! src/share/classes/com/sun/corba/se/impl/io/IIOPInputStream.java ! src/share/classes/com/sun/corba/se/impl/io/InputStreamHook.java ! src/share/classes/com/sun/corba/se/impl/io/OutputStreamHook.java ! src/share/classes/com/sun/corba/se/impl/ior/EncapsulationUtility.java ! src/share/classes/com/sun/corba/se/impl/ior/ObjectKeyImpl.java ! src/share/classes/com/sun/corba/se/impl/javax/rmi/CORBA/StubDelegateImpl.java ! src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator.java ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_de.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_es.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_fr.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_it.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ja.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ko.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_pt_BR.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_sv.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_zh_CN.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_zh_TW.properties ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLNameTranslatorImpl.java ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/InvocationHandlerFactoryImpl.java ! src/share/classes/com/sun/corba/se/impl/transport/DefaultSocketFactoryImpl.java ! src/share/classes/com/sun/corba/se/spi/orbutil/proxy/CompositeInvocationHandlerImpl.java ! src/share/classes/com/sun/tools/corba/se/idl/idl_ja.prp ! src/share/classes/com/sun/tools/corba/se/idl/idl_zh_CN.prp ! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_ja.prp ! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_zh_CN.prp ! src/share/classes/javax/rmi/CORBA/Stub.java ! src/share/classes/javax/rmi/CORBA/Util.java ! src/share/classes/javax/rmi/PortableRemoteObject.java ! src/share/classes/sun/rmi/rmic/iiop/CompoundType.java
hg: jdk8/tl/jdk: 8029347: sun/rmi/runtime/Log/checkLogging/CheckLogging.java fails in nightly intermittently
Changeset: 0f1332dd805c Author:coffeys Date: 2013-12-04 17:03 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f1332dd805c 8029347: sun/rmi/runtime/Log/checkLogging/CheckLogging.java fails in nightly intermittently Reviewed-by: alanb ! test/sun/rmi/runtime/Log/checkLogging/CheckLogging.java
hg: jdk8/tl/jdk: 3 new changesets
Changeset: cd56de5896b4 Author:aefimov Date: 2013-11-15 15:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd56de5896b4 8027848: The ZoneInfoFile doesn't honor future GMT offset changes Reviewed-by: sherman, coffeys ! src/share/classes/sun/util/calendar/ZoneInfoFile.java Changeset: ebd47f6ab172 Author:aefimov Date: 2013-11-21 20:48 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ebd47f6ab172 8027370: Support tzdata2013h Reviewed-by: sherman, coffeys ! make/data/tzdata/VERSION ! make/data/tzdata/africa ! make/data/tzdata/southamerica ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/southamerica Changeset: 3b50d682e7c1 Author:coffeys Date: 2013-11-22 09:56 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b50d682e7c1 Merge
hg: jdk8/tl/jdk: 8016728: TEST_BUG: test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing intermittently
Changeset: f2ccd3530476 Author:coffeys Date: 2013-11-19 16:22 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2ccd3530476 8016728: TEST_BUG: test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing intermittently Reviewed-by: chegar ! test/java/rmi/transport/closeServerSocket/CloseServerSocket.java
hg: jdk8/tl/jdk: 8028583: Add helper methods to test libraries
Changeset: d1bb85f0a45a Author:coffeys Date: 2013-11-19 14:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1bb85f0a45a 8028583: Add helper methods to test libraries Reviewed-by: chegar ! test/java/rmi/testlibrary/TestLibrary.java ! test/lib/testlibrary/jdk/testlibrary/FileUtils.java
hg: jdk8/tl/jdk: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing
Changeset: d34c5e860d5f Author:aefimov Date: 2013-10-24 17:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d34c5e860d5f 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing Reviewed-by: okutsu, mfang, alanb ! test/ProblemList.txt ! test/sun/util/resources/TimeZone/Bug6317929.java
hg: jdk8/tl/jdk: 8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly aurora test runs
Changeset: ee7f1c78bec7 Author:coffeys Date: 2013-10-23 20:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee7f1c78bec7 8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly aurora test runs Reviewed-by: chegar ! test/javax/xml/ws/clientjar/TestWsImport.java
hg: jdk8/tl/corba: 5036554: unmarshal error on CORBA alias type in CORBA any
Changeset: a90e9efa4264 Author:coffeys Date: 2013-10-23 16:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a90e9efa4264 5036554: unmarshal error on CORBA alias type in CORBA any Reviewed-by: chegar, smarks ! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java
hg: jdk8/tl/jdk: 5036554: unmarshal error on CORBA alias type in CORBA any
Changeset: 2af3f5a61322 Author:coffeys Date: 2013-10-23 16:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2af3f5a61322 5036554: unmarshal error on CORBA alias type in CORBA any Reviewed-by: chegar, smarks + test/com/sun/corba/5036554/JavaBug.java + test/com/sun/corba/5036554/README + test/com/sun/corba/5036554/TestCorbaBug.sh + test/com/sun/corba/5036554/bug.idl
hg: jdk8/tl/jdk: 8025255: (tz) Support tzdata2013g
Changeset: 60e3cdbe8cdf Author:aefimov Date: 2013-10-13 14:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60e3cdbe8cdf 8025255: (tz) Support tzdata2013g Reviewed-by: okutsu, mfang ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/backward ! make/sun/javazic/tzdata/etcetera ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/iso3166.tab ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/antarctica ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/australasia ! test/sun/util/calendar/zi/tzdata/backward ! test/sun/util/calendar/zi/tzdata/etcetera ! test/sun/util/calendar/zi/tzdata/europe ! test/sun/util/calendar/zi/tzdata/iso3166.tab ! test/sun/util/calendar/zi/tzdata/leapseconds ! test/sun/util/calendar/zi/tzdata/northamerica ! test/sun/util/calendar/zi/tzdata/southamerica ! test/sun/util/calendar/zi/tzdata/zone.tab
hg: jdk8/tl/jdk: 8024952: ClassCastException in PlainSocketImpl.accept() when using custom socketImpl
Changeset: 368172cb6dc5 Author:coffeys Date: 2013-10-02 09:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/368172cb6dc5 8024952: ClassCastException in PlainSocketImpl.accept() when using custom socketImpl Reviewed-by: chegar ! src/windows/classes/java/net/PlainSocketImpl.java + test/java/net/PlainSocketImpl/CustomSocketImplFactory.java
hg: jdk8/tl/corba: 8017195: Introduce option to setKeepAlive parameter on CORBA sockets
Changeset: af8e5bc3a150 Author:coffeys Date: 2013-09-03 22:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/af8e5bc3a150 8017195: Introduce option to setKeepAlive parameter on CORBA sockets Reviewed-by: chegar, msheppar ! src/share/classes/com/sun/corba/se/impl/transport/DefaultSocketFactoryImpl.java
hg: jdk8/tl/jdk: 8017195: Introduce option to setKeepAlive parameter on CORBA sockets
Changeset: 5920155dd080 Author:coffeys Date: 2013-09-03 22:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5920155dd080 8017195: Introduce option to setKeepAlive parameter on CORBA sockets Reviewed-by: chegar, msheppar + test/com/sun/corba/transport/KeepAliveSockets.java
hg: jdk8/tl/jdk: 8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions
Changeset: 92a66af7f834 Author:igerasim Date: 2013-08-26 18:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92a66af7f834 8016018: Typo in AbstractStringBuilder#indexOf and #lastIndexOf descriptions Reviewed-by: alanb, chegar ! src/share/classes/java/lang/AbstractStringBuilder.java
hg: jdk8/tl/jdk: 8017566: Backout 8000450 - Cannot access to com.sun.corba.se.impl.orb.ORBImpl
Changeset: 7cc35dd1885d Author:coffeys Date: 2013-07-15 13:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cc35dd1885d 8017566: Backout 8000450 - Cannot access to com.sun.corba.se.impl.orb.ORBImpl Reviewed-by: mchung ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java
hg: jdk8/tl/jdk: 8019979: Replace CheckPackageAccess test with better one from closed repo
Changeset: 83c2976ef8ee Author:coffeys Date: 2013-07-09 16:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83c2976ef8ee 8019979: Replace CheckPackageAccess test with better one from closed repo Reviewed-by: mullan ! test/java/lang/SecurityManager/CheckPackageAccess.java
hg: jdk8/tl/jdk: 8015978: Incorrect transformation of XPath expression "string(-0)"
Changeset: 45a3584bfacf Author:coffeys Date: 2013-06-14 15:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45a3584bfacf 8015978: Incorrect transformation of XPath expression "string(-0)" Reviewed-by: darcy, joehw Contributed-by: aleksej.efi...@oracle.com + test/javax/xml/jaxp/XPath/8015978/XPathNegativeZero.java + test/javax/xml/jaxp/XPath/8015978/dummy.xml + test/javax/xml/jaxp/XPath/8015978/negativezero.xsl
hg: jdk8/tl/jaxp: 8015978: Incorrect transformation of XPath expression "string(-0)"
Changeset: 659828443145 Author:coffeys Date: 2013-06-14 15:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 8015978: Incorrect transformation of XPath expression "string(-0)" Reviewed-by: darcy, joehw Contributed-by: aleksej.efi...@oracle.com ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java
hg: jdk8/tl/jdk: 8000450: Restrict access to com/sun/corba/se/impl package
Changeset: c4480e0d9f53 Author:coffeys Date: 2013-06-06 14:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4480e0d9f53 8000450: Restrict access to com/sun/corba/se/impl package Reviewed-by: alanb, chegar, lancea ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java
hg: jdk8/tl/jdk: 8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z and z pattern letters
Changeset: 5871d7b1673c Author:coffeys Date: 2013-04-25 21:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5871d7b1673c 8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z and z pattern letters Reviewed-by: okutsu ! src/share/classes/java/text/CalendarBuilder.java ! src/share/classes/java/text/SimpleDateFormat.java ! test/java/text/Format/DateFormat/Bug7130335.java
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 885bb24f6018 Author:coffeys Date: 2013-02-19 14:07 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/885bb24f6018 7197187: Currency.isPastCutoverDate should be made more robust Reviewed-by: alanb ! src/share/classes/java/util/Currency.java Changeset: 01b6b0dd2006 Author:coffeys Date: 2013-02-19 14:12 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b6b0dd2006 8007315: HttpURLConnection.filterHeaderField method returns null where empty string is expected Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! test/sun/net/www/protocol/http/HttpOnly.java
hg: jdk8/tl/corba: 7196086: update copyright years for files in corba repository (JDK 8)
Changeset: 679e8ad9874f Author:coffeys Date: 2012-10-09 20:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/679e8ad9874f 7196086: update copyright years for files in corba repository (JDK 8) Reviewed-by: lancea ! make/common/Defs-bsd.gmk ! make/common/internal/Resources.gmk ! make/common/shared/Defs-bsd.gmk ! make/common/shared/Defs-utils.gmk ! make/tools/src/build/tools/stripproperties/StripPropertiesCorba.java ! make/tools/strip_properties/Makefile
hg: jdk8/tl/jdk: 7181793: Socket getOutputStream create streams that cannot be GC'ed until Socket is closed
Changeset: 71de5e31d497 Author:coffeys Date: 2012-10-09 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71de5e31d497 7181793: Socket getOutputStream create streams that cannot be GC'ed until Socket is closed Reviewed-by: alanb, chegar ! src/share/classes/java/net/AbstractPlainSocketImpl.java + test/java/net/Socket/SocketGrowth.java
hg: jdk8/tl/jdk: 7196533: TimeZone.getDefault() slow due to synchronization bottleneck
Changeset: fecba6a8b78e Author:coffeys Date: 2012-10-09 12:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fecba6a8b78e 7196533: TimeZone.getDefault() slow due to synchronization bottleneck Reviewed-by: okutsu ! src/share/classes/java/util/TimeZone.java
hg: jdk8/tl/jdk: 7180362: RFE: Implement date cutover functionality for currency.properties file
Changeset: fffbb33df102 Author:coffeys Date: 2012-09-07 21:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fffbb33df102 7180362: RFE: Implement date cutover functionality for currency.properties file Reviewed-by: naoto ! src/share/classes/java/util/Currency.java ! test/java/util/Currency/PropertiesTest.java ! test/java/util/Currency/PropertiesTest.sh ! test/java/util/Currency/currency.properties
hg: jdk8/tl/jdk: 7195063: [TEST] jtreg flags com/sun/corba/cachedSocket/7056731.sh with Error failure.
Changeset: da1436b21bc2 Author:coffeys Date: 2012-08-31 12:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da1436b21bc2 7195063: [TEST] jtreg flags com/sun/corba/cachedSocket/7056731.sh with Error failure. Reviewed-by: chegar ! test/com/sun/corba/cachedSocket/7056731.sh
hg: jdk8/tl/jdk: 7185965: Build error in javadoc make stage for bundles not containing crypto package
Changeset: 56d8756749bd Author:coffeys Date: 2012-08-16 10:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56d8756749bd 7185965: Build error in javadoc make stage for bundles not containing crypto package Reviewed-by: chegar ! make/common/shared/Defs-java.gmk
hg: jdk8/tl/corba: 7056731: Race condition in CORBA code causes re-use of ABORTed connections
Changeset: 18a02ad8dc73 Author:coffeys Date: 2012-08-16 10:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/18a02ad8dc73 7056731: Race condition in CORBA code causes re-use of ABORTed connections Reviewed-by: lancea Contributed-by: d.macdon...@auckland.ac.nz ! src/share/classes/com/sun/corba/se/impl/transport/CorbaResponseWaitingRoomImpl.java ! src/share/classes/com/sun/corba/se/impl/transport/SocketOrChannelConnectionImpl.java
hg: jdk8/tl/jdk: 7056731: Race condition in CORBA code causes re-use of ABORTed connections
Changeset: 39b01268b845 Author:coffeys Date: 2012-08-16 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39b01268b845 7056731: Race condition in CORBA code causes re-use of ABORTed connections Reviewed-by: lancea Contributed-by: d.macdon...@auckland.ac.nz ! test/Makefile + test/com/sun/corba/cachedSocket/7056731.sh + test/com/sun/corba/cachedSocket/Hello.idl + test/com/sun/corba/cachedSocket/HelloClient.java + test/com/sun/corba/cachedSocket/HelloServer.java
hg: jdk8/tl/jdk: 7179879: SSLSocket connect times out instead of throwing socket closed exception
Changeset: 35fec642fd32 Author:coffeys Date: 2012-07-26 22:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35fec642fd32 7179879: SSLSocket connect times out instead of throwing socket closed exception Reviewed-by: xuelei, chegar ! src/share/classes/sun/security/ssl/SSLSocketImpl.java
hg: jdk8/tl/corba: 7162902: Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8
Changeset: 47adb42076f1 Author:coffeys Date: 2012-06-27 21:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/47adb42076f1 7162902: Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8 Reviewed-by: lancea ! src/share/classes/com/sun/corba/se/impl/encoding/CachedCodeBase.java ! src/share/classes/com/sun/corba/se/impl/interceptors/PIHandlerImpl.java ! src/share/classes/com/sun/corba/se/impl/interceptors/PINoOpHandlerImpl.java ! src/share/classes/com/sun/corba/se/impl/monitoring/MonitoringManagerFactoryImpl.java ! src/share/classes/com/sun/corba/se/impl/monitoring/MonitoringManagerImpl.java ! src/share/classes/com/sun/corba/se/impl/orb/ORBImpl.java ! src/share/classes/com/sun/corba/se/impl/orbutil/threadpool/ThreadPoolImpl.java ! src/share/classes/com/sun/corba/se/impl/orbutil/threadpool/ThreadPoolManagerImpl.java ! src/share/classes/com/sun/corba/se/impl/orbutil/threadpool/WorkQueueImpl.java ! src/share/classes/com/sun/corba/se/impl/protocol/CorbaMessageMediatorImpl.java ! src/share/classes/com/sun/corba/se/impl/transport/SelectorImpl.java ! src/share/classes/com/sun/corba/se/spi/logging/data/ORBUtil.mc ! src/share/classes/com/sun/corba/se/spi/monitoring/MonitoringManager.java ! src/share/classes/com/sun/corba/se/spi/monitoring/MonitoringManagerFactory.java ! src/share/classes/com/sun/corba/se/spi/orb/ORB.java ! src/share/classes/com/sun/corba/se/spi/orbutil/threadpool/ThreadPool.java ! src/share/classes/com/sun/corba/se/spi/orbutil/threadpool/ThreadPoolManager.java ! src/share/classes/com/sun/corba/se/spi/protocol/PIHandler.java ! src/share/classes/com/sun/corba/se/spi/protocol/RequestDispatcherRegistry.java
hg: jdk8/tl/jdk: 6893617: JDK 6 CNCtx always uses the default ORB
Changeset: 612e56cf284c Author:coffeys Date: 2012-06-27 21:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/612e56cf284c 6893617: JDK 6 CNCtx always uses the default ORB Reviewed-by: lancea ! src/share/classes/com/sun/jndi/cosnaming/CNCtx.java
RFR : 7162902 / 6893617 Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8
Hi, I'm looking for a code review around the following corba changes. It turns out that we've a few bug fixes in corba area for jdk6 that were never forward ported to jdk7 or 8. The port is pretty much identical to what was used in JDK6. Some formatting and diamond operator changes introduced but that's about it. There were a few bug fixes to follow up on regressions around the initial fix but this umbrella port should cover all issues. The initial bugs fixes were fixed under the "jets" category in the bug tool and that category entered read only mode over a year ago. Hence the requirement for a new bug ID. The main bug fix is 6725987 which is an issue where references to the ORB were being kept after ORB.destroy was called. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7162902 An accompanying CNCtx fix in JDK repo is also made to correct an issue where the java.naming.corba.orb system property wasn't used correctly. (CR 6893617) http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6893617 Corba testsuites run and no issues seen. I've also run some JCK testing and saw no issues. http://cr.openjdk.java.net/~coffeys/webrev.7162902.jdk8/ (corba) http://cr.openjdk.java.net/~coffeys/webrev.6893617.jdk8/ (jdk) The corba codebase code formatting seems to vary quite a bit. I've reformatted in a small number of areas but the whole corba repo probably warrants it's own clean up project at a later date. regards, Sean.
hg: jdk8/tl/jdk: 7156963: Incorrect copyright header in java/io/SerialCallbackContext
Changeset: 00c9d6cce3ec Author:coffeys Date: 2012-06-15 14:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/00c9d6cce3ec 7156963: Incorrect copyright header in java/io/SerialCallbackContext Reviewed-by: weijun, coffeys Contributed-by: edvard.wende...@oracle.com ! src/share/classes/java/io/SerialCallbackContext.java
hg: jdk8/tl/jdk: 7167359: (tz) SEGV on solaris if TZ variable not set
Changeset: 3e83229a3779 Author:coffeys Date: 2012-05-11 10:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e83229a3779 7167359: (tz) SEGV on solaris if TZ variable not set Reviewed-by: okutsu ! src/solaris/native/java/util/TimeZone_md.c
hg: jdk8/tl/jdk: 7163470: Build fails if javax.crypto src files not present
Changeset: fdf5e15293e6 Author:coffeys Date: 2012-05-10 10:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fdf5e15293e6 7163470: Build fails if javax.crypto src files not present Reviewed-by: valeriep ! make/com/oracle/security/ucrypto/Makefile ! make/common/shared/Defs-java.gmk ! make/sun/security/ec/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! makefiles/com/oracle/security/ucrypto/Makefile ! makefiles/common/shared/Defs-java.gmk ! makefiles/sun/security/ec/Makefile ! makefiles/sun/security/mscapi/Makefile ! makefiles/sun/security/pkcs11/Makefile
hg: jdk8/tl/corba: 7161925: sjava files in corba don't have copyright string and legal notice
Changeset: 9cdcc0152526 Author:coffeys Date: 2012-04-20 17:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/9cdcc0152526 7161925: sjava files in corba don't have copyright string and legal notice Reviewed-by: chegar Contributed-by: misha.by...@oracle.com ! src/share/classes/com/sun/corba/se/impl/orbutil/DefineWrapper.sjava ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLTypesUtil_save.sjava
hg: jdk8/tl/jdk: 7149608: Default TZ detection fails on linux when symbolic links to non default location used.
Changeset: 6bbafa8404eb Author:coffeys Date: 2012-03-13 11:01 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6bbafa8404eb 7149608: Default TZ detection fails on linux when symbolic links to non default location used. Reviewed-by: alanb, okutsu ! src/solaris/native/java/util/TimeZone_md.c
hg: jdk8/tl/jdk: 7148584: Jar tools fails to generate manifest correctly when boundary condition hit
Changeset: 134d9f4f9498 Author:coffeys Date: 2012-03-12 11:30 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134d9f4f9498 7148584: Jar tools fails to generate manifest correctly when boundary condition hit Reviewed-by: alanb, sherman ! src/share/classes/java/util/jar/Manifest.java + test/java/util/jar/Manifest/CreateManifest.java
hg: jdk8/tl/jdk: 7144488: Infinite recursion for some equals tests in Collections
Changeset: 0a350fb8b174 Author:coffeys Date: 2012-02-24 09:17 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a350fb8b174 7144488: Infinite recursion for some equals tests in Collections Reviewed-by: alanb, dholmes, mduigou ! src/share/classes/java/util/Collections.java + test/java/util/Collections/EqualsTest.java
hg: jdk8/tl/jdk: 7133138: Improve io performance around timezone lookups
Changeset: a589a8dbde79 Author:coffeys Date: 2012-02-24 09:10 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a589a8dbde79 7133138: Improve io performance around timezone lookups Reviewed-by: okutsu ! make/tools/src/build/tools/javazic/Mappings.java ! src/share/classes/sun/util/calendar/ZoneInfo.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java
hg: jdk8/tl/jdk: 7102369: remove java.rmi.server.codebase property parsing from registyimpl; ...
Changeset: d27f0b2f1476 Author:coffeys Date: 2011-11-23 14:55 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d27f0b2f1476 7102369: remove java.rmi.server.codebase property parsing from registyimpl 7094468: rmiregistry clean up Reviewed-by: smarks ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/rmi/server/LoaderHandler.java + test/java/rmi/registry/readTest/readTest.java + test/java/rmi/registry/readTest/readTest.sh + test/java/rmi/registry/readTest/testPkg/Client.java + test/java/rmi/registry/readTest/testPkg/Hello.java + test/java/rmi/registry/readTest/testPkg/Server.java
hg: jdk8/tl/corba: 7091388: Regular unexplained npe's from corba libs after system has been running for days
Changeset: 44c269731425 Author:coffeys Date: 2011-11-11 10:16 + URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/44c269731425 7091388: Regular unexplained npe's from corba libs after system has been running for days Reviewed-by: alanb ! src/share/classes/com/sun/corba/se/impl/encoding/CDRInputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDRInputStream_1_0.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDROutputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDROutputStream_1_0.java
hg: jdk8/tl/jdk: 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile
Changeset: 9dd994f319ee Author:coffeys Date: 2011-11-11 10:08 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9dd994f319ee 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile Reviewed-by: alanb ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java ! src/solaris/classes/java/io/FileDescriptor.java ! src/windows/classes/java/io/FileDescriptor.java - test/java/io/FileDescriptor/FileChannelFDTest.java + test/java/io/FileDescriptor/Sharing.java - test/java/io/etc/FileDescriptorSharing.java
hg: jdk8/tl/jdk: 7099658: Properties.loadFromXML fails with ClassCastException
Changeset: 64ccf18bbad5 Author:coffeys Date: 2011-10-27 10:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64ccf18bbad5 7099658: Properties.loadFromXML fails with ClassCastException Reviewed-by: alanb, mchung ! src/share/classes/sun/util/xml/XMLUtils.java
hg: jdk8/tl/jdk: 7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use
Changeset: e0c1282a0ead Author:coffeys Date: 2011-09-13 11:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0c1282a0ead 7082769: FileInputStream/FileOutputStream/RandomAccessFile allow file descriptor be closed when still in use Reviewed-by: alanb ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java + test/java/io/etc/FileDescriptorSharing.java
hg: jdk8/tl/jdk: 7049079: NTSYSTEM CLASS IS LEAKING WINDOWS TOKENS
Changeset: 946e3b786d2d Author:coffeys Date: 2011-09-05 11:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/946e3b786d2d 7049079: NTSYSTEM CLASS IS LEAKING WINDOWS TOKENS Reviewed-by: weijun ! src/share/classes/com/sun/security/auth/module/NTSystem.java ! src/windows/native/com/sun/security/auth/module/nt.c
hg: jdk8/tl/jdk: 7024697: SessionRef.dispose() should determine if the token referred to by the token object is still valid
Changeset: 3a13b7ab57f7 Author:coffeys Date: 2011-08-26 10:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a13b7ab57f7 7024697: SessionRef.dispose() should determine if the token referred to by the token object is still valid Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs11/Session.java ! src/share/classes/sun/security/pkcs11/Token.java
hg: jdk8/tl/jdk: 7047325: Internal API to improve management of direct buffers
Changeset: ddcb874581eb Author:coffeys Date: 2011-08-11 12:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddcb874581eb 7047325: Internal API to improve management of direct buffers Reviewed-by: alanb, mduigou ! make/com/oracle/Makefile - make/com/oracle/net/Makefile ! make/common/Release.gmk ! src/share/classes/java/nio/Bits.java ! src/share/classes/java/nio/Buffer.java ! src/share/classes/java/nio/Direct-X-Buffer.java.template ! src/share/classes/sun/misc/JavaNioAccess.java ! src/share/classes/sun/nio/ch/DirectBuffer.java
hg: jdk8/tl/jdk: 7041125: LDAP API does not catch malformed filters that contain two operands for the ! operator
Changeset: e88093d75e36 Author:coffeys Date: 2011-07-05 15:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e88093d75e36 7041125: LDAP API does not catch malformed filters that contain two operands for the ! operator Reviewed-by: weijun, xuelei ! src/share/classes/com/sun/jndi/ldap/Filter.java ! test/com/sun/jndi/ldap/InvalidLdapFilters.java
hg: jdk8/tl/jdk: 7049774: UID construction appears to hang if time changed backwards
Changeset: 08fdfdb19ad6 Author:coffeys Date: 2011-06-14 18:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08fdfdb19ad6 7049774: UID construction appears to hang if time changed backwards Reviewed-by: alanb, dholmes, chegar, mduigou ! src/share/classes/java/rmi/server/UID.java
hg: jdk7/tl/jdk: 7025227: SSLSocketImpl does not close the TCP layer socket if a close notify cannot be sent to the peer; ...
Changeset: 48f659a09ed4 Author:coffeys Date: 2011-04-22 11:03 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48f659a09ed4 7025227: SSLSocketImpl does not close the TCP layer socket if a close notify cannot be sent to the peer 6932403: SSLSocketImpl state issue Reviewed-by: xuelei ! src/share/classes/sun/security/ssl/SSLSocketImpl.java
hg: jdk7/tl/jdk: 7025105: TEST_BUG test/com/sun/jndi/ldap/NoWaitForReplyTest.java should be cleaned up
Changeset: 339342f311cc Author:coffeys Date: 2011-03-07 14:43 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/339342f311cc 7025105: TEST_BUG test/com/sun/jndi/ldap/NoWaitForReplyTest.java should be cleaned up Reviewed-by: alanb ! test/com/sun/jndi/ldap/NoWaitForReplyTest.java
hg: jdk7/tl/jdk: 2 new changesets
Changeset: 732faed56eb0 Author:coffeys Date: 2011-03-03 16:51 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/732faed56eb0 6750362: Very large LDAP requests throw a OOM on LDAP servers which aren't aware of Paged Results Controls 6748156: add an new JNDI property to control the boolean flag WaitForReply Reviewed-by: vinnie, robm ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi/ldap/LdapClient.java ! src/share/classes/com/sun/jndi/ldap/LdapCtx.java ! src/share/classes/com/sun/jndi/ldap/LdapRequest.java + test/com/sun/jndi/ldap/NoWaitForReplyTest.java Changeset: 0bd32f96187d Author:coffeys Date: 2011-03-03 17:00 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bd32f96187d Merge
hg: jdk7/tl/jdk: 7016897: Copyright header correction : test/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java
Changeset: dff9b6d18628 Author:coffeys Date: 2011-02-03 11:28 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dff9b6d18628 7016897: Copyright header correction : test/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java Reviewed-by: vinnie ! test/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java
hg: jdk7/tl/jdk: 6998583: NativeSeedGenerator is making 8192 byte read requests from entropy pool on each init.
Changeset: 43ae1a1cc7a4 Author:coffeys Date: 2010-12-10 15:11 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/43ae1a1cc7a4 6998583: NativeSeedGenerator is making 8192 byte read requests from entropy pool on each init. Reviewed-by: wetmore, andrew, vinnie ! src/share/classes/sun/security/provider/SeedGenerator.java ! src/windows/classes/sun/security/provider/NativeSeedGenerator.java + test/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java
hg: jdk7/tl/jdk: 6957378: JMX memory leak
Changeset: 5de001f5f8b4 Author:coffeys Date: 2010-11-05 17:15 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5de001f5f8b4 6957378: JMX memory leak Reviewed-by: emcmanus, kevinw ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java + test/javax/management/remote/mandatory/notif/DeadListenerTest.java
hg: jdk7/tl/jdk: 6696028: JMXServiceURL like service:jmx:rmi:///jndi/iiop:// should be rejected by the RMI conn provider.; ...
Changeset: aed81a97aae3 Author:coffeys Date: 2010-11-05 13:52 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aed81a97aae3 6696028: JMXServiceURL like service:jmx:rmi:///jndi/iiop:// should be rejected by the RMI conn provider. 6984520: NPE IN RMIConnector.connect Reviewed-by: emcmanus, kevinw ! src/share/classes/javax/management/remote/rmi/RMIConnector.java + test/javax/management/remote/mandatory/connection/RMIConnector_NPETest.java
hg: jdk7/tl/jdk: 6974104: TEST: sun/nio/ch/6645197.java should be fixed in 1.5.0u25b05 and jdk6 workspace
Changeset: 426e5f2dbea3 Author:coffeys Date: 2010-10-18 18:04 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/426e5f2dbea3 6974104: TEST: sun/nio/ch/6645197.java should be fixed in 1.5.0u25b05 and jdk6 workspace Reviewed-by: alanb + test/java/nio/channels/Selector/TemporarySelector.java
