RE: [11u] RFR 8229773: Resolve permissions for code source URLs lazily
Thanks for the review, Claes. > -Original Message- > From: Claes Redestad > Sent: Mittwoch, 18. September 2019 19:16 > To: Langer, Christoph ; jdk-updates- > d...@openjdk.java.net > Cc: core-libs-dev > Subject: Re: [11u] RFR 8229773: Resolve permissions for code source URLs > lazily > > Looks ok to me! > > /Claes > > On 2019-09-18 12:01, Langer, Christoph wrote: > > Hi, > > > > please review the backport for JDK-8229773: Resolve permissions for code > source URLs lazily to OpenJDK11 updates. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8229773 > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8229773.11u- > dev.0/ > > Original Change: https://hg.openjdk.java.net/jdk/jdk/rev/1b6806340400 > > > > The patch did not apply cleanly and I had to resolve > > src/java.base/share/classes/java/lang/System.java: imports and the hunk > about "// ensure the default file system is initialized" > > src/java.base/share/classes/jdk/internal/loader/BuiltinClassLoader.java: > import statements > > > > With these modifications, the patch applies and regression testing does not > show findings. > > > > Thanks > > Christoph > >
Re: [11u] RFR 8229773: Resolve permissions for code source URLs lazily
Looks ok to me! /Claes On 2019-09-18 12:01, Langer, Christoph wrote: Hi, please review the backport for JDK-8229773: Resolve permissions for code source URLs lazily to OpenJDK11 updates. Bug: https://bugs.openjdk.java.net/browse/JDK-8229773 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8229773.11u-dev.0/ Original Change: https://hg.openjdk.java.net/jdk/jdk/rev/1b6806340400 The patch did not apply cleanly and I had to resolve src/java.base/share/classes/java/lang/System.java: imports and the hunk about "// ensure the default file system is initialized" src/java.base/share/classes/jdk/internal/loader/BuiltinClassLoader.java: import statements With these modifications, the patch applies and regression testing does not show findings. Thanks Christoph
[11u] RFR 8229773: Resolve permissions for code source URLs lazily
Hi, please review the backport for JDK-8229773: Resolve permissions for code source URLs lazily to OpenJDK11 updates. Bug: https://bugs.openjdk.java.net/browse/JDK-8229773 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8229773.11u-dev.0/ Original Change: https://hg.openjdk.java.net/jdk/jdk/rev/1b6806340400 The patch did not apply cleanly and I had to resolve src/java.base/share/classes/java/lang/System.java: imports and the hunk about "// ensure the default file system is initialized" src/java.base/share/classes/jdk/internal/loader/BuiltinClassLoader.java: import statements With these modifications, the patch applies and regression testing does not show findings. Thanks Christoph
