Re: [12]RFR 8210408: Refactor java.util.ResourceBundle:i18n shell tests to plain java tests

2018-11-15 Thread naoto . sato

Looks good to me.

Naoto

On 11/14/18 6:39 PM, Dora Zhou wrote:

Hello,

Please help review the fix for refactor java.util.ResourceBundle:i18n 
shell tests to plain java tests. Thank you.


Shell Tests:
test/java/util/ResourceBundle/modules/appbasic2/appbasic2.sh
test/java/util/ResourceBundle/modules/xmlformat/xmlformat.sh
test/java/util/ResourceBundle/modules/unnamed/unnamed.sh
test/java/util/ResourceBundle/modules/appbasic/appbasic.sh
test/java/util/ResourceBundle/modules/visibility/visibility.sh
test/java/util/ResourceBundle/modules/modlocal/modlocal.sh
test/java/util/ResourceBundle/modules/simple/simple.sh
test/java/util/ResourceBundle/modules/basic/basic.sh
test/java/util/ResourceBundle/modules/layer/run.sh
test/java/util/ResourceBundle/Bug6299235Test.sh

I merged appbasic, appbasic2, basic, simple, xml, modlocal together with 
one BasicTest.main().


Bug: https://bugs.openjdk.java.net/browse/JDK-8210408

webrev: http://cr.openjdk.java.net/~dzhou/8210408/webrev.02/

Regards,
Dora


[12]RFR 8210408: Refactor java.util.ResourceBundle:i18n shell tests to plain java tests

2018-11-14 Thread Dora Zhou

Hello,

Please help review the fix for refactor java.util.ResourceBundle:i18n 
shell tests to plain java tests. Thank you.


Shell Tests:
test/java/util/ResourceBundle/modules/appbasic2/appbasic2.sh
test/java/util/ResourceBundle/modules/xmlformat/xmlformat.sh
test/java/util/ResourceBundle/modules/unnamed/unnamed.sh
test/java/util/ResourceBundle/modules/appbasic/appbasic.sh
test/java/util/ResourceBundle/modules/visibility/visibility.sh
test/java/util/ResourceBundle/modules/modlocal/modlocal.sh
test/java/util/ResourceBundle/modules/simple/simple.sh
test/java/util/ResourceBundle/modules/basic/basic.sh
test/java/util/ResourceBundle/modules/layer/run.sh
test/java/util/ResourceBundle/Bug6299235Test.sh

I merged appbasic, appbasic2, basic, simple, xml, modlocal together with 
one BasicTest.main().


Bug: https://bugs.openjdk.java.net/browse/JDK-8210408

webrev: http://cr.openjdk.java.net/~dzhou/8210408/webrev.02/

Regards,
Dora