Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
Hello Matthias, It is great, you are able to push this fix! Thanks, Serguei On 5/22/17 01:49, Baesken, Matthias wrote: Hello Serguei, the com/sun/jdi tests were executed , same number of passed and errors in a patched and unpatched JDK . We do not need a sponsor because the change is in JDK not HS . Best regards, Matthias -Original Message- From: serguei.spit...@oracle.com [mailto:serguei.spit...@oracle.com] Sent: Freitag, 19. Mai 2017 02:18 To: Baesken, Matthias ; Alan Bateman ; core-libs-dev@openjdk.java.net; serviceability-...@openjdk.java.net Cc: Simonis, Volker Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent Hi Matthias, The fix looks good to me. It must be tested at least with the JTreg com/sun/jdi tests. Do you need a sponsor? Thanks, Serguei On 5/16/17 03:21, Baesken, Matthias wrote: Sure, I forward it to serviceability-dev . -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Dienstag, 16. Mai 2017 11:51 To: Baesken, Matthias ; core-libs-dev@openjdk.java.net Cc: Simonis, Volker Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent On 16/05/2017 10:04, Baesken, Matthias wrote: Hello, could you please review this small change : http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ it fixes a number of places in jdk.jdwp.agent where in case of an error it is attempted to write to NULL . Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent https://bugs.openjdk.java.net/browse/JDK-8180413 Can you bring this to serviceability-dev as that is the mailing list where the JDWP agent is maintained? -Alan
RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
Hello Serguei, the com/sun/jdi tests were executed , same number of passed and errors in a patched and unpatched JDK . We do not need a sponsor because the change is in JDK not HS . Best regards, Matthias -Original Message- From: serguei.spit...@oracle.com [mailto:serguei.spit...@oracle.com] Sent: Freitag, 19. Mai 2017 02:18 To: Baesken, Matthias ; Alan Bateman ; core-libs-dev@openjdk.java.net; serviceability-...@openjdk.java.net Cc: Simonis, Volker Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent Hi Matthias, The fix looks good to me. It must be tested at least with the JTreg com/sun/jdi tests. Do you need a sponsor? Thanks, Serguei On 5/16/17 03:21, Baesken, Matthias wrote: > Sure, I forward it to serviceability-dev . > > -Original Message- > From: Alan Bateman [mailto:alan.bate...@oracle.com] > Sent: Dienstag, 16. Mai 2017 11:51 > To: Baesken, Matthias ; > core-libs-dev@openjdk.java.net > Cc: Simonis, Volker > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > > > > On 16/05/2017 10:04, Baesken, Matthias wrote: >> Hello, could you please review this small change : >> >> http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ >> >> it fixes a number of places in jdk.jdwp.agent where in case of an error >> it is attempted to write to NULL . >> >> Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent >> >> >> https://bugs.openjdk.java.net/browse/JDK-8180413 >> >> > Can you bring this to serviceability-dev as that is the mailing list > where the JDWP agent is maintained? > > -Alan
Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
Hi Matthias, The fix looks good to me. It must be tested at least with the JTreg com/sun/jdi tests. Do you need a sponsor? Thanks, Serguei On 5/16/17 03:21, Baesken, Matthias wrote: Sure, I forward it to serviceability-dev . -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Dienstag, 16. Mai 2017 11:51 To: Baesken, Matthias ; core-libs-dev@openjdk.java.net Cc: Simonis, Volker Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent On 16/05/2017 10:04, Baesken, Matthias wrote: Hello, could you please review this small change : http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ it fixes a number of places in jdk.jdwp.agent where in case of an error it is attempted to write to NULL . Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent https://bugs.openjdk.java.net/browse/JDK-8180413 Can you bring this to serviceability-dev as that is the mailing list where the JDWP agent is maintained? -Alan
RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
Great, thanks ! -Original Message- From: Langer, Christoph Sent: Donnerstag, 18. Mai 2017 15:27 To: Baesken, Matthias Cc: Simonis, Volker ; Dmitry Samersoff ; core-libs-dev@openjdk.java.net; serviceability-dev-requ...@openjdk.java.net Subject: RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent Hi Matthias, I have added a jdk9-fix-request label to the bug and added a comment. Let's see if it gets approved for JDK9. Best regards Christoph > -Original Message- > From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On > Behalf Of Dmitry Samersoff > Sent: Dienstag, 16. Mai 2017 13:18 > To: Baesken, Matthias ; Alan Bateman > ; core-libs-dev@openjdk.java.net > Cc: Simonis, Volker > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > > Matthias, > > Looks good to me. > > -Dmitry > > On 2017-05-16 13:21, Baesken, Matthias wrote: > > Sure, I forward it to serviceability-dev . > > > > -Original Message- > > From: Alan Bateman [mailto:alan.bate...@oracle.com] > > Sent: Dienstag, 16. Mai 2017 11:51 > > To: Baesken, Matthias ; core-libs- > d...@openjdk.java.net > > Cc: Simonis, Volker > > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > > > > > > > > On 16/05/2017 10:04, Baesken, Matthias wrote: > >> Hello, could you please review this small change : > >> > >> http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ > >> > >> it fixes a number of places in jdk.jdwp.agent where in case of an > >> error it > is attempted to write to NULL . > >> > >> Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > >> > >> > >> https://bugs.openjdk.java.net/browse/JDK-8180413 > >> > >> > > Can you bring this to serviceability-dev as that is the mailing list > > where the JDWP agent is maintained? > > > > -Alan > > > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources.
RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
Hi Matthias, I have added a jdk9-fix-request label to the bug and added a comment. Let's see if it gets approved for JDK9. Best regards Christoph > -Original Message- > From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On > Behalf Of Dmitry Samersoff > Sent: Dienstag, 16. Mai 2017 13:18 > To: Baesken, Matthias ; Alan Bateman > ; core-libs-dev@openjdk.java.net > Cc: Simonis, Volker > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > > Matthias, > > Looks good to me. > > -Dmitry > > On 2017-05-16 13:21, Baesken, Matthias wrote: > > Sure, I forward it to serviceability-dev . > > > > -Original Message- > > From: Alan Bateman [mailto:alan.bate...@oracle.com] > > Sent: Dienstag, 16. Mai 2017 11:51 > > To: Baesken, Matthias ; core-libs- > d...@openjdk.java.net > > Cc: Simonis, Volker > > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > > > > > > > > On 16/05/2017 10:04, Baesken, Matthias wrote: > >> Hello, could you please review this small change : > >> > >> http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ > >> > >> it fixes a number of places in jdk.jdwp.agent where in case of an > >> error it > is attempted to write to NULL . > >> > >> Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > >> > >> > >> https://bugs.openjdk.java.net/browse/JDK-8180413 > >> > >> > > Can you bring this to serviceability-dev as that is the mailing list > > where the JDWP agent is maintained? > > > > -Alan > > > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources.
Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
Matthias, Looks good to me. -Dmitry On 2017-05-16 13:21, Baesken, Matthias wrote: > Sure, I forward it to serviceability-dev . > > -Original Message- > From: Alan Bateman [mailto:alan.bate...@oracle.com] > Sent: Dienstag, 16. Mai 2017 11:51 > To: Baesken, Matthias ; > core-libs-dev@openjdk.java.net > Cc: Simonis, Volker > Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > > > > On 16/05/2017 10:04, Baesken, Matthias wrote: >> Hello, could you please review this small change : >> >> http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ >> >> it fixes a number of places in jdk.jdwp.agent where in case of an error >> it is attempted to write to NULL . >> >> Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent >> >> >> https://bugs.openjdk.java.net/browse/JDK-8180413 >> >> > Can you bring this to serviceability-dev as that is the mailing list > where the JDWP agent is maintained? > > -Alan > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
Sure, I forward it to serviceability-dev . -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Dienstag, 16. Mai 2017 11:51 To: Baesken, Matthias ; core-libs-dev@openjdk.java.net Cc: Simonis, Volker Subject: Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent On 16/05/2017 10:04, Baesken, Matthias wrote: > Hello, could you please review this small change : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ > > it fixes a number of places in jdk.jdwp.agent where in case of an error > it is attempted to write to NULL . > > Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent > > > https://bugs.openjdk.java.net/browse/JDK-8180413 > > Can you bring this to serviceability-dev as that is the mailing list where the JDWP agent is maintained? -Alan
Re: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
On 16/05/2017 10:04, Baesken, Matthias wrote: Hello, could you please review this small change : http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ it fixes a number of places in jdk.jdwp.agent where in case of an error it is attempted to write to NULL . Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent https://bugs.openjdk.java.net/browse/JDK-8180413 Can you bring this to serviceability-dev as that is the mailing list where the JDWP agent is maintained? -Alan
RE: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
Hi Matthias, this definitely makes sense. If 'data' is NULL, one should not access its fields, except a hard crash is desired... Reviewed. Don't forget to update the copyright year. Best regards Christoph From: Baesken, Matthias Sent: Dienstag, 16. Mai 2017 11:05 To: core-libs-dev@openjdk.java.net Cc: Simonis, Volker ; Langer, Christoph Subject: [XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent Hello, could you please review this small change : http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ it fixes a number of places in jdk.jdwp.agent where in case of an error it is attempted to write to NULL . Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent https://bugs.openjdk.java.net/browse/JDK-8180413 Best regards, Matthias
[XS] JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
Hello, could you please review this small change : http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/ it fixes a number of places in jdk.jdwp.agent where in case of an error it is attempted to write to NULL . Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent https://bugs.openjdk.java.net/browse/JDK-8180413 Best regards, Matthias
