Re: [jdk17] RFR: 8268080: java/util/concurrent/forkjoin/AsyncShutdownNow.java fails with java.util.concurrent.RejectedExecutionException [v2]
On Wed, 16 Jun 2021 10:28:11 GMT, Pavel Rappo wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix copyright year > > test/jdk/java/util/concurrent/forkjoin/AsyncShutdownNowInvokeAny.java line 2: > >> 1: /* >> 2: * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. > > Why did you replace the year rather than append it? Oops, thanks for spotting! - PR: https://git.openjdk.java.net/jdk17/pull/74
Re: [jdk17] RFR: 8268080: java/util/concurrent/forkjoin/AsyncShutdownNow.java fails with java.util.concurrent.RejectedExecutionException [v2]
On Wed, 16 Jun 2021 10:45:20 GMT, Julia Boes wrote: >> In the methods in question, `RejectedExecutionException` is an expected >> exception that was previously unhandled (it is a `RuntimeException`, not a >> subclass of `ExecutionException`). This change adds >> `RejectedExecutionException` to the existing catch clause. > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > fix copyright year Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/74
Re: [jdk17] RFR: 8268080: java/util/concurrent/forkjoin/AsyncShutdownNow.java fails with java.util.concurrent.RejectedExecutionException [v2]
> In the methods in question, `RejectedExecutionException` is an expected > exception that was previously unhandled (it is a `RuntimeException`, not a > subclass of `ExecutionException`). This change adds > `RejectedExecutionException` to the existing catch clause. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: fix copyright year - Changes: - all: https://git.openjdk.java.net/jdk17/pull/74/files - new: https://git.openjdk.java.net/jdk17/pull/74/files/9e2f2da1..7a1d82b2 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=74=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=74=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk17/pull/74.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/74/head:pull/74 PR: https://git.openjdk.java.net/jdk17/pull/74
Re: [jdk17] RFR: 8268080: java/util/concurrent/forkjoin/AsyncShutdownNow.java fails with java.util.concurrent.RejectedExecutionException
On Wed, 16 Jun 2021 09:57:29 GMT, Julia Boes wrote: > In the methods in question, `RejectedExecutionException` is an expected > exception that was previously unhandled (it is a `RuntimeException`, not a > subclass of `ExecutionException`). This change adds > `RejectedExecutionException` to the existing catch clause. Marked as reviewed by dfuchs (Reviewer). test/jdk/java/util/concurrent/forkjoin/AsyncShutdownNow.java line 2: > 1: /* > 2: * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. Same remark that Pavel made below. Otherwise look good. Please fix the copyright years to `2020, 2021,` before integrating. - PR: https://git.openjdk.java.net/jdk17/pull/74
Re: [jdk17] RFR: 8268080: java/util/concurrent/forkjoin/AsyncShutdownNow.java fails with java.util.concurrent.RejectedExecutionException
On Wed, 16 Jun 2021 09:57:29 GMT, Julia Boes wrote: > In the methods in question, `RejectedExecutionException` is an expected > exception that was previously unhandled (it is a `RuntimeException`, not a > subclass of `ExecutionException`). This change adds > `RejectedExecutionException` to the existing catch clause. test/jdk/java/util/concurrent/forkjoin/AsyncShutdownNowInvokeAny.java line 2: > 1: /* > 2: * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. Why did you replace the year rather than append it? - PR: https://git.openjdk.java.net/jdk17/pull/74
Re: [jdk17] RFR: 8268080: java/util/concurrent/forkjoin/AsyncShutdownNow.java fails with java.util.concurrent.RejectedExecutionException
On Wed, 16 Jun 2021 09:57:29 GMT, Julia Boes wrote: > In the methods in question, `RejectedExecutionException` is an expected > exception that was previously unhandled (it is a `RuntimeException`, not a > subclass of `ExecutionException`). This change adds > `RejectedExecutionException` to the existing catch clause. Marked as reviewed by chegar (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/74
[jdk17] RFR: 8268080: java/util/concurrent/forkjoin/AsyncShutdownNow.java fails with java.util.concurrent.RejectedExecutionException
In the methods in question, `RejectedExecutionException` is an expected exception that was previously unhandled (it is a `RuntimeException`, not a subclass of `ExecutionException`). This change adds `RejectedExecutionException` to the existing catch clause. - Commit messages: - initial change Changes: https://git.openjdk.java.net/jdk17/pull/74/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=74=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268080 Stats: 8 lines in 2 files changed: 2 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk17/pull/74.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/74/head:pull/74 PR: https://git.openjdk.java.net/jdk17/pull/74
