Re: [jdk17] RFR: 8268353: Test libsvml.so is and is not present in jdk image [v2]

2021-06-16 Thread Jie Fu 
On Wed, 16 Jun 2021 15:29:19 GMT, Paul Sandoz  wrote:

>> Test that when the jdk.incubator.vector module is present that libsvml.so is 
>> present, and test the opposite case.
>
> Paul Sandoz has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Require C2.

LGTM
Thanks for your update.

-

Marked as reviewed by jiefu (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/47

Re: [jdk17] RFR: 8268353: Test libsvml.so is and is not present in jdk image [v2]

2021-06-16 Thread Paul Sandoz 
On Wed, 16 Jun 2021 01:20:39 GMT, Jie Fu  wrote:

>> Paul Sandoz has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Require C2.
>
> The test logic should be changed.
> 
> If C2 is absent, libsvml.so would not be generated after JDK-8268643.
> Thanks.

@DamonFool thanks. I updated the test to require C2. This is not exactly what i 
want but i think is sufficient for now.

-

PR: https://git.openjdk.java.net/jdk17/pull/47

Re: [jdk17] RFR: 8268353: Test libsvml.so is and is not present in jdk image [v2]

2021-06-16 Thread Paul Sandoz 
> Test that when the jdk.incubator.vector module is present that libsvml.so is 
> present, and test the opposite case.

Paul Sandoz has updated the pull request incrementally with one additional 
commit since the last revision:

  Require C2.

-

Changes:
  - all: https://git.openjdk.java.net/jdk17/pull/47/files
  - new: https://git.openjdk.java.net/jdk17/pull/47/files/a0c66bd6..ed59678e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk17&pr=47&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk17&pr=47&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk17/pull/47.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/47/head:pull/47

PR: https://git.openjdk.java.net/jdk17/pull/47

Re: [jdk17] RFR: 8268353: Test libsvml.so is and is not present in jdk image

2021-06-15 Thread Jie Fu 
On Mon, 14 Jun 2021 16:06:04 GMT, Paul Sandoz  wrote:

> Test that when the jdk.incubator.vector module is present that libsvml.so is 
> present, and test the opposite case.

The test logic should be changed.

If C2 is absent, libsvml.so would not be generated after JDK-8268643.
Thanks.

-

Changes requested by jiefu (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/47

Re: [jdk17] RFR: 8268353: Test libsvml.so is and is not present in jdk image

2021-06-15 Thread Sandhya Viswanathan 
On Mon, 14 Jun 2021 16:06:04 GMT, Paul Sandoz  wrote:

> Test that when the jdk.incubator.vector module is present that libsvml.so is 
> present, and test the opposite case.

Looks good to me.

-

Marked as reviewed by sviswanathan (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/47

[jdk17] RFR: 8268353: Test libsvml.so is and is not present in jdk image

2021-06-14 Thread Paul Sandoz 
Test that when the jdk.incubator.vector module is present that libsvml.so is 
present, and test the opposite case.

-

Commit messages:
 - 8268353: Test libsvml.so is and is not present in jdk image

Changes: https://git.openjdk.java.net/jdk17/pull/47/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=47&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8268353
  Stats: 99 lines in 2 files changed: 96 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk17/pull/47.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/47/head:pull/47

PR: https://git.openjdk.java.net/jdk17/pull/47