Re: [jdk17] RFR: 8268888: Upstream 8268230: Foreign Linker API & Windows user32/kernel32: String conversion seems broken [v2]
On Wed, 16 Jun 2021 22:23:45 GMT, Jorn Vernee wrote: >> Upstream fix for 8268230 to mainline JDK. >> >> Prior review thread can be found here: >> https://github.com/openjdk/panama-foreign/pull/554 >> >> Testing: jdk_foreign test suite on Windows and Linux (WSL). > > Jorn Vernee has updated the pull request incrementally with one additional > commit since the last revision: > > Exclude test on unsupported platforms > > This test indirectly initializes CABI, which fails on Linux x86 Looks good - Marked as reviewed by mcimadamore (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/77
Re: [jdk17] RFR: 8268888: Upstream 8268230: Foreign Linker API & Windows user32/kernel32: String conversion seems broken [v2]
> Upstream fix for 8268230 to mainline JDK. > > Prior review thread can be found here: > https://github.com/openjdk/panama-foreign/pull/554 > > Testing: jdk_foreign test suite on Windows and Linux (WSL). Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: Exclude test on unsupported platforms This test indirectly initializes CABI, which fails on Linux x86 - Changes: - all: https://git.openjdk.java.net/jdk17/pull/77/files - new: https://git.openjdk.java.net/jdk17/pull/77/files/08a8b081..20565c87 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=77=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=77=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/77/head:pull/77 PR: https://git.openjdk.java.net/jdk17/pull/77
