[15] RFR: 8239480: Support for CLDR version 37

[naoto . sato]

Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8239480

The proposed changeset, and the release note draft are located at:

https://cr.openjdk.java.net/~naoto/8239480/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8243581

This updates the CLDR locale data to version 37. Although the changeset 
is huge, this mainly consists of the locale data and licenses changes. 
Other than those, only one test case was updated 
(IncludeLocalesPluginTest.java) due to the locale data change.


Naoto

Re: [15] RFR: 8239480: Support for CLDR version 37

[Joe Wang]

Looks good to me.

A minor comment: in the license files, Terms of Use lost its original 
format  (e.g. headings and 
numbering), lines are also super long. But I think we've seen them in 
the previous update, it's up to you whether you'd want to reformat them. 
Either way, no need to regenerate the huge webrev :-)


Best,
Joe

On 5/20/2020 2:31 PM, naoto.s...@oracle.com wrote:

Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8239480

The proposed changeset, and the release note draft are located at:

https://cr.openjdk.java.net/~naoto/8239480/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8243581

This updates the CLDR locale data to version 37. Although the 
changeset is huge, this mainly consists of the locale data and 
licenses changes. Other than those, only one test case was updated 
(IncludeLocalesPluginTest.java) due to the locale data change.


Naoto

Re: [15] RFR: 8239480: Support for CLDR version 37

[naoto . sato]

Hi Joe, thanks again!

The license file "unicode-license.txt" is actually included in the 
version 37 artifact:


https://github.com/unicode-org/cldr/blob/release-37/unicode-license.txt

The changeset uses the file as is, so I believe it is OK.

Naoto

On 5/20/20 6:51 PM, Joe Wang wrote:

Looks good to me.

A minor comment: in the license files, Terms of Use lost its original 
format  (e.g. headings and 
numbering), lines are also super long. But I think we've seen them in 
the previous update, it's up to you whether you'd want to reformat them. 
Either way, no need to regenerate the huge webrev :-)


Best,
Joe

On 5/20/2020 2:31 PM, naoto.s...@oracle.com wrote:

Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8239480

The proposed changeset, and the release note draft are located at:

https://cr.openjdk.java.net/~naoto/8239480/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8243581

This updates the CLDR locale data to version 37. Although the 
changeset is huge, this mainly consists of the locale data and 
licenses changes. Other than those, only one test case was updated 
(IncludeLocalesPluginTest.java) due to the locale data change.


Naoto

Re: [15] RFR: 8239480: Support for CLDR version 37

[Joe Wang]

On 5/20/2020 7:06 PM, naoto.s...@oracle.com wrote:

Hi Joe, thanks again!


No problem.


The license file "unicode-license.txt" is actually included in the 
version 37 artifact:


https://github.com/unicode-org/cldr/blob/release-37/unicode-license.txt

The changeset uses the file as is, so I believe it is OK.


I meant the md files that include the license text with the additional 
"Terms of Use", starting from line 55. That looks like a copy of this: 
https://www.unicode.org/copyright.html, but headings and numbering were 
lost. Plus, without html format, some of the lines stretched very long 
. 
But again, the format of the md files might not be that important. Your 
call.


-Joe



Naoto

On 5/20/20 6:51 PM, Joe Wang wrote:

Looks good to me.

A minor comment: in the license files, Terms of Use lost its original 
format  (e.g. headings and 
numbering), lines are also super long. But I think we've seen them in 
the previous update, it's up to you whether you'd want to reformat 
them. Either way, no need to regenerate the huge webrev :-)


Best,
Joe

On 5/20/2020 2:31 PM, naoto.s...@oracle.com wrote:

Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8239480

The proposed changeset, and the release note draft are located at:

https://cr.openjdk.java.net/~naoto/8239480/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8243581

This updates the CLDR locale data to version 37. Although the 
changeset is huge, this mainly consists of the locale data and 
licenses changes. Other than those, only one test case was updated 
(IncludeLocalesPluginTest.java) due to the locale data change.


Naoto

Re: [15] RFR: 8239480: Support for CLDR version 37

[Roger Riggs]

Looks fine.

On 5/20/20 5:31 PM, naoto.s...@oracle.com wrote:

Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8239480

The proposed changeset, and the release note draft are located at:

https://cr.openjdk.java.net/~naoto/8239480/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8243581

This updates the CLDR locale data to version 37. Although the 
changeset is huge, this mainly consists of the locale data and 
licenses changes. Other than those, only one test case was updated 
(IncludeLocalesPluginTest.java) due to the locale data change.


Naoto