8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods

2012-10-11 Thread Alan Bateman


This is a follow-on from yesterday's mail on deprecating the 
LogManager's add/removePropertyChangeListener methods. The other 4 
problematic methods identified in JEP 162 [1] are the same name methods 
on Pack200.Packer and Pack200.Unpacker. The webrev to deprecate these 
methods is here:


http://cr.openjdk.java.net/~alanb/8000362/webrev/

As with the LogManager methods, Mandy Chung searched 2 projects. In 
this case we didn't find any usages of these methods and this gives us 
confidence that these methods are rarely used. We don't propose to 
provide a replacement for these methods but instead just include wording 
to suggest that applications poll the value of the progress property if 
they really need to provide some progress indication.


Kumar is the pack200 guru here and I know he's busy/away at the moment 
so I plan to hold onto this patch until I at least hear from him.


-Alan.

[1] http://openjdk.java.net/jeps/162


Re: 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods

2012-10-11 Thread Chris Hegarty

The changes look ok to me.

-Chris.

On 11/10/12 14:40, Alan Bateman wrote:


This is a follow-on from yesterday's mail on deprecating the
LogManager's add/removePropertyChangeListener methods. The other 4
problematic methods identified in JEP 162 [1] are the same name methods
on Pack200.Packer and Pack200.Unpacker. The webrev to deprecate these
methods is here:

http://cr.openjdk.java.net/~alanb/8000362/webrev/

As with the LogManager methods, Mandy Chung searched 2 projects. In
this case we didn't find any usages of these methods and this gives us
confidence that these methods are rarely used. We don't propose to
provide a replacement for these methods but instead just include wording
to suggest that applications poll the value of the progress property if
they really need to provide some progress indication.

Kumar is the pack200 guru here and I know he's busy/away at the moment
so I plan to hold onto this patch until I at least hear from him.

-Alan.

[1] http://openjdk.java.net/jeps/162


Re: 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods

2012-10-11 Thread Lance Andersen - Oracle
looks fine alan
On Oct 11, 2012, at 9:40 AM, Alan Bateman wrote:

 
 This is a follow-on from yesterday's mail on deprecating the LogManager's 
 add/removePropertyChangeListener methods. The other 4 problematic methods 
 identified in JEP 162 [1] are the same name methods on Pack200.Packer and 
 Pack200.Unpacker. The webrev to deprecate these methods is here:
 
 http://cr.openjdk.java.net/~alanb/8000362/webrev/
 
 As with the LogManager methods, Mandy Chung searched 2 projects. In this 
 case we didn't find any usages of these methods and this gives us confidence 
 that these methods are rarely used. We don't propose to provide a replacement 
 for these methods but instead just include wording to suggest that 
 applications poll the value of the progress property if they really need to 
 provide some progress indication.
 
 Kumar is the pack200 guru here and I know he's busy/away at the moment so I 
 plan to hold onto this patch until I at least hear from him.
 
 -Alan.
 
 [1] http://openjdk.java.net/jeps/162


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com