hg: jdk8/tl/jdk: 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods
Changeset: b265ead7f331 Author:alanb Date: 2012-10-17 21:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b265ead7f331 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods Reviewed-by: lancea, chegar, mchung, ksrini ! src/share/classes/java/util/jar/Pack200.java
Re: 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods
Looks fine with me. Mandy On 10/11/2012 6:40 AM, Alan Bateman wrote: This is a follow-on from yesterday's mail on deprecating the LogManager's add/removePropertyChangeListener methods. The other 4 problematic methods identified in JEP 162 [1] are the same name methods on Pack200.Packer and Pack200.Unpacker. The webrev to deprecate these methods is here: http://cr.openjdk.java.net/~alanb/8000362/webrev/ As with the LogManager methods, Mandy Chung searched >2 projects. In this case we didn't find any usages of these methods and this gives us confidence that these methods are rarely used. We don't propose to provide a replacement for these methods but instead just include wording to suggest that applications poll the value of the progress property if they really need to provide some progress indication. Kumar is the pack200 guru here and I know he's busy/away at the moment so I plan to hold onto this patch until I at least hear from him. -Alan. [1] http://openjdk.java.net/jeps/162
Re: 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods
looks fine alan On Oct 11, 2012, at 9:40 AM, Alan Bateman wrote: > > This is a follow-on from yesterday's mail on deprecating the LogManager's > add/removePropertyChangeListener methods. The other 4 problematic methods > identified in JEP 162 [1] are the same name methods on Pack200.Packer and > Pack200.Unpacker. The webrev to deprecate these methods is here: > > http://cr.openjdk.java.net/~alanb/8000362/webrev/ > > As with the LogManager methods, Mandy Chung searched >2 projects. In this > case we didn't find any usages of these methods and this gives us confidence > that these methods are rarely used. We don't propose to provide a replacement > for these methods but instead just include wording to suggest that > applications poll the value of the progress property if they really need to > provide some progress indication. > > Kumar is the pack200 guru here and I know he's busy/away at the moment so I > plan to hold onto this patch until I at least hear from him. > > -Alan. > > [1] http://openjdk.java.net/jeps/162 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
Re: 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods
The changes look ok to me. -Chris. On 11/10/12 14:40, Alan Bateman wrote: This is a follow-on from yesterday's mail on deprecating the LogManager's add/removePropertyChangeListener methods. The other 4 problematic methods identified in JEP 162 [1] are the same name methods on Pack200.Packer and Pack200.Unpacker. The webrev to deprecate these methods is here: http://cr.openjdk.java.net/~alanb/8000362/webrev/ As with the LogManager methods, Mandy Chung searched >2 projects. In this case we didn't find any usages of these methods and this gives us confidence that these methods are rarely used. We don't propose to provide a replacement for these methods but instead just include wording to suggest that applications poll the value of the progress property if they really need to provide some progress indication. Kumar is the pack200 guru here and I know he's busy/away at the moment so I plan to hold onto this patch until I at least hear from him. -Alan. [1] http://openjdk.java.net/jeps/162
8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods
This is a follow-on from yesterday's mail on deprecating the LogManager's add/removePropertyChangeListener methods. The other 4 problematic methods identified in JEP 162 [1] are the same name methods on Pack200.Packer and Pack200.Unpacker. The webrev to deprecate these methods is here: http://cr.openjdk.java.net/~alanb/8000362/webrev/ As with the LogManager methods, Mandy Chung searched >2 projects. In this case we didn't find any usages of these methods and this gives us confidence that these methods are rarely used. We don't propose to provide a replacement for these methods but instead just include wording to suggest that applications poll the value of the progress property if they really need to provide some progress indication. Kumar is the pack200 guru here and I know he's busy/away at the moment so I plan to hold onto this patch until I at least hear from him. -Alan. [1] http://openjdk.java.net/jeps/162
