Re: 8016701: JAXP Build failure

2013-06-15 Thread Alan Bateman

On 15/06/2013 01:28, Rob McKenna wrote:

Hi folks,

As per the bug:

JAXP must be buildable using JDK7 as the bootdir. Unfortunately 
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 calls a 
method that only exists in 8. (Double.isFinite())


This element of the changeset needs to be reverted.

http://cr.openjdk.java.net/~robm/8016701/webrev.01/

Please reply-all when responding to this mail as Brad would like to 
stay on board.


-Rob


Thanks for jumping on this, looks good.

-Alan


Re: 8016701: JAXP Build failure

2013-06-15 Thread Chris Hegarty

Thanks Rob, looks fine.

-Chris.

On 15/06/2013 01:28, Rob McKenna wrote:

Hi folks,

As per the bug:

JAXP must be buildable using JDK7 as the bootdir. Unfortunately
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 calls a method
that only exists in 8. (Double.isFinite())

This element of the changeset needs to be reverted.

http://cr.openjdk.java.net/~robm/8016701/webrev.01/

Please reply-all when responding to this mail as Brad would like to stay
on board.

-Rob



hg: jdk8/tl/jaxp: 8016701: JAXP Build failure

2013-06-15 Thread rob . mckenna
Changeset: 2707f600a096
Author:robm
Date:  2013-06-15 09:26 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2707f600a096

8016701: JAXP Build failure
Reviewed-by: darcy, wetmore, alanb, chegar

! src/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java



8016701: JAXP Build failure

2013-06-14 Thread Rob McKenna

Hi folks,

As per the bug:

JAXP must be buildable using JDK7 as the bootdir. Unfortunately 
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 calls a method 
that only exists in 8. (Double.isFinite())


This element of the changeset needs to be reverted.

http://cr.openjdk.java.net/~robm/8016701/webrev.01/

Please reply-all when responding to this mail as Brad would like to stay 
on board.


-Rob



Re: 8016701: JAXP Build failure

2013-06-14 Thread Joe Darcy

Looks fine Rob; approved.

-Joe

On 6/14/2013 5:28 PM, Rob McKenna wrote:

Hi folks,

As per the bug:

JAXP must be buildable using JDK7 as the bootdir. Unfortunately 
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 calls a 
method that only exists in 8. (Double.isFinite())


This element of the changeset needs to be reverted.

http://cr.openjdk.java.net/~robm/8016701/webrev.01/

Please reply-all when responding to this mail as Brad would like to 
stay on board.


-Rob





Re: 8016701: JAXP Build failure

2013-06-14 Thread Brad Wetmore

Approved.

Brad


On 6/14/2013 5:31 PM, Joe Darcy wrote:

Looks fine Rob; approved.

-Joe

On 6/14/2013 5:28 PM, Rob McKenna wrote:

Hi folks,

As per the bug:

JAXP must be buildable using JDK7 as the bootdir. Unfortunately
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 calls a
method that only exists in 8. (Double.isFinite())

This element of the changeset needs to be reverted.

http://cr.openjdk.java.net/~robm/8016701/webrev.01/

Please reply-all when responding to this mail as Brad would like to
stay on board.

-Rob