Re: 8151339 Adding fragment to JAR URLs breaks ant

[Paul Sandoz]

> On 8 Mar 2016, at 00:24, Uwe Schindler  wrote:
> 
> Hi Steve,
> 
> Thanks for the quick fix!  I am not able to test this on the short term, but 
> I trust you that Lucene builds now.

I built it successfully a few times from scratch (downloading half the internet 
:-) ).


> I am a bit nervous, because it does not explain the Ivy issues, but I will 
> try to create some test cases with relative jar:-URL resolving tomorrow.

Thanks.

Note that the resource URLs produced from the class loader should no longer 
have the #runtime fragment, unless those resources are from an MR-JAR. #runtime 
is the signal to the URL protocol implementations to process as runtime 
versioned resource.



> This may help with resolving the problems in build 110.
> 
> I just want to make sure, that the following also works:
> - Get URL from classloader to a resource file
> - resolve a relative file against this URL and load it by URL
> (this is common pattern for parsing XML resources from JAR files that refer 
> relatively to other resources in same JAR file by href)
> 

If you have a small test project you can share we can give it a test run in the 
interim.

It could be that the URL resolving mechanism worked incorrectly with a 
#fragment in the way (especially that mechanism operated directly on the 
characters of the URL).

> Keep me informed when build 109 is downloadable.
> 

Will do.

Paul.

Re: 8151339 Adding fragment to JAR URLs breaks ant

[joe darcy]

IIRC, if all goes according to plan, the next build should be available 
for download on Friday.


HTH,

-Joe

On 3/7/2016 3:51 PM, Steve Drach wrote:

Hi Uwe,


Thanks for the quick fix!  I am not able to test this on the short term, but I 
trust you that Lucene builds now. I am a bit nervous, because it does not 
explain the Ivy issues, but I will try to create some test cases with relative 
jar:-URL resolving tomorrow. This may help with resolving the problems in build 
110.

If you can come up with small, easily reproducible test cases for any errors 
your find, that would help a lot.

I just want to make sure, that the following also works:
- Get URL from classloader to a resource file
- resolve a relative file against this URL and load it by URL
(this is common pattern for parsing XML resources from JAR files that refer 
relatively to other resources in same JAR file by href)

Please try everything.


Keep me informed when build 109 is downloadable.

I’ll try.

Steve


Uwe

-
Uwe Schindler
uschind...@apache.org
ASF Member, Apache Lucene PMC / Committer
Bremen, Germany
http://lucene.apache.org/


-Original Message-
From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On
Behalf Of Steve Drach
Sent: Monday, March 07, 2016 8:07 PM
To: core-libs-dev ; paul Sandoz
; Alan Bateman ;
Xueming Shen 
Subject: RFR: 8151339 Adding fragment to JAR URLs breaks ant

Hi,

Please review the following changeset.  We’d like to get this into build 109,
which means by noon today.  This is essentially a temporary fix, but it’s been
tested and Lucene has been built against it.  We will follow up with a more
comprehensive fix by build 110.

webrev: http://cr.openjdk.java.net/~sdrach/8151339/webrev/
<http://cr.openjdk.java.net/~sdrach/8151339/webrev/>
issue: https://bugs.openjdk.java.net/browse/JDK-8151339
<https://bugs.openjdk.java.net/browse/JDK-8151339>

Thanks
Steve

Re: 8151339 Adding fragment to JAR URLs breaks ant

[Steve Drach]

Hi Uwe,

> Thanks for the quick fix!  I am not able to test this on the short term, but 
> I trust you that Lucene builds now. I am a bit nervous, because it does not 
> explain the Ivy issues, but I will try to create some test cases with 
> relative jar:-URL resolving tomorrow. This may help with resolving the 
> problems in build 110.

If you can come up with small, easily reproducible test cases for any errors 
your find, that would help a lot.
> 
> I just want to make sure, that the following also works:
> - Get URL from classloader to a resource file
> - resolve a relative file against this URL and load it by URL
> (this is common pattern for parsing XML resources from JAR files that refer 
> relatively to other resources in same JAR file by href)

Please try everything.

> 
> Keep me informed when build 109 is downloadable.

I’ll try.

Steve

> 
> Uwe
> 
> -
> Uwe Schindler
> uschind...@apache.org 
> ASF Member, Apache Lucene PMC / Committer
> Bremen, Germany
> http://lucene.apache.org/
> 
>> -Original Message-
>> From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On
>> Behalf Of Steve Drach
>> Sent: Monday, March 07, 2016 8:07 PM
>> To: core-libs-dev ; paul Sandoz
>> ; Alan Bateman ;
>> Xueming Shen 
>> Subject: RFR: 8151339 Adding fragment to JAR URLs breaks ant
>> 
>> Hi,
>> 
>> Please review the following changeset.  We’d like to get this into build 109,
>> which means by noon today.  This is essentially a temporary fix, but it’s 
>> been
>> tested and Lucene has been built against it.  We will follow up with a more
>> comprehensive fix by build 110.
>> 
>> webrev: http://cr.openjdk.java.net/~sdrach/8151339/webrev/
>> <http://cr.openjdk.java.net/~sdrach/8151339/webrev/>
>> issue: https://bugs.openjdk.java.net/browse/JDK-8151339
>> <https://bugs.openjdk.java.net/browse/JDK-8151339>
>> 
>> Thanks
>> Steve
>> 
> 
> 

RE: 8151339 Adding fragment to JAR URLs breaks ant

[Uwe Schindler]

Hi Steve,

Thanks for the quick fix!  I am not able to test this on the short term, but I 
trust you that Lucene builds now. I am a bit nervous, because it does not 
explain the Ivy issues, but I will try to create some test cases with relative 
jar:-URL resolving tomorrow. This may help with resolving the problems in build 
110.

I just want to make sure, that the following also works:
- Get URL from classloader to a resource file
- resolve a relative file against this URL and load it by URL
(this is common pattern for parsing XML resources from JAR files that refer 
relatively to other resources in same JAR file by href)

Keep me informed when build 109 is downloadable.

Uwe

-
Uwe Schindler
uschind...@apache.org 
ASF Member, Apache Lucene PMC / Committer
Bremen, Germany
http://lucene.apache.org/

> -Original Message-
> From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On
> Behalf Of Steve Drach
> Sent: Monday, March 07, 2016 8:07 PM
> To: core-libs-dev ; paul Sandoz
> ; Alan Bateman ;
> Xueming Shen 
> Subject: RFR: 8151339 Adding fragment to JAR URLs breaks ant
> 
> Hi,
> 
> Please review the following changeset.  We’d like to get this into build 109,
> which means by noon today.  This is essentially a temporary fix, but it’s been
> tested and Lucene has been built against it.  We will follow up with a more
> comprehensive fix by build 110.
> 
> webrev: http://cr.openjdk.java.net/~sdrach/8151339/webrev/
> <http://cr.openjdk.java.net/~sdrach/8151339/webrev/>
> issue: https://bugs.openjdk.java.net/browse/JDK-8151339
> <https://bugs.openjdk.java.net/browse/JDK-8151339>
> 
> Thanks
> Steve
> 

Re: RFR: 8151339 Adding fragment to JAR URLs breaks ant

[Alan Bateman]

On 07/03/2016 19:07, Steve Drach wrote:

Hi,

Please review the following changeset.  We’d like to get this into 
build 109, which means by noon today.  This is essentially a temporary 
fix, but it’s been tested and Lucene has been built against it.  We 
will follow up with a more comprehensive fix by build 110.


webrev: http://cr.openjdk.java.net/~sdrach/8151339/webrev/ 


issue: https://bugs.openjdk.java.net/browse/JDK-8151339

I chatted with Paul about this and I think we were both lending towards 
backing out the MR JAR changes until there is a better solution for 
URLs. If you don't want to go down that route then your short term fix 
to get the world working again is okay.


-Alan

RFR: 8151339 Adding fragment to JAR URLs breaks ant

[Steve Drach]

Hi,

Please review the following changeset.  We’d like to get this into build 109, 
which means by noon today.  This is essentially a temporary fix, but it’s been 
tested and Lucene has been built against it.  We will follow up with a more 
comprehensive fix by build 110.

webrev: http://cr.openjdk.java.net/~sdrach/8151339/webrev/ 

issue: https://bugs.openjdk.java.net/browse/JDK-8151339 


Thanks
Steve