Re: 8228204: Fix for JDK-8067801 breaks java/io/NegativeInitSize.java

[Brian Burkhalter]

Hi Lance,

> On Jul 17, 2019, at 3:10 PM, Lance Andersen  wrote:
> 
> Looks OK,  please add noreg-self label or equivalent to the issue

Done and removed bug number from @bug tag. Pushed.

Sorry for the noise.

Thanks,

Brian

Re: 8228204: Fix for JDK-8067801 breaks java/io/NegativeInitSize.java

[Lance Andersen]

Hi Brian,

Looks OK,  please add noreg-self label or equivalent to the issue


> On Jul 17, 2019, at 5:43 PM, Brian Burkhalter  
> wrote:
> 
> https://bugs.openjdk.java.net/browse/JDK-8228204
> 
> I lamely did not catch this before the push of the patch for [1]. The diff is 
> below.
> 
> Thanks,
> 
> Brian
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8067801
> [2] diff
> 
> @@ -22,7 +22,7 @@
>  */
> 
> /* @test
> -   @bug 4015701 4127654
> +   @bug 4015701 4127654 8067801
>@summary Test if the constructor would detect
> illegal arguments.
> */
> @@ -49,8 +49,10 @@
> ("PushbackReader failed to detect negative init size");
> }
> 
> +byte[] ba = { 123 };
> +ByteArrayInputStream goodbis = new ByteArrayInputStream(ba);
> try {
> -PushbackInputStream pbis = new PushbackInputStream(null, -1);
> +PushbackInputStream pbis = new PushbackInputStream(goodbis, -1);
> } catch (IllegalArgumentException e) {
> } catch (Exception e) {
> throw new Exception
> @@ -66,8 +68,6 @@
> ("BufferedOutputStream failed to detect negative init size");
> }
> 
> -byte[] ba = { 123 };
> -ByteArrayInputStream goodbis = new ByteArrayInputStream(ba);
> try {
> BufferedInputStream bis = new BufferedInputStream(goodbis, -1);
> } catch (IllegalArgumentException e) {
> 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

8228204: Fix for JDK-8067801 breaks java/io/NegativeInitSize.java

[Brian Burkhalter]

https://bugs.openjdk.java.net/browse/JDK-8228204

I lamely did not catch this before the push of the patch for [1]. The diff is 
below.

Thanks,

Brian

[1] https://bugs.openjdk.java.net/browse/JDK-8067801
[2] diff

@@ -22,7 +22,7 @@
  */
 
 /* @test
-   @bug 4015701 4127654
+   @bug 4015701 4127654 8067801
@summary Test if the constructor would detect
 illegal arguments.
 */
@@ -49,8 +49,10 @@
 ("PushbackReader failed to detect negative init size");
 }
 
+byte[] ba = { 123 };
+ByteArrayInputStream goodbis = new ByteArrayInputStream(ba);
 try {
-PushbackInputStream pbis = new PushbackInputStream(null, -1);
+PushbackInputStream pbis = new PushbackInputStream(goodbis, -1);
 } catch (IllegalArgumentException e) {
 } catch (Exception e) {
 throw new Exception
@@ -66,8 +68,6 @@
 ("BufferedOutputStream failed to detect negative init size");
 }
 
-byte[] ba = { 123 };
-ByteArrayInputStream goodbis = new ByteArrayInputStream(ba);
 try {
 BufferedInputStream bis = new BufferedInputStream(goodbis, -1);
 } catch (IllegalArgumentException e) {