Re: JAXP RFR: 8000172 : 2 SAX features does not work properly

2012-10-09 Thread Joe Wang 

Thanks Lance!

On 10/9/2012 7:55 AM, Lance Andersen - Oracle wrote:

Look OK Joe


On Oct 9, 2012, at 12:31 AM, Joe Wang wrote:

This is an issue found while I was working with SQE to expand test 
coverage. For a non-validating parser, when load-external-dtd is 
false, entity references are skipped. However, the skippedEntity() 
event was not reported.


The problem was due to missing infoset augmentations when document 
handler's startGeneralEntity/endGeneralEntity were called.  The fix 
therefore is simply add the arguments.


webrev: http://cr.openjdk.java.net/~joehw/jdk8/8000172/webrev/ 



Please review.

Thanks,
Joe



Lance 
Andersen| Principal Member of Technical Staff | +1.781.442.2037

Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com

Re: JAXP RFR: 8000172 : 2 SAX features does not work properly

2012-10-09 Thread Lance Andersen - Oracle 
Look OK Joe


On Oct 9, 2012, at 12:31 AM, Joe Wang wrote:

> This is an issue found while I was working with SQE to expand test coverage. 
> For a non-validating parser, when load-external-dtd is false, entity 
> references are skipped. However, the skippedEntity() event was not reported.
> 
> The problem was due to missing infoset augmentations when document handler's 
> startGeneralEntity/endGeneralEntity were called.  The fix therefore is simply 
> add the arguments.
> 
> webrev: http://cr.openjdk.java.net/~joehw/jdk8/8000172/webrev/
> 
> Please review.
> 
> Thanks,
> Joe


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

JAXP RFR: 8000172 : 2 SAX features does not work properly

2012-10-08 Thread Joe Wang 
This is an issue found while I was working with SQE to expand test 
coverage. For a non-validating parser, when load-external-dtd is false, 
entity references are skipped. However, the skippedEntity() event was 
not reported.


The problem was due to missing infoset augmentations when document 
handler's startGeneralEntity/endGeneralEntity were called.  The fix 
therefore is simply add the arguments.


webrev: http://cr.openjdk.java.net/~joehw/jdk8/8000172/webrev/

Please review.

Thanks,
Joe