Re: JDK 14 RFR of JDK-8231442 : Suppress warnings on non-serializable instance fields in java.sql.* modules

[Lance Andersen]

Hi Joe,

Looks OK

SyncProviderException.java, SQLClientInfoException.java, StatementEvent.java 
should probably have the copyright notice updated to 2019 prior to pushing

Best
Lance

> On Sep 25, 2019, at 12:34 AM, Joe Darcy  wrote:
> 
> Hello,
> 
> Next step in the serialization warnings pre-cleanup is java.sql.* modules. 
> Please review the proposed changes:
> 
> JDK-8231442 : Suppress warnings on non-serializable instance fields in 
> java.sql.* modules
> http://cr.openjdk.java.net/~darcy/8231442.0/
> 
> Several of the writeObject methods do runtime checks on whether on not 
> objects pointed to by the fields in question are serializable. The fields 
> with this runtime check get a explanatory comment noting that different from 
> the usual comment.
> 
> Thanks,
> 
> -Joe
> 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

JDK 14 RFR of JDK-8231442 : Suppress warnings on non-serializable instance fields in java.sql.* modules

[Joe Darcy]

Hello,

Next step in the serialization warnings pre-cleanup is java.sql.* 
modules. Please review the proposed changes:


    JDK-8231442 : Suppress warnings on non-serializable instance fields 
in java.sql.* modules

    http://cr.openjdk.java.net/~darcy/8231442.0/

Several of the writeObject methods do runtime checks on whether on not 
objects pointed to by the fields in question are serializable. The 
fields with this runtime check get a explanatory comment noting that 
different from the usual comment.


Thanks,

-Joe