Re: JDK 9 RFR of 8064463: BigDecimal should populate NumberFormatException message
On Dec 29, 2014, at 12:46 AM, Alan Bateman wrote: >> Patch: http://cr.openjdk.java.net/~bpb/8064463/webrev.00/ >> >> […] >> >> > This looks okay to me. A minor inconsistency is that one of the "Exponent > overflow " cases has a trailing dot, the other doesn't. Thanks. I’ll add a dot at line 559 before pushing. Brian
Re: JDK 9 RFR of 8064463: BigDecimal should populate NumberFormatException message
On 22/12/2014 21:13, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8064463 Patch: http://cr.openjdk.java.net/~bpb/8064463/webrev.00/ Summary: Ensure that the message strings of all NumberFormatExceptions are populated with appropriate content, excluding where the NFE merely wraps another exception in its cause. It was suggested in the issue description to include the contents of the supplied character array in the exception message. This is not done in this patch for the reason that the resulting string could be quite large. If it seems reasonable to include the characters the patch can be so amended. This looks okay to me. A minor inconsistency is that one of the "Exponent overflow " cases has a trailing dot, the other doesn't. -Alan
JDK 9 RFR of 8064463: BigDecimal should populate NumberFormatException message
Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8064463 Patch: http://cr.openjdk.java.net/~bpb/8064463/webrev.00/ Summary: Ensure that the message strings of all NumberFormatExceptions are populated with appropriate content, excluding where the NFE merely wraps another exception in its cause. It was suggested in the issue description to include the contents of the supplied character array in the exception message. This is not done in this patch for the reason that the resulting string could be quite large. If it seems reasonable to include the characters the patch can be so amended. Thanks, Brian
