Re: JDK 9 RFR of JDK-8031210 Remove serial warning from java.lang.Enum

[Lance Andersen - Oracle]

+1
On Jan 6, 2014, at 4:41 PM, Joe Darcy wrote:

> Hello,
> 
> Please review the patch below to add a @SuppressWarning("serial") to 
> java.lang.Enum to resolve a lint warning in the core libraries.
> 
> Thanks,
> 
> -Joe
> 
> --- a/src/share/classes/java/lang/Enum.javaMon Jan 06 11:48:32 2014 -0800
> +++ b/src/share/classes/java/lang/Enum.javaMon Jan 06 13:37:06 2014 -0800
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2003, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  *
>  * This code is free software; you can redistribute it and/or modify it
> @@ -52,6 +52,8 @@
>  * @see java.util.EnumMap
>  * @since   1.5
>  */
> +@SuppressWarnings("serial") // No serialVersionUID needed due to
> +// special-casing of enum types.
> public abstract class Enum>
> implements Comparable, Serializable {
> /**
> 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

Re: JDK 9 RFR of JDK-8031210 Remove serial warning from java.lang.Enum

[Mike Duigou]

Entirely reasonable. Approved.

Mike

On Jan 6 2014, at 13:41 , Joe Darcy  wrote:

> Hello,
> 
> Please review the patch below to add a @SuppressWarning("serial") to 
> java.lang.Enum to resolve a lint warning in the core libraries.
> 
> Thanks,
> 
> -Joe
> 
> --- a/src/share/classes/java/lang/Enum.javaMon Jan 06 11:48:32 2014 -0800
> +++ b/src/share/classes/java/lang/Enum.javaMon Jan 06 13:37:06 2014 -0800
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2003, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  *
>  * This code is free software; you can redistribute it and/or modify it
> @@ -52,6 +52,8 @@
>  * @see java.util.EnumMap
>  * @since   1.5
>  */
> +@SuppressWarnings("serial") // No serialVersionUID needed due to
> +// special-casing of enum types.
> public abstract class Enum>
> implements Comparable, Serializable {
> /**
> 

JDK 9 RFR of JDK-8031210 Remove serial warning from java.lang.Enum

[Joe Darcy]

Hello,

Please review the patch below to add a @SuppressWarning("serial") to 
java.lang.Enum to resolve a lint warning in the core libraries.


Thanks,

-Joe

--- a/src/share/classes/java/lang/Enum.javaMon Jan 06 11:48:32 2014 
-0800
+++ b/src/share/classes/java/lang/Enum.javaMon Jan 06 13:37:06 2014 
-0800

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2003, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -52,6 +52,8 @@
  * @see java.util.EnumMap
  * @since   1.5
  */
+@SuppressWarnings("serial") // No serialVersionUID needed due to
+// special-casing of enum types.
 public abstract class Enum>
 implements Comparable, Serializable {
 /**