Re: Please review: fix for java.time Issues with French locale on compact1, 2
On 12/09/2013 15:14, roger riggs wrote: Hi, Testing of java.time has found a problematic test on compact 1 and 2. The test relies on localization data for the French locale that is not present. Changing the tests to the US locale would be sufficient but then are redundant with other tests. The tests are unnecessary and are removed. Please review: http://cr.openjdk.java.net/~rriggs/webrev-nofrench-8024618/ Thanks, Roger TCK tests can't depend on optional locales so the change looks okay to me. In general however, there are several tests that uses FR and other locales. I wasn't aware that we are testing without localedata.jar being present. I hope not as it would require more yucky lists in TEST.groups. -Alan
Re: Please review: fix for java.time Issues with French locale on compact1, 2
I'd be more comfortable with them moving to the non-TCK area. But if they have to be deleted, so be it. Stephen On 12 September 2013 15:14, roger riggs roger.ri...@oracle.com wrote: Hi, Testing of java.time has found a problematic test on compact 1 and 2. The test relies on localization data for the French locale that is not present. Changing the tests to the US locale would be sufficient but then are redundant with other tests. The tests are unnecessary and are removed. Please review: http://cr.openjdk.java.net/~rriggs/webrev-nofrench-8024618/ Thanks, Roger
Please review: fix for java.time Issues with French locale on compact1, 2
Hi, Testing of java.time has found a problematic test on compact 1 and 2. The test relies on localization data for the French locale that is not present. Changing the tests to the US locale would be sufficient but then are redundant with other tests. The tests are unnecessary and are removed. Please review: http://cr.openjdk.java.net/~rriggs/webrev-nofrench-8024618/ Thanks, Roger
Re: Please review: fix for java.time Issues with French locale on compact1, 2
Hi Alan, For conformance tests, the configurations are more limited (Only the US locale). The other java.time tests that refer to specific locales don't rely on the locale data only the identity of the locale or depend on the fallback to the US locale. Otherwise a wider refactoring would be needed and still the configurations needed for unit testing would need to be more fine grained. Thanks, Roger On 9/12/2013 10:32 AM, Alan Bateman wrote: On 12/09/2013 15:14, roger riggs wrote: Hi, Testing of java.time has found a problematic test on compact 1 and 2. The test relies on localization data for the French locale that is not present. Changing the tests to the US locale would be sufficient but then are redundant with other tests. The tests are unnecessary and are removed. Please review: http://cr.openjdk.java.net/~rriggs/webrev-nofrench-8024618/ Thanks, Roger TCK tests can't depend on optional locales so the change looks okay to me. In general however, there are several tests that uses FR and other locales. I wasn't aware that we are testing without localedata.jar being present. I hope not as it would require more yucky lists in TEST.groups. -Alan
