RE: [11u] RFR (S): 8139965: Hang seen when using com.sun.jndi.ldap.search.replyQueueSize

2019-06-04 Thread Langer, Christoph
Thanks Paul.

> -Original Message-
> From: Hohensee, Paul 
> Sent: Montag, 3. Juni 2019 21:33
> To: Langer, Christoph ; jdk-updates-
> d...@openjdk.java.net
> Cc: Java Core Libs 
> Subject: Re: [11u] RFR (S): 8139965: Hang seen when using
> com.sun.jndi.ldap.search.replyQueueSize
> 
> I agree, looks fine.
> 
> Paul
> 
> On 6/2/19, 11:46 PM, "jdk-updates-dev on behalf of Langer, Christoph"  updates-dev-boun...@openjdk.java.net on behalf of
> christoph.lan...@sap.com> wrote:
> 
> Hi,
> 
> please help reviewing a backport to OpenJDK 11u.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8139965
> 11u-webrev: http://cr.openjdk.java.net/~clanger/webrevs/8139965.11u/
> 
> The patch did apply, however, it contained changes to testcase
> test/jdk/com/sun/jndi/ldap/LdapDnsProviderTest.java. The testcase is not
> part of JDK11u and its backport is also impossible as it belongs to an
> enhancement with associated CSR for JDK12 (JDK-8160768 [0]). The test
> update hasn't been part of the original review thread [1], so I think it is 
> ok to
> go with the change as suggested in the webrev.
> 
> Thanks
> Christoph
> 
> [0] https://bugs.openjdk.java.net/browse/JDK-8160768
> [1] https://mail.openjdk.java.net/pipermail/core-libs-dev/2018-
> September/055115.html
> 



Re: [11u] RFR (S): 8139965: Hang seen when using com.sun.jndi.ldap.search.replyQueueSize

2019-06-03 Thread Hohensee, Paul
I agree, looks fine.

Paul

On 6/2/19, 11:46 PM, "jdk-updates-dev on behalf of Langer, Christoph" 
 wrote:

Hi,

please help reviewing a backport to OpenJDK 11u.

Bug: https://bugs.openjdk.java.net/browse/JDK-8139965
11u-webrev: http://cr.openjdk.java.net/~clanger/webrevs/8139965.11u/

The patch did apply, however, it contained changes to testcase 
test/jdk/com/sun/jndi/ldap/LdapDnsProviderTest.java. The testcase is not part 
of JDK11u and its backport is also impossible as it belongs to an enhancement 
with associated CSR for JDK12 (JDK-8160768 [0]). The test update hasn't been 
part of the original review thread [1], so I think it is ok to go with the 
change as suggested in the webrev.

Thanks
Christoph

[0] https://bugs.openjdk.java.net/browse/JDK-8160768
[1] 
https://mail.openjdk.java.net/pipermail/core-libs-dev/2018-September/055115.html