RFR(XS): 8032678: [TESTBUG] sun/misc/Version/Version.java doesn't understand two-digit HotSpot minor version numbers
Hi, could you please review the following trivial change: http://cr.openjdk.java.net/~simonis/webrevs/8032678/ which fixes the JDK test jdk/test/sun/misc/Version/Version.java to correctly handle two-digit HotSpot minor version numbers. This became necessary after change 8031552: Update the Hotspot version numbers in Hotspot for JDK 8U bumped the minor HS version to '20' in jdk8u. This webrev is for jdk9 but it will have to be backported to jdk8u because there’s where the current problem happens. Thanks, Volker
Re: RFR(XS): 8032678: [TESTBUG] sun/misc/Version/Version.java doesn't understand two-digit HotSpot minor version numbers
Good change. I got this failure too. Thanks, Vladimir On 1/24/14 9:04 AM, Volker Simonis wrote: Hi, could you please review the following trivial change: http://cr.openjdk.java.net/~simonis/webrevs/8032678/ which fixes the JDK test jdk/test/sun/misc/Version/Version.java to correctly handle two-digit HotSpot minor version numbers. This became necessary after change 8031552: Update the Hotspot version numbers in Hotspot for JDK 8U bumped the minor HS version to '20' in jdk8u. This webrev is for jdk9 but it will have to be backported to jdk8u because there’s where the current problem happens. Thanks, Volker
Re: RFR(XS): 8032678: [TESTBUG] sun/misc/Version/Version.java doesn't understand two-digit HotSpot minor version numbers
Hi Vladimir, I've just pushed this to jdk9/dev. I also received an email stating that this bug needs to be updated, please request to defer or upgrade to P1 and request for approval. I assume that's because I entered 8-pool, 9 as Fix versions. Now I actually don't know what to do. It seems strange to upgrade this to P1 because it is only a test bug. On the other hand it is needed in 8u because there's where we have the trouble. So should I upgrade it to P1 and request approval for jdk8u-dev (or directly jdk8u)? The actual problem occurs in jdk8u only, because jdk8u-dev doesn't yet has change 8032678 which bumps the HS minor number to 20. Can I push directly to jdk8u or does the change has to go trough jdk8u-dev? Thanks, Volker On Fri, Jan 24, 2014 at 6:13 PM, Vladimir Kozlov vladimir.koz...@oracle.com wrote: Good change. I got this failure too. Thanks, Vladimir On 1/24/14 9:04 AM, Volker Simonis wrote: Hi, could you please review the following trivial change: http://cr.openjdk.java.net/~simonis/webrevs/8032678/ which fixes the JDK test jdk/test/sun/misc/Version/Version.java to correctly handle two-digit HotSpot minor version numbers. This became necessary after change 8031552: Update the Hotspot version numbers in Hotspot for JDK 8U bumped the minor HS version to '20' in jdk8u. This webrev is for jdk9 but it will have to be backported to jdk8u because there’s where the current problem happens. Thanks, Volker
Re: RFR(XS): 8032678: [TESTBUG] sun/misc/Version/Version.java doesn't understand two-digit HotSpot minor version numbers
And I just noticed from Alejandro's mail that there also exists hs24.60 for 7u60 now. So if somebody is interested in cleanly passing the jtreg tests on 7u60 this change will also has to be backported to 7u. On Fri, Jan 24, 2014 at 7:39 PM, Volker Simonis volker.simo...@gmail.com wrote: Hi Vladimir, I've just pushed this to jdk9/dev. I also received an email stating that this bug needs to be updated, please request to defer or upgrade to P1 and request for approval. I assume that's because I entered 8-pool, 9 as Fix versions. Now I actually don't know what to do. It seems strange to upgrade this to P1 because it is only a test bug. On the other hand it is needed in 8u because there's where we have the trouble. So should I upgrade it to P1 and request approval for jdk8u-dev (or directly jdk8u)? The actual problem occurs in jdk8u only, because jdk8u-dev doesn't yet has change 8032678 which bumps the HS minor number to 20. Can I push directly to jdk8u or does the change has to go trough jdk8u-dev? Thanks, Volker On Fri, Jan 24, 2014 at 6:13 PM, Vladimir Kozlov vladimir.koz...@oracle.com wrote: Good change. I got this failure too. Thanks, Vladimir On 1/24/14 9:04 AM, Volker Simonis wrote: Hi, could you please review the following trivial change: http://cr.openjdk.java.net/~simonis/webrevs/8032678/ which fixes the JDK test jdk/test/sun/misc/Version/Version.java to correctly handle two-digit HotSpot minor version numbers. This became necessary after change 8031552: Update the Hotspot version numbers in Hotspot for JDK 8U bumped the minor HS version to '20' in jdk8u. This webrev is for jdk9 but it will have to be backported to jdk8u because there’s where the current problem happens. Thanks, Volker
Re: RFR(XS): 8032678: [TESTBUG] sun/misc/Version/Version.java doesn't understand two-digit HotSpot minor version numbers
I've removed the incorrect-for-JBS multiple release values of 8-pool, 9 in the fixVersion field of the main bug record. -Joe On 1/24/2014 10:39 AM, Volker Simonis wrote: Hi Vladimir, I've just pushed this to jdk9/dev. I also received an email stating that this bug needs to be updated, please request to defer or upgrade to P1 and request for approval. I assume that's because I entered 8-pool, 9 as Fix versions. Now I actually don't know what to do. It seems strange to upgrade this to P1 because it is only a test bug. On the other hand it is needed in 8u because there's where we have the trouble. So should I upgrade it to P1 and request approval for jdk8u-dev (or directly jdk8u)? The actual problem occurs in jdk8u only, because jdk8u-dev doesn't yet has change 8032678 which bumps the HS minor number to 20. Can I push directly to jdk8u or does the change has to go trough jdk8u-dev? Thanks, Volker On Fri, Jan 24, 2014 at 6:13 PM, Vladimir Kozlov vladimir.koz...@oracle.com wrote: Good change. I got this failure too. Thanks, Vladimir On 1/24/14 9:04 AM, Volker Simonis wrote: Hi, could you please review the following trivial change: http://cr.openjdk.java.net/~simonis/webrevs/8032678/ which fixes the JDK test jdk/test/sun/misc/Version/Version.java to correctly handle two-digit HotSpot minor version numbers. This became necessary after change 8031552: Update the Hotspot version numbers in Hotspot for JDK 8U bumped the minor HS version to '20' in jdk8u. This webrev is for jdk9 but it will have to be backported to jdk8u because there’s where the current problem happens. Thanks, Volker
Re: RFR(XS): 8032678: [TESTBUG] sun/misc/Version/Version.java doesn't understand two-digit HotSpot minor version numbers
I updated Fix versions to 8u20. No need to upgrade since you are not pushing to jdk8. You need to send request for approval to push into 8u20 to jdk8u-...@openjdk.java.net I attached example. After approval, you can push to: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk Regards, Vladimir On 1/24/14 10:39 AM, Volker Simonis wrote: Hi Vladimir, I've just pushed this to jdk9/dev. I also received an email stating that this bug needs to be updated, please request to defer or upgrade to P1 and request for approval. I assume that's because I entered 8-pool, 9 as Fix versions. Now I actually don't know what to do. It seems strange to upgrade this to P1 because it is only a test bug. On the other hand it is needed in 8u because there's where we have the trouble. So should I upgrade it to P1 and request approval for jdk8u-dev (or directly jdk8u)? The actual problem occurs in jdk8u only, because jdk8u-dev doesn't yet has change 8032678 which bumps the HS minor number to 20. Can I push directly to jdk8u or does the change has to go trough jdk8u-dev? Thanks, Volker On Fri, Jan 24, 2014 at 6:13 PM, Vladimir Kozlov vladimir.koz...@oracle.com wrote: Good change. I got this failure too. Thanks, Vladimir On 1/24/14 9:04 AM, Volker Simonis wrote: Hi, could you please review the following trivial change: http://cr.openjdk.java.net/~simonis/webrevs/8032678/ which fixes the JDK test jdk/test/sun/misc/Version/Version.java to correctly handle two-digit HotSpot minor version numbers. This became necessary after change 8031552: Update the Hotspot version numbers in Hotspot for JDK 8U bumped the minor HS version to '20' in jdk8u. This webrev is for jdk9 but it will have to be backported to jdk8u because there’s where the current problem happens. Thanks, Volker ---BeginMessage--- Hi, This is a request to backport the following change: JDK-801 Issue: https://bugs.openjdk.java.net/browse/JDK-801 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3cbeb88b8735 Review : http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-January/013801.html The patch applies cleanly without any changes necessary. Cheers, -JB- ---End Message---
