Re: RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

2016-10-12 Thread Sergei Kovalev 
The fixed version is here: 
http://cr.openjdk.java.net/~skovalev/8167437/webrev.01/


I also modified CR description.


10.10.16 18:15, Sergei Kovalev wrote:

You are right. I'll rollback the change for the file.


10.10.16 18:05, Alan Bateman wrote:
sun.reflect.generics.parser is in java.base, I don't see anything 
using jdk.unsupported/sun.reflect. You can check this quickly by 
running the test without your change.


-Alan




--
With best regards,
Sergei

Re: RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

2016-10-10 Thread Sergei Kovalev 

You are right. I'll rollback the change for the file.


10.10.16 18:05, Alan Bateman wrote:
sun.reflect.generics.parser is in java.base, I don't see anything 
using jdk.unsupported/sun.reflect. You can check this quickly by 
running the test without your change.


-Alan


--
With best regards,
Sergei

Re: RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

2016-10-10 Thread Alan Bateman 

On 10/10/2016 15:55, Sergei Kovalev wrote:


Hi Alan,

sun.reflect.*

./jdk9_latest/bin/jmod describe ./jdk9_latest/jmods/jdk.unsupported.jmod

jdk.unsupported@9-ea
  requires mandated java.base
  exports com.sun.nio.file
  exports sun.misc
*  exports sun.reflect*
  operating-system-name Linux
  operating-system-architecture amd64
  operating-system-version 2.6
sun.reflect.generics.parser is in java.base, I don't see anything using 
jdk.unsupported/sun.reflect. You can check this quickly by running the 
test without your change.


-Alan

Re: RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

2016-10-10 Thread Sergei Kovalev 

Hi Alan,

sun.reflect.*

./jdk9_latest/bin/jmod describe ./jdk9_latest/jmods/jdk.unsupported.jmod

jdk.unsupported@9-ea
  requires mandated java.base
  exports com.sun.nio.file
  exports sun.misc
*  exports sun.reflect*
  operating-system-name Linux
  operating-system-architecture amd64
  operating-system-version 2.6


10.10.16 17:51, Alan Bateman wrote:

On 10/10/2016 14:55, Sergei Kovalev wrote:


Hello team,

Could you please review fix for:

BugID: https://bugs.openjdk.java.net/browse/JDK-8167437
WebRev: http://cr.openjdk.java.net/~skovalev/8167437/webrev.00/

Issue: two tests from java/lang uses internal API but have no 
declaration in jtreg header.

Solution: add missed declaration.


For TestBadSignatures then what is being used in jdk.unsupported?

-Alan


--
With best regards,
Sergei

Re: RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

2016-10-10 Thread Alan Bateman 

On 10/10/2016 14:55, Sergei Kovalev wrote:


Hello team,

Could you please review fix for:

BugID: https://bugs.openjdk.java.net/browse/JDK-8167437
WebRev: http://cr.openjdk.java.net/~skovalev/8167437/webrev.00/

Issue: two tests from java/lang uses internal API but have no 
declaration in jtreg header.

Solution: add missed declaration.


For TestBadSignatures then what is being used in jdk.unsupported?

-Alan

RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

2016-10-10 Thread Sergei Kovalev 

Hello team,

Could you please review fix for:

BugID: https://bugs.openjdk.java.net/browse/JDK-8167437
WebRev: http://cr.openjdk.java.net/~skovalev/8167437/webrev.00/

Issue: two tests from java/lang uses internal API but have no 
declaration in jtreg header.

Solution: add missed declaration.

--
With best regards,
Sergei