Re: RFR(xs): 8132745: minor cleanup of java/util/Scanner/ScanTest.java
Looks fine Stuart, -Joe On 7/30/2015 3:39 PM, Stuart Marks wrote: Hi all, Please review this quick cleanup to this test I moved into the open yesterday. It changes the JVM's locale, and out of an abundance of caution it's safer to run things that change JVM global state in /othervm mode. Bug: https://bugs.openjdk.java.net/browse/JDK-8132745 Patch appended below. Thanks, s'marks # HG changeset patch # User smarks # Date 1438295744 25200 # Thu Jul 30 15:35:44 2015 -0700 # Node ID 4ce7979b7610574075bd4ade3b73004cde5e9ac3 # Parent d23203801b5369603d2dda21a6aff6225195001d 8132745: minor cleanup of java/util/Scanner/ScanTest.java Reviewed-by: XXX diff -r d23203801b53 -r 4ce7979b7610 test/java/util/Scanner/ScanTest.java --- a/test/java/util/Scanner/ScanTest.javaThu Jul 30 14:16:58 2015 -0400 +++ b/test/java/util/Scanner/ScanTest.javaThu Jul 30 15:35:44 2015 -0700 @@ -26,6 +26,7 @@ * @bug 4313885 4926319 4927634 5032610 5032622 5049968 5059533 6223711 6277261 6269946 6288823 * @summary Basic tests of java.util.Scanner methods * @key randomness + * @run main/othervm ScanTest */ import java.util.*;
Re: RFR(xs): 8132745: minor cleanup of java/util/Scanner/ScanTest.java
+1 On 07/30/2015 03:40 PM, Joseph D. Darcy wrote: Looks fine Stuart, -Joe On 7/30/2015 3:39 PM, Stuart Marks wrote: Hi all, Please review this quick cleanup to this test I moved into the open yesterday. It changes the JVM's locale, and out of an abundance of caution it's safer to run things that change JVM global state in /othervm mode. Bug: https://bugs.openjdk.java.net/browse/JDK-8132745 Patch appended below. Thanks, s'marks # HG changeset patch # User smarks # Date 1438295744 25200 # Thu Jul 30 15:35:44 2015 -0700 # Node ID 4ce7979b7610574075bd4ade3b73004cde5e9ac3 # Parent d23203801b5369603d2dda21a6aff6225195001d 8132745: minor cleanup of java/util/Scanner/ScanTest.java Reviewed-by: XXX diff -r d23203801b53 -r 4ce7979b7610 test/java/util/Scanner/ScanTest.java --- a/test/java/util/Scanner/ScanTest.javaThu Jul 30 14:16:58 2015 -0400 +++ b/test/java/util/Scanner/ScanTest.javaThu Jul 30 15:35:44 2015 -0700 @@ -26,6 +26,7 @@ * @bug 4313885 4926319 4927634 5032610 5032622 5049968 5059533 6223711 6277261 6269946 6288823 * @summary Basic tests of java.util.Scanner methods * @key randomness + * @run main/othervm ScanTest */ import java.util.*;
RFR(xs): 8132745: minor cleanup of java/util/Scanner/ScanTest.java
Hi all, Please review this quick cleanup to this test I moved into the open yesterday. It changes the JVM's locale, and out of an abundance of caution it's safer to run things that change JVM global state in /othervm mode. Bug: https://bugs.openjdk.java.net/browse/JDK-8132745 Patch appended below. Thanks, s'marks # HG changeset patch # User smarks # Date 1438295744 25200 # Thu Jul 30 15:35:44 2015 -0700 # Node ID 4ce7979b7610574075bd4ade3b73004cde5e9ac3 # Parent d23203801b5369603d2dda21a6aff6225195001d 8132745: minor cleanup of java/util/Scanner/ScanTest.java Reviewed-by: XXX diff -r d23203801b53 -r 4ce7979b7610 test/java/util/Scanner/ScanTest.java --- a/test/java/util/Scanner/ScanTest.java Thu Jul 30 14:16:58 2015 -0400 +++ b/test/java/util/Scanner/ScanTest.java Thu Jul 30 15:35:44 2015 -0700 @@ -26,6 +26,7 @@ * @bug 4313885 4926319 4927634 5032610 5032622 5049968 5059533 6223711 6277261 6269946 6288823 * @summary Basic tests of java.util.Scanner methods * @key randomness + * @run main/othervm ScanTest */ import java.util.*;