Re: RFR: 8026009: Changes for 8025968 break all stream tests

2013-10-07 Thread Mike Duigou
Looks good to me but I haven't completed a full build/test with this change 
(yet).

Mike

On Oct 7 2013, at 14:56 , Henry Jen wrote:

> Hi,
> 
> May I have a quick review on this left-out change to fix broken test?
> Apology for the inconvenience.
> 
> http://cr.openjdk.java.net/~henryjen/tl/8026009/0/webrev/
> 
> Following is all it is,
> 
>> diff --git a/test/java/util/stream/bootlib/java/util/stream/OpTestCase.java 
>> b/test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
>> --- a/test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
>> +++ b/test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
>> @@ -591,10 +591,10 @@
>> 
>> // Test data
>> 
>> -private class ShortCircuitOp implements StatelessTestOp {
>> +static class ShortCircuitOp implements StatelessTestOp {
>> private final StreamShape shape;
>> 
>> -private ShortCircuitOp(StreamShape shape) {
>> +ShortCircuitOp(StreamShape shape) {
>> this.shape = shape;
>> }
>> 
> 
> Cheers,
> Henry
> 



RFR: 8026009: Changes for 8025968 break all stream tests

2013-10-07 Thread Henry Jen
Hi,

May I have a quick review on this left-out change to fix broken test?
Apology for the inconvenience.

http://cr.openjdk.java.net/~henryjen/tl/8026009/0/webrev/

Following is all it is,

> diff --git a/test/java/util/stream/bootlib/java/util/stream/OpTestCase.java 
> b/test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
> --- a/test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
> +++ b/test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
> @@ -591,10 +591,10 @@
>  
>  // Test data
>  
> -private class ShortCircuitOp implements StatelessTestOp {
> +static class ShortCircuitOp implements StatelessTestOp {
>  private final StreamShape shape;
>  
> -private ShortCircuitOp(StreamShape shape) {
> +ShortCircuitOp(StreamShape shape) {
>  this.shape = shape;
>  }
>  

Cheers,
Henry