Re: RFR: 8075806: divideExact is missing in java.lang.Math [v5]
On Thu, 22 Jul 2021 19:40:46 GMT, Brian Burkhalter wrote: >> Please consider this proposal to add `divideExact()` methods for integral >> data types to `java.lang.Math` thereby rounding out "exact" support to all >> four basic arithmetic operations. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8075806: Clean up division by zero verbiage Marked as reviewed by darcy (Reviewer). test/jdk/java/lang/Math/ExactArithTests.java line 135: > 133: } > 134: > 135: boolean exceptionExpected = false; Please add "divideExact" to the list of methods tested by static void testIntegerExact(int x, int y) and similar change for long. - PR: https://git.openjdk.java.net/jdk/pull/4770
Re: RFR: 8075806: divideExact is missing in java.lang.Math [v5]
> Please consider this proposal to add `divideExact()` methods for integral > data types to `java.lang.Math` thereby rounding out "exact" support to all > four basic arithmetic operations. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8075806: Clean up division by zero verbiage - Changes: - all: https://git.openjdk.java.net/jdk/pull/4770/files - new: https://git.openjdk.java.net/jdk/pull/4770/files/328e4188..5093a2e8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=4770=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk=4770=03-04 Stats: 16 lines in 2 files changed: 4 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/jdk/pull/4770.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4770/head:pull/4770 PR: https://git.openjdk.java.net/jdk/pull/4770