Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-15 Thread Julia Boes
On Sat, 13 Feb 2021 10:56:32 GMT, Andrey Turbanov 
 wrote:

>> This fours tests pass without problems, when I run them separately.
>> 
>> ## sun/security/tools/jarsigner/TimestampCheck.java
>> ## sun/security/tools/keytool/DefaultOptions.java
>> ## sanity/client/SwingSet/src/ColorChooserDemoTest.java
>> ## sanity/client/SwingSet/src/SwingSet2DemoTest.java
>> 
>> make test TEST="jtreg:sun/security/tools/jarsigner/TimestampCheck.java 
>> sun/security/tools/keytool/DefaultOptions.java 
>> sanity/client/SwingSet/src/SwingSet2DemoTest.java 
>> sanity/client/SwingSet/src/ColorChooserDemoTest.java"
>> 
>> Building target 'test' in configuration 'windows-x86_64-server-release'
>> Test selection 'jtreg:sun/security/tools/jarsigner/TimestampCheck.java 
>> sun/security/tools/keytool/DefaultOptions.java 
>> sanity/client/SwingSet/src/SwingSet2DemoTest.java 
>> sanity/client/SwingSet/src/ColorChooserDemoTest.java', will run:
>> * jtreg:test/jdk/sun/security/tools/jarsigner/TimestampCheck.java
>> * jtreg:test/jdk/sun/security/tools/keytool/DefaultOptions.java
>> * jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java
>> * jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java
>> 
>> Running test 
>> 'jtreg:test/jdk/sun/security/tools/jarsigner/TimestampCheck.java'
>> Passed: sun/security/tools/jarsigner/TimestampCheck.java
>> Test results: passed: 1
>> Report written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sun_security_tools_jarsigner_TimestampCheck_java\html\report.html
>> Results written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sun_security_tools_jarsigner_TimestampCheck_java
>> Finished running test 
>> 'jtreg:test/jdk/sun/security/tools/jarsigner/TimestampCheck.java'
>> Test report is stored in 
>> build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_tools_jarsigner_TimestampCheck_java
>> 
>> Running test 
>> 'jtreg:test/jdk/sun/security/tools/keytool/DefaultOptions.java'
>> Passed: sun/security/tools/keytool/DefaultOptions.java
>> Test results: passed: 1
>> Report written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sun_security_tools_keytool_DefaultOptions_java\html\report.html
>> Results written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sun_security_tools_keytool_DefaultOptions_java
>> Finished running test 
>> 'jtreg:test/jdk/sun/security/tools/keytool/DefaultOptions.java'
>> Test report is stored in 
>> build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_tools_keytool_DefaultOptions_java
>> 
>> Running test 
>> 'jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java'
>> Passed: sanity/client/SwingSet/src/SwingSet2DemoTest.java
>> Test results: passed: 1
>> Report written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java\html\report.html
>> Results written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java
>> Finished running test 
>> 'jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java'
>> Test report is stored in 
>> build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java
>> 
>> Running test 
>> 'jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java'
>> Passed: sanity/client/SwingSet/src/ColorChooserDemoTest.java
>> Test results: passed: 1
>> Report written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java\html\report.html
>> Results written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java
>> Finished running test 
>> 'jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java'
>> Test report is stored in 
>> build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java
>> 
>> ==
>> Test summary
>> ==
>>TEST  TOTAL  PASS  FAIL 
>> ERROR
>>jtreg:test/jdk/sun/security/tools/jarsigner/TimestampCheck.java
>>  1 1 0   
>>   0
>>jtreg:test/jdk/sun/security/tools/keytool/DefaultOptions.java
>>  1 1 0   
>>   0
>>

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-15 Thread Alan Bateman
On Sat, 13 Feb 2021 10:56:32 GMT, Andrey Turbanov 
 wrote:

>> This fours tests pass without problems, when I run them separately.
>> 
>> ## sun/security/tools/jarsigner/TimestampCheck.java
>> ## sun/security/tools/keytool/DefaultOptions.java
>> ## sanity/client/SwingSet/src/ColorChooserDemoTest.java
>> ## sanity/client/SwingSet/src/SwingSet2DemoTest.java
>> 
>> make test TEST="jtreg:sun/security/tools/jarsigner/TimestampCheck.java 
>> sun/security/tools/keytool/DefaultOptions.java 
>> sanity/client/SwingSet/src/SwingSet2DemoTest.java 
>> sanity/client/SwingSet/src/ColorChooserDemoTest.java"
>> 
>> Building target 'test' in configuration 'windows-x86_64-server-release'
>> Test selection 'jtreg:sun/security/tools/jarsigner/TimestampCheck.java 
>> sun/security/tools/keytool/DefaultOptions.java 
>> sanity/client/SwingSet/src/SwingSet2DemoTest.java 
>> sanity/client/SwingSet/src/ColorChooserDemoTest.java', will run:
>> * jtreg:test/jdk/sun/security/tools/jarsigner/TimestampCheck.java
>> * jtreg:test/jdk/sun/security/tools/keytool/DefaultOptions.java
>> * jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java
>> * jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java
>> 
>> Running test 
>> 'jtreg:test/jdk/sun/security/tools/jarsigner/TimestampCheck.java'
>> Passed: sun/security/tools/jarsigner/TimestampCheck.java
>> Test results: passed: 1
>> Report written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sun_security_tools_jarsigner_TimestampCheck_java\html\report.html
>> Results written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sun_security_tools_jarsigner_TimestampCheck_java
>> Finished running test 
>> 'jtreg:test/jdk/sun/security/tools/jarsigner/TimestampCheck.java'
>> Test report is stored in 
>> build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_tools_jarsigner_TimestampCheck_java
>> 
>> Running test 
>> 'jtreg:test/jdk/sun/security/tools/keytool/DefaultOptions.java'
>> Passed: sun/security/tools/keytool/DefaultOptions.java
>> Test results: passed: 1
>> Report written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sun_security_tools_keytool_DefaultOptions_java\html\report.html
>> Results written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sun_security_tools_keytool_DefaultOptions_java
>> Finished running test 
>> 'jtreg:test/jdk/sun/security/tools/keytool/DefaultOptions.java'
>> Test report is stored in 
>> build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_tools_keytool_DefaultOptions_java
>> 
>> Running test 
>> 'jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java'
>> Passed: sanity/client/SwingSet/src/SwingSet2DemoTest.java
>> Test results: passed: 1
>> Report written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java\html\report.html
>> Results written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java
>> Finished running test 
>> 'jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java'
>> Test report is stored in 
>> build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java
>> 
>> Running test 
>> 'jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java'
>> Passed: sanity/client/SwingSet/src/ColorChooserDemoTest.java
>> Test results: passed: 1
>> Report written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java\html\report.html
>> Results written to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java
>> Finished running test 
>> 'jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java'
>> Test report is stored in 
>> build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java
>> 
>> ==
>> Test summary
>> ==
>>TEST  TOTAL  PASS  FAIL 
>> ERROR
>>jtreg:test/jdk/sun/security/tools/jarsigner/TimestampCheck.java
>>  1 1 0   
>>   0
>>jtreg:test/jdk/sun/security/tools/keytool/DefaultOptions.java
>>  1 1 0   
>>   0
>>

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-13 Thread Andrey Turbanov
On Sat, 13 Feb 2021 10:20:29 GMT, Andrey Turbanov 
 wrote:

>> ## tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java
>> 
>> make test 
>> TEST="jtreg:tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java"
>> 
>> STDOUT:
>> [00:56:54.598] Parsing [--jpt-run=jdk.jpackage.tests.UnicodeArgsTest]...
>> [00:56:54.650] jdk.jpackage.tests.UnicodeArgsTest.test8246042 -> [public 
>> void jdk.jpackage.tests.UnicodeArgsTest.test8246042(boolean)]
>> [00:56:54.682] Create: UnicodeArgsTest.test8246042(true)
>> [00:56:54.684] Create: UnicodeArgsTest.test8246042(false)
>> [00:56:54.688] [ RUN  ] UnicodeArgsTest.test8246042(false)
>> [00:56:54.693] TRACE: Test string code points: [0x00e9]
>> [00:56:54.875] TRACE: exec: Execute tool provider [javac -d 
>> .\test8246042.9782d070\jar-workdir 
>> F:\Projects\official_openjdk\test\jdk\tools\jpackage\apps\image\Hello.java](4)...
>> [00:56:55.996] TRACE: exec: Done. Exit code: 0
>> [00:56:55.997] TRACE: assertEquals(0): Check command tool provider 
>> [javac -d .\test8246042.9782d070\jar-workdir 
>> F:\Projects\official_openjdk\test\jdk\tools\jpackage\apps\image\Hello.java](4)
>>  exited with 0 code
>> [00:56:56.014] TRACE: exec: Execute tool provider [jar -c -f 
>> .\test8246042.9782d070\input\hello.jar -C .\test8246042.9782d070\jar-workdir 
>> .](7)...
>> [00:56:56.188] TRACE: exec: Done. Exit code: 0
>> [00:56:56.188] TRACE: assertEquals(0): Check command tool provider [jar 
>> -c -f .\test8246042.9782d070\input\hello.jar -C 
>> .\test8246042.9782d070\jar-workdir .](7) exited with 0 code
>> [00:56:56.196] TRACE: exec: Execute tool provider [jpackage --input 
>> .\test8246042.9782d070\input --dest .\test8246042.9782d070\output --name 
>> 8246042UnicodeArgsTest --type app-image --main-jar hello.jar --main-class 
>> Hello --win-console --arguments ? --verbose](17)...
>> [00:56:56.225] Creating app package: 8246042UnicodeArgsTest in 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_tools_jpackage_share_jdk_jpackage_tests_UnicodeArgsTest_java\scratch\0.\test8246042.9782d070\output
>> [00:57:07.680] Command:
>> jlink --output 
>> .\test8246042.9782d070\output\8246042UnicodeArgsTest\runtime --module-path 
>> f:\\projects\\official_openjdk\\build\\windows-x86_64-server-release\\images\\jdk\\jmods
>>  --add-modules 
>> jdk.management.jfr,java.rmi,jdk.jdi,jdk.charsets,java.xml,jdk.xml.dom,java.datatransfer,jdk.jstatd,jdk.httpserver,java.desktop,java.security.sasl,jdk.zipfs,java.base,jdk.crypto.ec,jdk.javadoc,jdk.management.agent,jdk.jshell,jdk.editpad,java.sql.rowset,jdk.jsobject,jdk.sctp,java.smartcardio,jdk.jlink,jdk.unsupported,java.security.jgss,java.compiler,jdk.nio.mapmode,jdk.dynalink,jdk.unsupported.desktop,jdk.accessibility,jdk.security.jgss,java.sql,jdk.incubator.vector,java.xml.crypto,java.logging,java.transaction.xa,jdk.jfr,jdk.crypto.cryptoki,jdk.net,java.naming,jdk.internal.ed,java.prefs,java.net.http,jdk.compiler,jdk.naming.rmi,jdk.internal.opt,jdk.jconsole,jdk.attach,jdk.crypto.mscapi,jdk.internal.le,java.management,jdk.jdwp.agent,jdk.internal.jvmstat,jdk.incubator.foreign,java.instr
 
ument,jdk.management,jdk.security.auth,java.scripting,jdk.jdeps,jdk.jartool,java.management.rmi,jdk.jpackage,jdk.naming.dns,jdk.localedata
 --strip-native-commands --strip-debug --no-man-pages --no-header-files
>> [00:57:07.680] Output:
>> WARNING: Using incubator modules: jdk.incubator.vector, 
>> jdk.incubator.foreign
>> 
>> [00:57:07.681] Returned: 0
>> 
>> [00:57:07.685] Using default package resource java48.ico [icon] (add 
>> 8246042UnicodeArgsTest.ico to the resource-dir to customize).
>> [00:57:07.707] Warning: Windows Defender may prevent jpackage from 
>> functioning. If there is an issue, it can be addressed by either disabling 
>> realtime monitoring, or adding an exclusion for the directory 
>> "f:\projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_tools_jpackage_share_jdk_jpackage_tests_UnicodeArgsTest_java\tmp\jdk.jpackage16485063537873697224".
>> [00:57:07.712] Using default package resource WinLauncher.template 
>> [Template for creating executable properties file] (add 
>> 8246042UnicodeArgsTest.properties to the resource-dir to customize).
>> [00:57:07.746] Succeeded in building Windows Application Image package
>> [00:57:07.748] TRACE: exec: Done. Exit code: 0
>> [00:57:07.748] TRACE: assertEquals(0): Check command tool provider 
>> [jpackage --input .\test8246042.9782d070\input --dest 
>> .\test8246042.9782d070\output --name 8246042UnicodeArgsTest --type app-image 
>> --main-jar hello.jar --main-class Hello --win-console --arguments ? 
>> --verbose](17) exited with 0 code
>> [00:57:07.766] TRACE: assertStringListEquals(): Check there is only one 
>> file with [.jpackage.xml] name in the package
>> [00:57:07.768] TRACE: 

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-13 Thread Andrey Turbanov
On Fri, 12 Feb 2021 22:12:29 GMT, Andrey Turbanov 
 wrote:

>> ## java/security/AccessController/DoPrivAccompliceTest.java
>> 
>> make test 
>> TEST="jtreg:java/security/AccessController/DoPrivAccompliceTest.java"
>> 
>> STDOUT:
>> Adding DoPrivAccomplice.class to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivAccomplice.jar
>> 
>> Created jar file 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivAccomplice.jar
>> Adding DoPrivTest.class to 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivTest.jar
>> 
>> Created jar file 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivTest.jar
>> Created policy for 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivAccomplice.jar
>> Command line: 
>> [f:\projects\official_openjdk\build\windows-x86_64-server-release\images\jdk\bin\java.exe
>>  -cp 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\classes\0\java\security\AccessController\DoPrivAccompliceTest.d;F:\Projects\official_openjdk\test\jdk\java\security\AccessController;F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\classes\0\test\lib;F:\Projects\official_openjdk\test\lib;C:\Programs\jtreg-4.2.0-tip\jtreg\lib\javatest.jar;C:\Programs\jtreg-4.2.0-tip\jtreg\lib\jtreg.jar
>>  -Xmx512m -XX:MaxRAMPercentage=6 
>> -Djava.io.tmpdir=f:\projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\tmp
>>  -ea -esa -Djava.security.manager 
>> -Djava.security.policy=F:\Projects\official_openjdk\build\
 
windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\java.policy
 -classpath 
F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivAccomplice.jar;F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivTest.jar
 DoPrivTest ]
>> [2021-02-12T21:42:29.297091800Z] Gathering output for process 12712
>> [2021-02-12T21:42:29.544092Z] Waiting for completion for process 12712
>> [2021-02-12T21:42:29.544092Z] Waiting for completion finished for 
>> process 12712
>> Output and diagnostic info for process 12712 was saved into 
>> 'pid-12712-output.log'
>> [2021-02-12T21:42:29.547092500Z] Waiting for completion for process 12712
>> [2021-02-12T21:42:29.547092500Z] Waiting for completion finished for 
>> process 12712
>> Created policy for 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivTest.jar
>> Command line: 
>> [f:\projects\official_openjdk\build\windows-x86_64-server-release\images\jdk\bin\java.exe
>>  -cp 
>> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\classes\0\java\security\AccessController\DoPrivAccompliceTest.d;F:\Projects\official_openjdk\test\jdk\java\security\AccessController;F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\classes\0\test\lib;F:\Projects\official_openjdk\test\lib;C:\Programs\jtreg-4.2.0-tip\jtreg\lib\javatest.jar;C:\Programs\jtreg-4.2.0-tip\jtreg\lib\jtreg.jar
>>  -Xmx512m -XX:MaxRAMPercentage=6 
>> -Djava.io.tmpdir=f:\projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\tmp
>>  -ea -esa -Djava.security.manager 
>> -Djava.security.policy=F:\Projects\official_openjdk\build\
 
windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\java.policy
 -classpath 

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-12 Thread Andrey Turbanov
On Fri, 12 Feb 2021 21:53:13 GMT, Andrey Turbanov 
 wrote:

>> ## java/nio/file/Files/CopyAndMove.java
>> 
>> make test TEST="jtreg:java/nio/file/Files/CopyAndMove.java"
>> 
>> STDOUT:
>> Seed from RandomFactory = 704532001916725417L
>> STDERR:
>> dir1: 
>> f:\projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_nio_file_Files_CopyAndMove_java\tmp\name9678927043623070601
>>  (NTFS)
>> dir2: .\name1900089232270637553 (NTFS)
>> java.lang.RuntimeException: AtomicMoveNotSupportedException expected
>> at CopyAndMove.testMove(CopyAndMove.java:369)
>> at CopyAndMove.main(CopyAndMove.java:74)
>> at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
>> Method)
>> at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
>> at 
>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>> at 
>> com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
>> at java.base/java.lang.Thread.run(Thread.java:831)
>> 
>> JavaTest Message: Test threw exception: java.lang.RuntimeException: 
>> AtomicMoveNotSupportedException expected
>> JavaTest Message: shutting down test
>> 
>> STATUS:Failed.`main' threw exception: java.lang.RuntimeException: 
>> AtomicMoveNotSupportedException expected
>> 
>> Checked in debugger:
>> 
>> Files.getFileStore(dir1) = {WindowsFileStore@1211} "ssd (f:)"
>> Files.getFileStore(dir2) = {WindowsFileStore@1213} "ssd (F:)"
>> sameDevice = false
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8219644 looks like there is already 
>> known bug this test.
>
> ## java/security/AccessController/DoPrivAccompliceTest.java
> 
> make test 
> TEST="jtreg:java/security/AccessController/DoPrivAccompliceTest.java"
> 
> STDOUT:
> Adding DoPrivAccomplice.class to 
> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivAccomplice.jar
> 
> Created jar file 
> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivAccomplice.jar
> Adding DoPrivTest.class to 
> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivTest.jar
> 
> Created jar file 
> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivTest.jar
> Created policy for 
> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivAccomplice.jar
> Command line: 
> [f:\projects\official_openjdk\build\windows-x86_64-server-release\images\jdk\bin\java.exe
>  -cp 
> F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\classes\0\java\security\AccessController\DoPrivAccompliceTest.d;F:\Projects\official_openjdk\test\jdk\java\security\AccessController;F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\classes\0\test\lib;F:\Projects\official_openjdk\test\lib;C:\Programs\jtreg-4.2.0-tip\jtreg\lib\javatest.jar;C:\Programs\jtreg-4.2.0-tip\jtreg\lib\jtreg.jar
>  -Xmx512m -XX:MaxRAMPercentage=6 
> -Djava.io.tmpdir=f:\projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\tmp
>  -ea -esa -Djava.security.manager 
> -Djava.security.policy=F:\Projects\official_openjdk\build\w
 
indows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\java.policy
 -classpath 
F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivAccomplice.jar;F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivTest.jar
 DoPrivTest ]
> [2021-02-12T21:42:29.297091800Z] Gathering output for process 12712
> [2021-02-12T21:42:29.544092Z] Waiting for completion for process 12712
> [2021-02-12T21:42:29.544092Z] Waiting for completion finished for process 
> 12712
> Output and diagnostic info for process 12712 was saved into 
> 

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-12 Thread Andrey Turbanov
On Fri, 12 Feb 2021 21:32:04 GMT, Andrey Turbanov 
 wrote:

>> ## java/net/MulticastSocket/SetLoopbackMode.java
>> 
>> make test 
>> TEST="jtreg:test/jdk/java/net/MulticastSocket/SetLoopbackMode.java"
>> 
>> 
>> STDOUT:
>> IPv6 can be used
>> Default network interface: null
>> 
>> Test will use multicast group: /ff01:0:0:0:0:0:0:1
>> NetworkInterface.getByInetAddress(grp): null
>> STDERR:
>> java.net.NoRouteToHostException: No route to host: no further information
>> at java.base/sun.nio.ch.Net.joinOrDrop6(Native Method)
>> at java.base/sun.nio.ch.Net.join6(Net.java:734)
>> at 
>> java.base/sun.nio.ch.DatagramChannelImpl.innerJoin(DatagramChannelImpl.java:1515)
>> at 
>> java.base/sun.nio.ch.DatagramChannelImpl.join(DatagramChannelImpl.java:1551)
>> at 
>> java.base/sun.nio.ch.DatagramSocketAdaptor.joinGroup(DatagramSocketAdaptor.java:532)
>> at 
>> java.base/sun.nio.ch.DatagramSocketAdaptor.joinGroup(DatagramSocketAdaptor.java:479)
>> at 
>> java.base/java.net.MulticastSocket.joinGroup(MulticastSocket.java:318)
>> at SetLoopbackMode.main(SetLoopbackMode.java:132)
>> at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
>> Method)
>> at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
>> at 
>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>> at 
>> com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
>> at java.base/java.lang.Thread.run(Thread.java:831)
>> 
>> JavaTest Message: Test threw exception: java.net.NoRouteToHostException: 
>> No route to host: no further information
>> JavaTest Message: shutting down test
>> 
>> STATUS:Failed.`main' threw exception: java.net.NoRouteToHostException: 
>> No route to host: no further information
>> 
>> Cause looks similar to `MulticastAddresses`: virtualbox network interface:
>> Test: /ff01:0:0:0:0:0:0:1  ni: name:eth10 (VirtualBox Host-Only Ethernet 
>> Adapter)
>> joinGroup(InetAddress) Failed: No route to host: no further information
>> Will investigate futher.
>
> ## java/nio/file/Files/CopyAndMove.java
> 
> make test TEST="jtreg:java/nio/file/Files/CopyAndMove.java"
> 
> STDOUT:
> Seed from RandomFactory = 704532001916725417L
> STDERR:
> dir1: 
> f:\projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_nio_file_Files_CopyAndMove_java\tmp\name9678927043623070601
>  (NTFS)
> dir2: .\name1900089232270637553 (NTFS)
> java.lang.RuntimeException: AtomicMoveNotSupportedException expected
> at CopyAndMove.testMove(CopyAndMove.java:369)
> at CopyAndMove.main(CopyAndMove.java:74)
> at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
> at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at 
> com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> at java.base/java.lang.Thread.run(Thread.java:831)
> 
> JavaTest Message: Test threw exception: java.lang.RuntimeException: 
> AtomicMoveNotSupportedException expected
> JavaTest Message: shutting down test
> 
> STATUS:Failed.`main' threw exception: java.lang.RuntimeException: 
> AtomicMoveNotSupportedException expected
> 
> Checked in debugger:
> 
> Files.getFileStore(dir1) = {WindowsFileStore@1211} "ssd (f:)"
> Files.getFileStore(dir2) = {WindowsFileStore@1213} "ssd (F:)"
> sameDevice = false
> 
> https://bugs.openjdk.java.net/browse/JDK-8219644 looks like there is already 
> known bug this test.

## java/security/AccessController/DoPrivAccompliceTest.java

make test 
TEST="jtreg:java/security/AccessController/DoPrivAccompliceTest.java"

STDOUT:
Adding DoPrivAccomplice.class to 
F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivAccomplice.jar

Created jar file 
F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivAccomplice.jar
Adding DoPrivTest.class to 
F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_security_AccessController_DoPrivAccompliceTest_java\scratch\0.\DoPrivTest.jar

Created jar file 

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-12 Thread Andrey Turbanov
On Fri, 12 Feb 2021 21:12:14 GMT, Andrey Turbanov 
 wrote:

>> ## java/net/MulticastSocket/MulticastAddresses.java
>> 
>> make test 
>> TEST="jtreg:test/jdk/java/net/MulticastSocket/MulticastAddresses.java"
>> 
>> STDOUT:
>> Test: /224.80.80.80  ni: name:eth1 (PANGP Virtual Ethernet Adapter)
>> joinGroup(InetAddress) Passed.
>> joinGroup(InetAddress,NetworkInterface) Passed.
>> Test: /129.1.1.1
>> joinGroup(InetAddress)
>> Passed: Not a multicast address
>> Test: /ff01:0:0:0:0:0:0:1  ni: name:eth10 (VirtualBox Host-Only Ethernet 
>> Adapter)
>> joinGroup(InetAddress) Failed: No route to host: no further 
>> information
>> Test: /ff02:0:0:0:0:0:0:1234  ni: name:eth10 (VirtualBox Host-Only 
>> Ethernet Adapter)
>> joinGroup(InetAddress) Passed.
>> joinGroup(InetAddress,NetworkInterface) Passed.
>> Test: /ff05:0:0:0:0:0:0:a  ni: name:eth10 (VirtualBox Host-Only Ethernet 
>> Adapter)
>> joinGroup(InetAddress) Passed.
>> joinGroup(InetAddress,NetworkInterface) Passed.
>> Test: /ff0e:0:0:0:0:0:1234:a  ni: name:eth10 (VirtualBox Host-Only 
>> Ethernet Adapter)
>> joinGroup(InetAddress) Passed.
>> joinGroup(InetAddress,NetworkInterface) Passed.
>> Test: /0:0:0:0:0:0:0:1
>> joinGroup(InetAddress)
>> Passed: Not a multicast address
>> Test: /0:0:0:0:0:0:8101:101
>> joinGroup(InetAddress)
>> Passed: Not a multicast address
>> Test: /fe80:0:0:0:a00:20ff:fee5:bc02
>> joinGroup(InetAddress)
>> Passed: Not a multicast address
>> STDERR:
>> java.lang.Exception: 1 test(s) failed - see log file.
>> at MulticastAddresses.runTest(MulticastAddresses.java:93)
>> at MulticastAddresses.main(MulticastAddresses.java:138)
>> at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
>> Method)
>> at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
>> at 
>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>> at 
>> com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
>> at java.base/java.lang.Thread.run(Thread.java:831)
>> 
>> JavaTest Message: Test threw exception: java.lang.Exception
>> JavaTest Message: shutting down test
>> 
>> 
>> TEST RESULT: Failed. Execution failed: `main' threw exception: 
>> java.lang.Exception: 1 test(s) failed - see log file.
>> 
>> 
>> I connected debbuger and got this stack trace:
>> 
>> java.net.NoRouteToHostException: No route to host: no further information
>> at java.base/sun.nio.ch.Net.joinOrDrop6(Native Method)
>> at java.base/sun.nio.ch.Net.join6(Net.java:734)
>> at 
>> java.base/sun.nio.ch.DatagramChannelImpl.innerJoin(DatagramChannelImpl.java:1515)
>> at 
>> java.base/sun.nio.ch.DatagramChannelImpl.join(DatagramChannelImpl.java:1551)
>> at 
>> java.base/sun.nio.ch.DatagramSocketAdaptor.joinGroup(DatagramSocketAdaptor.java:532)
>> at 
>> java.base/sun.nio.ch.DatagramSocketAdaptor.joinGroup(DatagramSocketAdaptor.java:479)
>> at 
>> java.base/java.net.MulticastSocket.joinGroup(MulticastSocket.java:318)
>> at MulticastAddresses.runTest(MulticastAddresses.java:56)
>> at MulticastAddresses.main(MulticastAddresses.java:138)
>> at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
>> Method)
>> at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
>> at 
>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>> at 
>> com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
>> at java.base/java.lang.Thread.run(Thread.java:831)
>> 
>> Not sure what actual cause. Will investigate further.
>
> ## java/net/MulticastSocket/SetLoopbackMode.java
> 
> make test 
> TEST="jtreg:test/jdk/java/net/MulticastSocket/SetLoopbackMode.java"
> 
> 
> STDOUT:
> IPv6 can be used
> Default network interface: null
> 
> Test will use multicast group: /ff01:0:0:0:0:0:0:1
> NetworkInterface.getByInetAddress(grp): null
> STDERR:
> java.net.NoRouteToHostException: No route to host: no further information
> at java.base/sun.nio.ch.Net.joinOrDrop6(Native Method)
> at java.base/sun.nio.ch.Net.join6(Net.java:734)
> at 
> java.base/sun.nio.ch.DatagramChannelImpl.innerJoin(DatagramChannelImpl.java:1515)
> at 
> 

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-12 Thread Andrey Turbanov
On Fri, 12 Feb 2021 21:06:24 GMT, Andrey Turbanov 
 wrote:

>> Then I tried to run tests separately:
>> ## java/io/File/GetXSpace.java
>> 
>> 
>> make test TEST="jtreg:test/jdk/java/io/File/GetXSpace.java"
>> 
>> STDERR:
>> java.nio.file.InvalidPathException: Illegal char <:> at index 0: :
>> at 
>> java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
>> at 
>> java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
>> at 
>> java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
>> at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
>> at 
>> java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:230)
>> at java.base/java.io.File.toPath(File.java:2316)
>> at GetXSpace.compare(GetXSpace.java:219)
>> at GetXSpace.testDF(GetXSpace.java:394)
>> at GetXSpace.main(GetXSpace.java:428)
>> at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
>> Method)
>> at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
>> at 
>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>> at 
>> com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
>> at java.base/java.lang.Thread.run(Thread.java:831)
>> 
>> JavaTest Message: Test threw exception: 
>> java.nio.file.InvalidPathException
>> JavaTest Message: shutting down test
>> 
>> STDOUT:
>> --- Testing df
>> C:/Programs/cygwin64   350809332  172573816 178235516  50% /
>> D:3702215676 2812548988 88988  76% 
>> /cygdrive/d
>> E:3906885628 3544182676 362702952  91% 
>> /cygdrive/e
>> F: 250057724  240917056   9140668  97% 
>> /cygdrive/f
>> 
>> 
>> SecurityManager = null
>> C:/Programs/cygwin64:
>>   df   total= 359228755968 free =0 usable = 182513168384
>>   getX total= 359228755968 free = 182513168384 usable = 182513168384
>> ::
>>   df   total= 3791068852224 free =0 usable = 911018688512
>>   getX total=0 free =0 usable =0
>> 
>> TEST RESULT: Failed. Execution failed: `main' threw exception: 
>> java.nio.file.InvalidPathException: Illegal char <:> at index 0: :
>> --
>> 
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8251466 looks like there is already 
>> known bug for similar cygwin output.
>
> ## java/net/MulticastSocket/MulticastAddresses.java
> 
> make test 
> TEST="jtreg:test/jdk/java/net/MulticastSocket/MulticastAddresses.java"
> 
> STDOUT:
> Test: /224.80.80.80  ni: name:eth1 (PANGP Virtual Ethernet Adapter)
> joinGroup(InetAddress) Passed.
> joinGroup(InetAddress,NetworkInterface) Passed.
> Test: /129.1.1.1
> joinGroup(InetAddress)
> Passed: Not a multicast address
> Test: /ff01:0:0:0:0:0:0:1  ni: name:eth10 (VirtualBox Host-Only Ethernet 
> Adapter)
> joinGroup(InetAddress) Failed: No route to host: no further 
> information
> Test: /ff02:0:0:0:0:0:0:1234  ni: name:eth10 (VirtualBox Host-Only 
> Ethernet Adapter)
> joinGroup(InetAddress) Passed.
> joinGroup(InetAddress,NetworkInterface) Passed.
> Test: /ff05:0:0:0:0:0:0:a  ni: name:eth10 (VirtualBox Host-Only Ethernet 
> Adapter)
> joinGroup(InetAddress) Passed.
> joinGroup(InetAddress,NetworkInterface) Passed.
> Test: /ff0e:0:0:0:0:0:1234:a  ni: name:eth10 (VirtualBox Host-Only 
> Ethernet Adapter)
> joinGroup(InetAddress) Passed.
> joinGroup(InetAddress,NetworkInterface) Passed.
> Test: /0:0:0:0:0:0:0:1
> joinGroup(InetAddress)
> Passed: Not a multicast address
> Test: /0:0:0:0:0:0:8101:101
> joinGroup(InetAddress)
> Passed: Not a multicast address
> Test: /fe80:0:0:0:a00:20ff:fee5:bc02
> joinGroup(InetAddress)
> Passed: Not a multicast address
> STDERR:
> java.lang.Exception: 1 test(s) failed - see log file.
> at MulticastAddresses.runTest(MulticastAddresses.java:93)
> at MulticastAddresses.main(MulticastAddresses.java:138)
> at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
> at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at 

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-12 Thread Andrey Turbanov
On Mon, 8 Feb 2021 16:39:55 GMT, Julia Boes  wrote:

>> The other security-related code changes look good to me.
>
> I've updated the issue summary to better reflect the changes, the PR summary 
> should be renamed accordingly. 
> As mentioned earlier, have you run the tests for the affected areas? Here's 
> some information on how to do that: 
> http://openjdk.java.net/guide/#testing-the-jdk

I rebased my changes onto master. (commit 
837bd8930d0a010110f1318b947c036609d3aa33)
and checked tier2 and tier3.
What I got:

==
Test summary
==
   TEST  TOTAL  PASS  FAIL 
ERROR   
>> jtreg:test/jdk:tier2   3698  3690 6 
2 <<
>> jtreg:test/langtools:tier2   1211 1 
0 <<
   jtreg:test/jaxp:tier2   450   450 0 
0   
==
TEST FAILURE




==
Test summary
==
   TEST  TOTAL  PASS  FAIL 
ERROR   
>> jtreg:test/jdk:tier3   1190  1188 2 
0 <<
   jtreg:test/langtools:tier30 0 0 
0   
   jtreg:test/jaxp:tier3 0 0 0 
0   
==
TEST FAILURE


Failed tests:

 tier2:
 java/io/File/GetXSpace.java
 Failed. Execution failed: `main' threw exception: 
java.nio.file.InvalidPathException: Illegal char <:> at index 0: :
 java/net/MulticastSocket/MulticastAddresses.java   
 Failed. Execution failed: `main' threw exception: 
java.lang.Exception: 1 test(s) failed - see log file.
 java/net/MulticastSocket/SetLoopbackMode.java  
 Failed. Execution failed: `main' threw exception: 
java.net.NoRouteToHostException: No route to host: no further information
 java/nio/file/Files/CopyAndMove.java   
 Failed. Execution failed: `main' threw exception: 
java.lang.RuntimeException: AtomicMoveNotSupportedException expected
 java/security/AccessController/DoPrivAccompliceTest.java   
 Failed. Execution failed: `main' threw exception: 
java.lang.RuntimeException: 'user' found in stderr
 tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java   
 Failed. Execution failed: `main' threw exception: 
jdk.jpackage.test.Functional$ExceptionBox: java.lang.RuntimeException: 2 FAILED 
TESTS
 
 sun/security/tools/jarsigner/TimestampCheck.java   
 Error. Agent error: java.lang.Exception: Agent 72 
timed out with a timeout of 2400 seconds; check console log for any additional 
details
 sun/security/tools/keytool/DefaultOptions.java 
 Error. Agent error: java.lang.Exception: Agent 77 
timed out with a timeout of 480 seconds; check console log for any additional 
details
 
 jdk/jshell/ToolBasicTest.java  Failed. 
Execution failed: `main' threw exception: java.lang.Exception: failures: 1
 
 tier3:
 sanity/client/SwingSet/src/SwingSet2DemoTest.java  
Failed. Execution failed: `main' threw 
exception: java.lang.Exception: failures: 1
 sanity/client/SwingSet/src/ColorChooserDemoTest.java   
Failed. Execution failed: `main' threw 
exception: java.lang.Exception: failures: 1

-

PR: https://git.openjdk.java.net/jdk/pull/1853


Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-12 Thread Andrey Turbanov
On Fri, 12 Feb 2021 21:04:54 GMT, Andrey Turbanov 
 wrote:

>> I rebased my changes onto master. (commit 
>> 837bd8930d0a010110f1318b947c036609d3aa33)
>> and checked tier2 and tier3.
>> What I got:
>> 
>> ==
>> Test summary
>> ==
>>TEST  TOTAL  PASS  FAIL 
>> ERROR   
>> >> jtreg:test/jdk:tier2   3698  3690 6   
>>   2 <<
>> >> jtreg:test/langtools:tier2   1211 1   
>>   0 <<
>>jtreg:test/jaxp:tier2   450   450 0   
>>   0   
>> ==
>> TEST FAILURE
>> 
>> 
>> 
>> 
>> ==
>> Test summary
>> ==
>>TEST  TOTAL  PASS  FAIL 
>> ERROR   
>> >> jtreg:test/jdk:tier3   1190  1188 2   
>>   0 <<
>>jtreg:test/langtools:tier30 0 0   
>>   0   
>>jtreg:test/jaxp:tier3 0 0 0   
>>   0   
>> ==
>> TEST FAILURE
>> 
>> 
>> Failed tests:
>> 
>>  tier2:
>>  java/io/File/GetXSpace.java 
>> Failed. Execution failed: `main' threw 
>> exception: java.nio.file.InvalidPathException: Illegal char <:> at index 0: :
>>  java/net/MulticastSocket/MulticastAddresses.java
>> Failed. Execution failed: `main' threw 
>> exception: java.lang.Exception: 1 test(s) failed - see log file.
>>  java/net/MulticastSocket/SetLoopbackMode.java   
>> Failed. Execution failed: `main' threw 
>> exception: java.net.NoRouteToHostException: No route to host: no further 
>> information
>>  java/nio/file/Files/CopyAndMove.java
>> Failed. Execution failed: `main' threw 
>> exception: java.lang.RuntimeException: AtomicMoveNotSupportedException 
>> expected
>>  java/security/AccessController/DoPrivAccompliceTest.java
>> Failed. Execution failed: `main' threw 
>> exception: java.lang.RuntimeException: 'user' found in stderr
>>  tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java
>> Failed. Execution failed: `main' threw 
>> exception: jdk.jpackage.test.Functional$ExceptionBox: 
>> java.lang.RuntimeException: 2 FAILED TESTS
>>  
>>  sun/security/tools/jarsigner/TimestampCheck.java
>> Error. Agent error: java.lang.Exception: Agent 
>> 72 timed out with a timeout of 2400 seconds; check console log for any 
>> additional details
>>  sun/security/tools/keytool/DefaultOptions.java  
>> Error. Agent error: java.lang.Exception: Agent 
>> 77 timed out with a timeout of 480 seconds; check console log for any 
>> additional details
>>  
>>  jdk/jshell/ToolBasicTest.java  Failed. 
>> Execution failed: `main' threw exception: java.lang.Exception: failures: 1
>>  
>>  tier3:
>>  sanity/client/SwingSet/src/SwingSet2DemoTest.java   
>>Failed. Execution failed: `main' 
>> threw exception: java.lang.Exception: failures: 1
>>  sanity/client/SwingSet/src/ColorChooserDemoTest.java
>>Failed. Execution failed: `main' 
>> threw exception: java.lang.Exception: failures: 1
>
> Then I tried to run tests separately:
> ## java/io/File/GetXSpace.java
> 
> 
> make test TEST="jtreg:test/jdk/java/io/File/GetXSpace.java"
> 
> STDERR:
> java.nio.file.InvalidPathException: Illegal char <:> at index 0: :
> at 
> java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
> at 
> java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
> at 
> java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
> at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
> at 
> java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:230)
> at java.base/java.io.File.toPath(File.java:2316)
> at GetXSpace.compare(GetXSpace.java:219)
> at GetXSpace.testDF(GetXSpace.java:394)
> at GetXSpace.main(GetXSpace.java:428)
> at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
> at 
> 

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-12 Thread Andrey Turbanov
On Fri, 12 Feb 2021 21:03:04 GMT, Andrey Turbanov 
 wrote:

>> I've updated the issue summary to better reflect the changes, the PR summary 
>> should be renamed accordingly. 
>> As mentioned earlier, have you run the tests for the affected areas? Here's 
>> some information on how to do that: 
>> http://openjdk.java.net/guide/#testing-the-jdk
>
> I rebased my changes onto master. (commit 
> 837bd8930d0a010110f1318b947c036609d3aa33)
> and checked tier2 and tier3.
> What I got:
> 
> ==
> Test summary
> ==
>TEST  TOTAL  PASS  FAIL 
> ERROR   
> >> jtreg:test/jdk:tier2   3698  3690 6
>  2 <<
> >> jtreg:test/langtools:tier2   1211 1
>  0 <<
>jtreg:test/jaxp:tier2   450   450 0
>  0   
> ==
> TEST FAILURE
> 
> 
> 
> 
> ==
> Test summary
> ==
>TEST  TOTAL  PASS  FAIL 
> ERROR   
> >> jtreg:test/jdk:tier3   1190  1188 2
>  0 <<
>jtreg:test/langtools:tier30 0 0
>  0   
>jtreg:test/jaxp:tier3 0 0 0
>  0   
> ==
> TEST FAILURE
> 
> 
> Failed tests:
> 
>  tier2:
>  java/io/File/GetXSpace.java  
>Failed. Execution failed: `main' threw exception: 
> java.nio.file.InvalidPathException: Illegal char <:> at index 0: :
>  java/net/MulticastSocket/MulticastAddresses.java 
>Failed. Execution failed: `main' threw exception: 
> java.lang.Exception: 1 test(s) failed - see log file.
>  java/net/MulticastSocket/SetLoopbackMode.java
>Failed. Execution failed: `main' threw exception: 
> java.net.NoRouteToHostException: No route to host: no further information
>  java/nio/file/Files/CopyAndMove.java 
>Failed. Execution failed: `main' threw exception: 
> java.lang.RuntimeException: AtomicMoveNotSupportedException expected
>  java/security/AccessController/DoPrivAccompliceTest.java 
>Failed. Execution failed: `main' threw exception: 
> java.lang.RuntimeException: 'user' found in stderr
>  tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java 
>Failed. Execution failed: `main' threw exception: 
> jdk.jpackage.test.Functional$ExceptionBox: java.lang.RuntimeException: 2 
> FAILED TESTS
>  
>  sun/security/tools/jarsigner/TimestampCheck.java 
>Error. Agent error: java.lang.Exception: Agent 72 
> timed out with a timeout of 2400 seconds; check console log for any 
> additional details
>  sun/security/tools/keytool/DefaultOptions.java   
>Error. Agent error: java.lang.Exception: Agent 77 
> timed out with a timeout of 480 seconds; check console log for any additional 
> details
>  
>  jdk/jshell/ToolBasicTest.java  Failed. 
> Execution failed: `main' threw exception: java.lang.Exception: failures: 1
>  
>  tier3:
>  sanity/client/SwingSet/src/SwingSet2DemoTest.java
>   Failed. Execution failed: `main' 
> threw exception: java.lang.Exception: failures: 1
>  sanity/client/SwingSet/src/ColorChooserDemoTest.java 
>   Failed. Execution failed: `main' 
> threw exception: java.lang.Exception: failures: 1

Then I tried to run tests separately:
## java/io/File/GetXSpace.java


make test TEST="jtreg:test/jdk/java/io/File/GetXSpace.java"

STDERR:
java.nio.file.InvalidPathException: Illegal char <:> at index 0: :
at 
java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
at 
java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
at 
java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
at 
java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:230)
at java.base/java.io.File.toPath(File.java:2316)
at GetXSpace.compare(GetXSpace.java:219)
at GetXSpace.testDF(GetXSpace.java:394)
at GetXSpace.main(GetXSpace.java:428)
at 

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

2021-02-08 Thread Andrey Turbanov
On Mon, 8 Feb 2021 14:38:52 GMT, Weijun Wang  wrote:

>> Andrey Turbanov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
>>   revert changes in Apache Santuario
>
> src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java 
> line 49:
> 
>> 47: throws IOException
>> 48: {
>> 49: return is.readAllBytes();
> 
> This is also from Apache Santuario. It's better to keep it unchanged.

reverted

-

PR: https://git.openjdk.java.net/jdk/pull/1853