Re: RFR: 8198793:Add launcher support for preview features

2018-04-12 Thread mandy chung



On 4/12/18 4:43 AM, Kumar Srinivasan wrote:

Hello,

Could I get a review to update the launcher help message.

https://bugs.openjdk.java.net/browse/JDK-8198793

diff --git 
a/src/java.base/share/classes/sun/launcher/resources/launcher.properties 
b/src/java.base/share/classes/sun/launcher/resources/launcher.properties
--- 
a/src/java.base/share/classes/sun/launcher/resources/launcher.properties
+++ 
b/src/java.base/share/classes/sun/launcher/resources/launcher.properties

@@ -113,6 +113,8 @@
 \  one or more argument files containing options\n\
 \    -disable-@files\n\
 \  prevent further argument file expansion\n\
+\    --enable-preview\n\
+\  allow classes to depend on preview features of 
this release
 \To specify an argument for a long option, you can use 
--= or\n\

 \-- .\n


I suggest to make the help message direct e.g.

    enable the preview VM features of this release

Mandy


Re: RFR: 8198793:Add launcher support for preview features

2018-04-11 Thread Sundararajan Athijegannathan

Looks good.

-Sundar

On 12/04/18, 2:13 AM, Kumar Srinivasan wrote:

Hello,

Could I get a review to update the launcher help message.

https://bugs.openjdk.java.net/browse/JDK-8198793

diff --git 
a/src/java.base/share/classes/sun/launcher/resources/launcher.properties 
b/src/java.base/share/classes/sun/launcher/resources/launcher.properties
--- 
a/src/java.base/share/classes/sun/launcher/resources/launcher.properties
+++ 
b/src/java.base/share/classes/sun/launcher/resources/launcher.properties

@@ -113,6 +113,8 @@
 \  one or more argument files containing options\n\
 \-disable-@files\n\
 \  prevent further argument file expansion\n\
+\--enable-preview\n\
+\  allow classes to depend on preview features of 
this release
 \To specify an argument for a long option, you can use 
--= or\n\

 \-- .\n


Thanks
Kumar



RFR: 8198793:Add launcher support for preview features

2018-04-11 Thread Kumar Srinivasan

Hello,

Could I get a review to update the launcher help message.

https://bugs.openjdk.java.net/browse/JDK-8198793

diff --git 
a/src/java.base/share/classes/sun/launcher/resources/launcher.properties 
b/src/java.base/share/classes/sun/launcher/resources/launcher.properties

--- a/src/java.base/share/classes/sun/launcher/resources/launcher.properties
+++ b/src/java.base/share/classes/sun/launcher/resources/launcher.properties
@@ -113,6 +113,8 @@
 \  one or more argument files containing options\n\
 \-disable-@files\n\
 \  prevent further argument file expansion\n\
+\--enable-preview\n\
+\  allow classes to depend on preview features of this 
release
 \To specify an argument for a long option, you can use 
--= or\n\

 \-- .\n


Thanks
Kumar