Re: RFR: 8213561: ZipFile/MultiThreadedReadTest.java timed out in tier1

2019-06-19 Thread Lance Andersen
Hi Sean,

+1
> On Jun 19, 2019, at 12:29 PM, Seán Coffey  wrote:
> 
> Reports that this test is failing intermittently over past few months. It's a 
> rare occurrence but I'd like to take steps to correct it.
> 
> I've removed the dependence on randomness in the bug.
> I've fixed up the zip file creation logic to produce a real zip file
> I've renamed the file to a unique file name per test run (and recorded how 
> long it takes to delete it)
> Test now logs any exception encountered during zip entry read
> 
> I've verified that the test still fails and passes as expected.
> 
> https://bugs.openjdk.java.net/browse/JDK-8213561
> http://cr.openjdk.java.net/~coffeys/webrev.8213561/webrev/
> 
> -- 
> Regards,
> Sean.
> 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 





RFR: 8213561: ZipFile/MultiThreadedReadTest.java timed out in tier1

2019-06-19 Thread Seán Coffey
Reports that this test is failing intermittently over past few months. 
It's a rare occurrence but I'd like to take steps to correct it.


I've removed the dependence on randomness in the bug.
I've fixed up the zip file creation logic to produce a real zip file
I've renamed the file to a unique file name per test run (and recorded 
how long it takes to delete it)

Test now logs any exception encountered during zip entry read

I've verified that the test still fails and passes as expected.

https://bugs.openjdk.java.net/browse/JDK-8213561
http://cr.openjdk.java.net/~coffeys/webrev.8213561/webrev/

--
Regards,
Sean.