Re: RFR: 8255862: Remove @SuppressWarnings from sun.misc.Unsafe

2020-11-04 Thread Chris Hegarty
On Tue, 3 Nov 2020 23:56:34 GMT, Mandy Chung  wrote:

> Record classes are now a standard feature in 16. @SuppressWarnings can be
> removed from sun.misc.Unsafe.

Marked as reviewed by chegar (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/1049


Re: RFR: 8255862: Remove @SuppressWarnings from sun.misc.Unsafe

2020-11-04 Thread Alan Bateman
On Tue, 3 Nov 2020 23:56:34 GMT, Mandy Chung  wrote:

> Record classes are now a standard feature in 16. @SuppressWarnings can be
> removed from sun.misc.Unsafe.

Looks okay. Given some of the changes in the pipeline then we might be want to 
think about deprecating these methods soon too.

-

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1049


Re: RFR: 8255862: Remove @SuppressWarnings from sun.misc.Unsafe

2020-11-04 Thread Aleksey Shipilev
On Tue, 3 Nov 2020 23:56:34 GMT, Mandy Chung  wrote:

> Record classes are now a standard feature in 16. @SuppressWarnings can be
> removed from sun.misc.Unsafe.

Looks fine to me. I see there are Shenandoah-related failures in testing, 
that's not the fault of this patch.

-

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1049


RFR: 8255862: Remove @SuppressWarnings from sun.misc.Unsafe

2020-11-03 Thread Mandy Chung
Record classes are now a standard feature in 16. @SuppressWarnings can be
removed from sun.misc.Unsafe.

-

Commit messages:
 - 8255862: Remove @SuppressWarnings from sun.misc.Unsafe

Changes: https://git.openjdk.java.net/jdk/pull/1049/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1049&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8255862
  Stats: 6 lines in 1 file changed: 0 ins; 3 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1049.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1049/head:pull/1049

PR: https://git.openjdk.java.net/jdk/pull/1049