Re: RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v5]

2020-11-24 Thread Alan Bateman 
On Mon, 23 Nov 2020 23:14:11 GMT, Mark Reinhold  wrote:

>> Please review this implementation of JEP 396 
>> (https://openjdk.java.net/jeps/396).
>> Alan Bateman is the original author; I’ve credited him in the commit 
>> metadata.
>> Passes tiers 1-3 on {linux,macos,windows}-x64 and linux-aarch64.
>
> Mark Reinhold has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Revert: Fix "Add-Exports" case for the 
> setAccessibleNonPublicMemberNonExportedPackage test
>   
>   This reverts commit 6a4d4792261f54b014336d1907b0040b15fdb467.

Marked as reviewed by alanb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/1324

Re: RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v5]

2020-11-23 Thread Mark Reinhold 
> Please review this implementation of JEP 396 
> (https://openjdk.java.net/jeps/396).
> Alan Bateman is the original author; I’ve credited him in the commit metadata.
> Passes tiers 1-3 on {linux,macos,windows}-x64 and linux-aarch64.

Mark Reinhold has updated the pull request incrementally with one additional 
commit since the last revision:

  Revert: Fix "Add-Exports" case for the 
setAccessibleNonPublicMemberNonExportedPackage test
  
  This reverts commit 6a4d4792261f54b014336d1907b0040b15fdb467.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1324/files
  - new: https://git.openjdk.java.net/jdk/pull/1324/files/6a4d4792..1a7ab4e0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1324&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1324&range=03-04

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1324.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1324/head:pull/1324

PR: https://git.openjdk.java.net/jdk/pull/1324