Re: RFR: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record [v2]
On Tue, 8 Dec 2020 16:21:09 GMT, Julia Boes wrote: >> This change applies a stricter semantic distinction of 'type' versus 'class >> and interface'. This is based on the JLS changes described in the >> "Consistent Class and Interface Terminology" document: >> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html. >> >> The following rules were applied: >> - 'class' and/or 'interface' are used when referring to the class/interface >> itself >> - 'type' is used when referring to the type of a variable or expression > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > adjust 1 change in Enum.java Marked as reviewed by chegar (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1670
Re: RFR: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record [v2]
On Tue, 8 Dec 2020 16:21:09 GMT, Julia Boes wrote: >> This change applies a stricter semantic distinction of 'type' versus 'class >> and interface'. This is based on the JLS changes described in the >> "Consistent Class and Interface Terminology" document: >> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html. >> >> The following rules were applied: >> - 'class' and/or 'interface' are used when referring to the class/interface >> itself >> - 'type' is used when referring to the type of a variable or expression > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > adjust 1 change in Enum.java Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1670
Re: RFR: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record [v2]
> This change applies a stricter semantic distinction of 'type' versus 'class > and interface'. This is based on the JLS changes described in the "Consistent > Class and Interface Terminology" document: > https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html. > > The following rules were applied: > - 'class' and/or 'interface' are used when referring to the class/interface > itself > - 'type' is used when referring to the type of a variable or expression Julia Boes has updated the pull request incrementally with one additional commit since the last revision: adjust 1 change in Enum.java - Changes: - all: https://git.openjdk.java.net/jdk/pull/1670/files - new: https://git.openjdk.java.net/jdk/pull/1670/files/6a2a55ea..36b7ceb0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1670=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1670=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1670.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1670/head:pull/1670 PR: https://git.openjdk.java.net/jdk/pull/1670
Re: RFR: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record
On Tue, 8 Dec 2020 10:41:06 GMT, Julia Boes wrote: >> src/java.base/share/classes/java/lang/Enum.java line 62: >> >>> 60: * java.util.EnumMap map} implementations are available. >>> 61: * >>> 62: * @param The enum class subclass >> >> I wonder about this one, given that `` is a type. It sounds strange to me >> - even though I understand that what is meant is that this type should point >> to a class (a subclass of `java.lang.Enum`). > > Makes sense. I suggest the following instead: `The type of enum subclass`. Maybe: "`The type of the enum subclass.`" would sound better - or just "`The enum subclass`". - PR: https://git.openjdk.java.net/jdk/pull/1670
Re: RFR: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record
On Mon, 7 Dec 2020 18:22:33 GMT, Daniel Fuchs wrote: >> This change applies a stricter semantic distinction of 'type' versus 'class >> and interface'. This is based on the JLS changes described in the >> "Consistent Class and Interface Terminology" document: >> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html. >> >> The following rules were applied: >> - 'class' and/or 'interface' are used when referring to the class/interface >> itself >> - 'type' is used when referring to the type of a variable or expression > > src/java.base/share/classes/java/lang/Enum.java line 62: > >> 60: * java.util.EnumMap map} implementations are available. >> 61: * >> 62: * @param The enum class subclass > > I wonder about this one, given that `` is a type. It sounds strange to me > - even though I understand that what is meant is that this type should point > to a class (a subclass of `java.lang.Enum`). Makes sense. I suggest the following instead: `The type of enum subclass`. - PR: https://git.openjdk.java.net/jdk/pull/1670
Re: RFR: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record
On Mon, 7 Dec 2020 17:31:34 GMT, Julia Boes wrote: > This change applies a stricter semantic distinction of 'type' versus 'class > and interface'. This is based on the JLS changes described in the "Consistent > Class and Interface Terminology" document: > https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html. > > The following rules were applied: > - 'class' and/or 'interface' are used when referring to the class/interface > itself > - 'type' is used when referring to the type of a variable or expression src/java.base/share/classes/java/lang/Enum.java line 62: > 60: * java.util.EnumMap map} implementations are available. > 61: * > 62: * @param The enum class subclass I wonder about this one, given that `` is a type. It sounds strange to me - even though I understand that what is meant is that this type should point to a class (a subclass of `java.lang.Enum`). - PR: https://git.openjdk.java.net/jdk/pull/1670
RFR: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record
This change applies a stricter semantic distinction of 'type' versus 'class and interface'. This is based on the JLS changes described in the "Consistent Class and Interface Terminology" document: https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html. The following rules were applied: - 'class' and/or 'interface' are used when referring to the class/interface itself - 'type' is used when referring to the type of a variable or expression - Commit messages: - replace one more occurrence - change type to class in java.lang.Record - change type to class in Enum.java Changes: https://git.openjdk.java.net/jdk/pull/1670/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1670=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8257639 Stats: 24 lines in 2 files changed: 0 ins; 0 del; 24 mod Patch: https://git.openjdk.java.net/jdk/pull/1670.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1670/head:pull/1670 PR: https://git.openjdk.java.net/jdk/pull/1670