Re: RFR: 8260506: VersionHelper cleanup

2021-01-28 Thread Claes Redestad 
On Wed, 27 Jan 2021 15:32:58 GMT, Alan Bateman  wrote:

>> Some small modernizations and cleanups that ultimately help startup of apps 
>> using JNDI/InitialContext
>
> Marked as reviewed by alanb (Reviewer).

@AlanBateman @dfuch @AlekseiEfimov - thanks for reviewing!

-

PR: https://git.openjdk.java.net/jdk/pull/2259

Re: RFR: 8260506: VersionHelper cleanup

2021-01-27 Thread Aleksei Efimov 
On Wed, 27 Jan 2021 16:03:48 GMT, Daniel Fuchs  wrote:

>> Some small modernizations and cleanups that ultimately help startup of apps 
>> using JNDI/InitialContext
>
> Looks fine to me. I have satisfied myself that `c` couldn't be a primitive 
> type if we reach here.
> Please make sure to run tier2 for this one too.

The changes looks good to me.

-

PR: https://git.openjdk.java.net/jdk/pull/2259

Re: RFR: 8260506: VersionHelper cleanup

2021-01-27 Thread Aleksei Efimov 
On Wed, 27 Jan 2021 12:15:43 GMT, Claes Redestad  wrote:

> Some small modernizations and cleanups that ultimately help startup of apps 
> using JNDI/InitialContext

Marked as reviewed by aefimov (Committer).

-

PR: https://git.openjdk.java.net/jdk/pull/2259

Re: RFR: 8260506: VersionHelper cleanup

2021-01-27 Thread Daniel Fuchs 
On Wed, 27 Jan 2021 12:15:43 GMT, Claes Redestad  wrote:

> Some small modernizations and cleanups that ultimately help startup of apps 
> using JNDI/InitialContext

Looks fine to me. I have satisfied myself that `c` couldn't be a primitive type 
if we reach here.
Please make sure to run tier2 for this one too.

-

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2259

Re: RFR: 8260506: VersionHelper cleanup

2021-01-27 Thread Alan Bateman 
On Wed, 27 Jan 2021 12:15:43 GMT, Claes Redestad  wrote:

> Some small modernizations and cleanups that ultimately help startup of apps 
> using JNDI/InitialContext

Marked as reviewed by alanb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/2259

RFR: 8260506: VersionHelper cleanup

2021-01-27 Thread Claes Redestad 
Some small modernizations and cleanups that ultimately help startup of apps 
using JNDI/InitialContext

-

Commit messages:
 - VersionHelper cleanup

Changes: https://git.openjdk.java.net/jdk/pull/2259/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2259=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8260506
  Stats: 30 lines in 1 file changed: 2 ins; 16 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2259.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2259/head:pull/2259

PR: https://git.openjdk.java.net/jdk/pull/2259