Re: RFR: 8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4 [v2]
On Thu, 4 Feb 2021 18:52:58 GMT, Phil Race wrote: >> remove un-needed disabling now JNF has gone .. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > Remove condition that should have been fixed as part of 8257858 Looks good to me. - Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2396
Re: RFR: 8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4 [v2]
On Thu, 4 Feb 2021 11:42:48 GMT, Magnus Ihse Bursie wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove condition that should have been fixed as part of 8257858 > > Marked as reviewed by ihse (Reviewer). Magnus pointed out a condition that I think should have been removed in the fix for 8257858 : Remove JNF dependency from libosxsecurity/KeystoreImpl.m since its a build related change too, and I've verified that after removing it we still build, I am rolling it in here, if that's OK with folks - PR: https://git.openjdk.java.net/jdk/pull/2396
Re: RFR: 8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4 [v2]
> remove un-needed disabling now JNF has gone .. Phil Race has updated the pull request incrementally with one additional commit since the last revision: Remove condition that should have been fixed as part of 8257858 - Changes: - all: https://git.openjdk.java.net/jdk/pull/2396/files - new: https://git.openjdk.java.net/jdk/pull/2396/files/34dcbfb1..93fd193f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=2396=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=2396=00-01 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2396.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2396/head:pull/2396 PR: https://git.openjdk.java.net/jdk/pull/2396
