Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v12]

2021-05-07 Thread Alan Bateman
On Thu, 6 May 2021 14:23:27 GMT, Maurizio Cimadamore  
wrote:

>> This PR contains the API and implementation changes for JEP-412 [1]. A more 
>> detailed description of such changes, to avoid repetitions during the review 
>> process, is included as a separate comment.
>> 
>> [1] - https://openjdk.java.net/jeps/412
>
> Maurizio Cimadamore has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Replace uses of -Djdk.foreign.restricted (useless now) with 
> --enable-native-access

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/package-info.java 
line 72:

> 70:  *
> 71:  * {@code
> 72: try (ResourceScope scope = ResourceScope.ofConfined()) {

The example might be out of date, I assume this should be newConfinedScope.

-

PR: https://git.openjdk.java.net/jdk/pull/3699


Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v12]

2021-05-06 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-412 [1]. A more 
> detailed description of such changes, to avoid repetitions during the review 
> process, is included as a separate comment.
> 
> [1] - https://openjdk.java.net/jeps/412

Maurizio Cimadamore has updated the pull request incrementally with one 
additional commit since the last revision:

  Replace uses of -Djdk.foreign.restricted (useless now) with 
--enable-native-access

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3699/files
  - new: https://git.openjdk.java.net/jdk/pull/3699/files/72eb9bbc..926229ed

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3699&range=11
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3699&range=10-11

  Stats: 45 lines in 8 files changed: 0 ins; 0 del; 45 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3699.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3699/head:pull/3699

PR: https://git.openjdk.java.net/jdk/pull/3699