Re: RFR: 8265079: Implement VarHandle invoker caching [v2]
On Tue, 13 Apr 2021 15:24:13 GMT, Paul Sandoz wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments:
>> - Use boolean instead of index for var handle cache
>
> test/jdk/java/lang/invoke/TestVHInvokerCaching.java line 88:
>
>> 86: MethodHandles.Lookup lookup = lookup();
>> 87:
>> 88: for (Class type : TEST_TYPES) {
>
> A simpler approach would be to iterate over the fields of `Holder` and use
> `unreflectVarHandle`, then you can remove `TEST_TYPES`.
Yeah, that's a good idea. Fixed
-
PR: https://git.openjdk.java.net/jdk/pull/3439
Re: RFR: 8265079: Implement VarHandle invoker caching [v2]
On Tue, 13 Apr 2021 12:25:20 GMT, Jorn Vernee wrote:
>> This patch implements 2 leftover TODOs for implementing var handle invoker
>> MH caching (lambda forms for those were already shared/cached).
>>
>> This piggybacks on the existing mechanism for method handle invoker caching.
>>
>> Testing: Local testing `java/lang/invoke` tests. Tier 1-3
>>
>> Thanks,
>> Jorn
>
> Jorn Vernee has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comments:
> - Use boolean instead of index for var handle cache
test/jdk/java/lang/invoke/TestVHInvokerCaching.java line 88:
> 86: MethodHandles.Lookup lookup = lookup();
> 87:
> 88: for (Class type : TEST_TYPES) {
A simpler approach would be to iterate over the fields of `Holder` and use
`unreflectVarHandle`, then you can remove `TEST_TYPES`.
-
PR: https://git.openjdk.java.net/jdk/pull/3439
Re: RFR: 8265079: Implement VarHandle invoker caching [v2]
> This patch implements 2 leftover TODOs for implementing var handle invoker MH > caching (lambda forms for those were already shared/cached). > > This piggybacks on the existing mechanism for method handle invoker caching. > > Testing: Local testing `java/lang/invoke` tests. Tier 1-3 > > Thanks, > Jorn Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: Review comments: - Use boolean instead of index for var handle cache - Changes: - all: https://git.openjdk.java.net/jdk/pull/3439/files - new: https://git.openjdk.java.net/jdk/pull/3439/files/df10dbdd..93681f77 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3439&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3439&range=00-01 Stats: 14 lines in 1 file changed: 4 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jdk/pull/3439.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3439/head:pull/3439 PR: https://git.openjdk.java.net/jdk/pull/3439
