Re: RFR: 8265130: Make ConstantDesc class hierarchy sealed [v4]
On Fri, 21 May 2021 08:53:51 GMT, Gavin Bierman wrote: >> Hi all, >> >> Please review this patch to make the ConstantDesc hierarchy `sealed`, as was >> promised in its Javadoc, now that sealed classes are finalising in JDK 17. >> >> Thanks, >> Gavin > > Gavin Bierman has updated the pull request incrementally with one additional > commit since the last revision: > > Reordering class modifiers Marked as reviewed by mchung (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4135
Re: RFR: 8265130: Make ConstantDesc class hierarchy sealed [v4]
On Fri, 21 May 2021 08:53:51 GMT, Gavin Bierman wrote: >> Hi all, >> >> Please review this patch to make the ConstantDesc hierarchy `sealed`, as was >> promised in its Javadoc, now that sealed classes are finalising in JDK 17. >> >> Thanks, >> Gavin > > Gavin Bierman has updated the pull request incrementally with one additional > commit since the last revision: > > Reordering class modifiers looks good to me - Marked as reviewed by vromero (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4135
Re: RFR: 8265130: Make ConstantDesc class hierarchy sealed [v4]
On Fri, 21 May 2021 08:53:51 GMT, Gavin Bierman wrote: >> Hi all, >> >> Please review this patch to make the ConstantDesc hierarchy `sealed`, as was >> promised in its Javadoc, now that sealed classes are finalising in JDK 17. >> >> Thanks, >> Gavin > > Gavin Bierman has updated the pull request incrementally with one additional > commit since the last revision: > > Reordering class modifiers This looks good to me. Does this require a CSR as well? I see a CSR here for another change that seals a hierarchy: https://bugs.openjdk.java.net/browse/JDK-8267506 Ah, nvm, it's already indicated on the PR :) - Marked as reviewed by jvernee (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4135
Re: RFR: 8265130: Make ConstantDesc class hierarchy sealed [v4]
> Hi all, > > Please review this patch to make the ConstantDesc hierarchy `sealed`, as was > promised in its Javadoc, now that sealed classes are finalising in JDK 17. > > Thanks, > Gavin Gavin Bierman has updated the pull request incrementally with one additional commit since the last revision: Reordering class modifiers - Changes: - all: https://git.openjdk.java.net/jdk/pull/4135/files - new: https://git.openjdk.java.net/jdk/pull/4135/files/c8f632f6..c36075d2 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=4135=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk=4135=02-03 Stats: 6 lines in 6 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/4135.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4135/head:pull/4135 PR: https://git.openjdk.java.net/jdk/pull/4135
