Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v7]
On Mon, 24 May 2021 06:23:59 GMT, Joe Wang wrote: >> Update module summary, add a few existing properties and features into the >> tables. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Consolidated impl specific properties; deprecated legacy properties; made > new ones take preference Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v7]
On Mon, 24 May 2021 06:23:59 GMT, Joe Wang wrote: >> Update module summary, add a few existing properties and features into the >> tables. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Consolidated impl specific properties; deprecated legacy properties; made > new ones take preference Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v7]
> Update module summary, add a few existing properties and features into the > tables. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Consolidated impl specific properties; deprecated legacy properties; made new ones take preference - Changes: - all: https://git.openjdk.java.net/jdk/pull/3644/files - new: https://git.openjdk.java.net/jdk/pull/3644/files/d4356925..ab349bb1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=06 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=05-06 Stats: 2370 lines in 60 files changed: 1034 ins; 784 del; 552 mod Patch: https://git.openjdk.java.net/jdk/pull/3644.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3644/head:pull/3644 PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v6]
> Update module summary, add a few existing properties and features into the > tables. Joe Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'master' into JDK-8265248 before a major commit that will involve many (57) classes. - Thanks Roger. Changed to fully qualified names. Also made them align left instead of center - Add legacy property names table - replace isAssignableFrom with instanceof - Update the CSR. See Update 03 in the CSR - 8265248: Implementation Specific Properties: change prefix, plus add existing properties - Changes: - all: https://git.openjdk.java.net/jdk/pull/3644/files - new: https://git.openjdk.java.net/jdk/pull/3644/files/70f634de..d4356925 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=05 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=04-05 Stats: 566351 lines in 5111 files changed: 50537 ins; 501716 del; 14098 mod Patch: https://git.openjdk.java.net/jdk/pull/3644.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3644/head:pull/3644 PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v5]
On Wed, 12 May 2021 19:13:43 GMT, Joe Wang wrote: >> Update module summary, add a few existing properties and features into the >> tables. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Thanks Roger. Changed to fully qualified names. Also made them align left > instead of center Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v5]
On Wed, 12 May 2021 19:13:43 GMT, Joe Wang wrote: >> Update module summary, add a few existing properties and features into the >> tables. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Thanks Roger. Changed to fully qualified names. Also made them align left > instead of center Look good, Thanks - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v5]
> Update module summary, add a few existing properties and features into the > tables. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Thanks Roger. Changed to fully qualified names. Also made them align left instead of center - Changes: - all: https://git.openjdk.java.net/jdk/pull/3644/files - new: https://git.openjdk.java.net/jdk/pull/3644/files/466dc3b7..70f634de Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=03-04 Stats: 29 lines in 1 file changed: 0 ins; 0 del; 29 mod Patch: https://git.openjdk.java.net/jdk/pull/3644.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3644/head:pull/3644 PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v4]
On Wed, 12 May 2021 00:42:57 GMT, Joe Wang wrote: >> Update module summary, add a few existing properties and features into the >> tables. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Add legacy property names table The new table looks fine, ut I think it will be less confusing if the property names are fully qualified (with the jdk.xml prefix) and can be seen as identical to the names in the previous table. - Changes requested by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v4]
On Wed, 12 May 2021 00:42:57 GMT, Joe Wang wrote: >> Update module summary, add a few existing properties and features into the >> tables. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Add legacy property names table Looks fine Joe. Thank you for the additional updates for clarity - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v4]
> Update module summary, add a few existing properties and features into the > tables. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Add legacy property names table - Changes: - all: https://git.openjdk.java.net/jdk/pull/3644/files - new: https://git.openjdk.java.net/jdk/pull/3644/files/78047dcc..466dc3b7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=02-03 Stats: 69 lines in 1 file changed: 68 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/3644.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3644/head:pull/3644 PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v3]
On Wed, 28 Apr 2021 18:22:27 GMT, Joe Wang wrote: >> Update module summary, add a few existing properties and features into the >> tables. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > replace isAssignableFrom with instanceof Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v2]
On Wed, 28 Apr 2021 17:32:04 GMT, Roger Riggs wrote: >> Good question. Given that the earlier changes in the whole set >> (impl-specific properties) were backported, I assumed this would too, to be >> complete. Code consistency and clean backport may exceed the benefit of a >> more advanced code feature (e.g. pattern matching). >> >> I also am still doing works based on JDK 8, that provides a much quicker >> turnaround. >> >> Saw Patrick's pattern matching changesets for some lib code. It's possible >> we could do it as well for the xml code. But in general, xml code, esp. >> those from Apache support a lower source level. > > ok, JDK 8 could use instanceof instead of isAssignable. Thanks. Updated. - PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v3]
> Update module summary, add a few existing properties and features into the > tables. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: replace isAssignableFrom with instanceof - Changes: - all: https://git.openjdk.java.net/jdk/pull/3644/files - new: https://git.openjdk.java.net/jdk/pull/3644/files/e88be266..78047dcc Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=01-02 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/3644.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3644/head:pull/3644 PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v2]
On Wed, 28 Apr 2021 17:25:46 GMT, Joe Wang wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/XMLSecurityManager.java
>> line 264:
>>
>>> 262: int temp;
>>> 263: if (Integer.class.isAssignableFrom(value.getClass())) {
>>> 264: temp = (Integer)value;
>>
>> Why not use pattern matching?
>> `if (value instanceof Integer intValue) {
>> temp = intValue;
>> }
>
> Good question. Given that the earlier changes in the whole set (impl-specific
> properties) were backported, I assumed this would too, to be complete. Code
> consistency and clean backport may exceed the benefit of a more advanced code
> feature (e.g. pattern matching).
>
> I also am still doing works based on JDK 8, that provides a much quicker
> turnaround.
>
> Saw Patrick's pattern matching changesets for some lib code. It's possible we
> could do it as well for the xml code. But in general, xml code, esp. those
> from Apache support a lower source level.
ok, JDK 8 could use instanceof instead of isAssignable.
-
PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v2]
On Wed, 28 Apr 2021 16:21:00 GMT, Roger Riggs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update the CSR. See Update 03 in the CSR
>
> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/XMLSecurityManager.java
> line 264:
>
>> 262: int temp;
>> 263: if (Integer.class.isAssignableFrom(value.getClass())) {
>> 264: temp = (Integer)value;
>
> Why not use pattern matching?
> `if (value instanceof Integer intValue) {
> temp = intValue;
> }
Good question. Given that the earlier changes in the whole set (impl-specific
properties) were backported, I assumed this would too, to be complete. Code
consistency and clean backport may exceed the benefit of a more advanced code
feature (e.g. pattern matching).
I also am still doing works based on JDK 8, that provides a much quicker
turnaround.
Saw Patrick's pattern matching changesets for some lib code. It's possible we
could do it as well for the xml code. But in general, xml code, esp. those from
Apache support a lower source level.
-
PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v2]
On Tue, 27 Apr 2021 23:07:33 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update the CSR. See Update 03 in the CSR
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/XMLSecurityManager.java
line 264:
> 262: int temp;
> 263: if (Integer.class.isAssignableFrom(value.getClass())) {
> 264: temp = (Integer)value;
Why not use pattern matching?
`if (value instanceof Integer intValue) {
temp = intValue;
}
-
PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties [v2]
> Update module summary, add a few existing properties and features into the > tables. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Update the CSR. See Update 03 in the CSR - Changes: - all: https://git.openjdk.java.net/jdk/pull/3644/files - new: https://git.openjdk.java.net/jdk/pull/3644/files/dde2e361..e88be266 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=00-01 Stats: 42 lines in 2 files changed: 2 ins; 1 del; 39 mod Patch: https://git.openjdk.java.net/jdk/pull/3644.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3644/head:pull/3644 PR: https://git.openjdk.java.net/jdk/pull/3644
Re: RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties
On Fri, 23 Apr 2021 00:41:17 GMT, Joe Wang wrote: > Update module summary, add a few existing properties and features into the > tables. Good morning Joe, The changes look good based on the discussions we have had about the change and the property documentation is more convenient to find - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3644
RFR: 8265248: Implementation Specific Properties: change prefix, plus add existing properties
Update module summary, add a few existing properties and features into the tables. - Commit messages: - 8265248: Implementation Specific Properties: change prefix, plus add existing properties Changes: https://git.openjdk.java.net/jdk/pull/3644/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3644&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265248 Stats: 873 lines in 14 files changed: 640 ins; 66 del; 167 mod Patch: https://git.openjdk.java.net/jdk/pull/3644.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3644/head:pull/3644 PR: https://git.openjdk.java.net/jdk/pull/3644
