Re: RFR: 8265591: Remove vestiages of intermediate JSR 175 annotation format
On Tue, 20 Apr 2021 23:37:15 GMT, Joe Darcy wrote: > During the recent review of JDK-8228988, I noticed again the comments in the > annotation parser about support for the pre-GA annotation format used before > JDK 5.0 shipped. During the development of annotations, there was a late > change to correct a flaw in the annotation encoding, JDK-5020908. > > I don't think it is necessary to carry forward support for this transient > format any longer and this changeset removes support from both core > reflection and javac. > > Clean runs of relevant test; I gauge this fix as no-reg hard. Marked as reviewed by jfranck (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3597
Re: RFR: 8265591: Remove vestiages of intermediate JSR 175 annotation format
On Tue, 20 Apr 2021 23:37:15 GMT, Joe Darcy wrote: > During the recent review of JDK-8228988, I noticed again the comments in the > annotation parser about support for the pre-GA annotation format used before > JDK 5.0 shipped. During the development of annotations, there was a late > change to correct a flaw in the annotation encoding, JDK-5020908. > > I don't think it is necessary to carry forward support for this transient > format any longer and this changeset removes support from both core > reflection and javac. > > Clean runs of relevant test; I gauge this fix as no-reg hard. PS CSR for the behavioral change: https://bugs.openjdk.java.net/browse/JDK-8265608 - PR: https://git.openjdk.java.net/jdk/pull/3597
RFR: 8265591: Remove vestiages of intermediate JSR 175 annotation format
During the recent review of JDK-8228988, I noticed again the comments in the annotation parser about support for the pre-GA annotation format used before JDK 5.0 shipped. During the development of annotations, there was a late change to correct a flaw in the annotation encoding, JDK-5020908. I don't think it is necessary to carry forward support for this transient format any longer and this changeset removes support from both core reflection and javac. Clean runs of relevant test; I gauge this fix as no-reg hard. - Commit messages: - 8265591: Remove vestiages of intermediate JSR 175 annotation format Changes: https://git.openjdk.java.net/jdk/pull/3597/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3597&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8265591 Stats: 24 lines in 2 files changed: 0 ins; 19 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/3597.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3597/head:pull/3597 PR: https://git.openjdk.java.net/jdk/pull/3597
