Re: RFR: 8265700: Regularize throws clauses in BigDecimal [v2]

2021-04-21 Thread Brian Burkhalter
On Wed, 21 Apr 2021 21:27:40 GMT, Joe Darcy  wrote:

>> Some throws clauses in BigDecimal are uninformative and could be eliminated. 
>> A few explicit throws clauses for surprising exceptions could be added.
>> 
>> These are spec clarifications rather than spec changes.
>> 
>> Follow-up work to https://github.com/openjdk/jdk/pull/3189.
>
> Joe Darcy has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Include constructors.

Less is more. Approved.

-

Marked as reviewed by bpb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3608


Re: RFR: 8265700: Regularize throws clauses in BigDecimal [v2]

2021-04-21 Thread Joe Darcy
> Some throws clauses in BigDecimal are uninformative and could be eliminated. 
> A few explicit throws clauses for surprising exceptions could be added.
> 
> These are spec clarifications rather than spec changes.
> 
> Follow-up work to https://github.com/openjdk/jdk/pull/3189.

Joe Darcy has updated the pull request incrementally with one additional commit 
since the last revision:

  Include constructors.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3608/files
  - new: https://git.openjdk.java.net/jdk/pull/3608/files/676ea4c5..1829b08c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3608&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3608&range=00-01

  Stats: 22 lines in 1 file changed: 1 ins; 19 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3608.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3608/head:pull/3608

PR: https://git.openjdk.java.net/jdk/pull/3608


RFR: 8265700: Regularize throws clauses in BigDecimal

2021-04-21 Thread Joe Darcy
Some throws clauses in BigDecimal are uninformative and could be eliminated. A 
few explicit throws clauses for surprising exceptions could be added.

These are spec clarifications rather than spec changes.

Follow-up work to https://github.com/openjdk/jdk/pull/3189.

-

Commit messages:
 - Add missing space.
 - 8265700: Regularize throws clauses in BigDecimal

Changes: https://git.openjdk.java.net/jdk/pull/3608/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3608&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8265700
  Stats: 19 lines in 1 file changed: 7 ins; 12 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3608.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3608/head:pull/3608

PR: https://git.openjdk.java.net/jdk/pull/3608