Re: RFR: 8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules [v2]

2021-05-06 Thread Daniel Fuchs 
On Thu, 6 May 2021 16:42:16 GMT, Daniel Fuchs  wrote:

>> Hi, please find here a trivial test change that adds some diagnostic (time 
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Use + Instant.now(); Instant.toString() uses the same formatter as 
> ISO_INSTANT.

Doh. Done.

-

PR: https://git.openjdk.java.net/jdk/pull/3904

Re: RFR: 8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules [v2]

2021-05-06 Thread Naoto Sato 
On Thu, 6 May 2021 16:42:16 GMT, Daniel Fuchs  wrote:

>> Hi, please find here a trivial test change that adds some diagnostic (time 
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Use + Instant.now(); Instant.toString() uses the same formatter as 
> ISO_INSTANT.

Looks good. I guess you could also remove `DateTimeFormatter` import statement 
now.

-

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3904

Re: RFR: 8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules [v2]

2021-05-06 Thread Daniel Fuchs 
> Hi, please find here a trivial test change that adds some diagnostic (time 
> stamps) to the LoggerFinder/modules subprocess test logs.

Daniel Fuchs has updated the pull request incrementally with one additional 
commit since the last revision:

  Use + Instant.now(); Instant.toString() uses the same formatter as 
ISO_INSTANT.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3904/files
  - new: https://git.openjdk.java.net/jdk/pull/3904/files/f027f8e0..3e6b436c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3904=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3904=00-01

  Stats: 8 lines in 4 files changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3904.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3904/head:pull/3904

PR: https://git.openjdk.java.net/jdk/pull/3904