Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 20:31:52 GMT, Erik Joelsson wrote: > It got stuck in moderation. Tim has fixed the config now, so this message > should hopefully appear. Yep - I see emails now. Thanks this is really useful! - PR: https://git.openjdk.java.net/jdk17/pull/61
Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any targeted fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ It got stuck in moderation. Tim has fixed the config now, so this message should hopefully appear. - PR: https://git.openjdk.java.net/jdk17/pull/61
Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 19:50:12 GMT, Erik Joelsson wrote: > This comment should now end up in ide-support-dev as well. Not really (at least for now) :-) - PR: https://git.openjdk.java.net/jdk17/pull/61
Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any targeted fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ This comment should now end up in ide-support-dev as well. - PR: https://git.openjdk.java.net/jdk17/pull/61
Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any targeted fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ Making the change here https://github.com/openjdk/skara/pull/1189 - PR: https://git.openjdk.java.net/jdk17/pull/61
Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any targeted fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ Exactly, I need to add the label and the mailing list config. - PR: https://git.openjdk.java.net/jdk17/pull/61
Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On 15/06/2021 17:31, Erik Joelsson wrote: On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: As the title says (please also refer to the JBS issue which describes all the issues in more details), the IDE support for IntelliJ has been updated with many enhancements as part of a seemingly innocuous "path handling" fix. The IDE doesn't appear to be usable in the same way it was in the past and many functionalities have been broken as a result (including support for jtreg test execution using the plugin). For the above reasons, I'm reverting the plugin and idea.sh code to last known working version. Any targeted fix can be re-applied after the revert. Larger enhancements need to be discussed in the proper venue: https://openjdk.java.net/groups/ide-support/ I think reverting this is fine. In the original review, I tried to point out that it needed to be looked at by people who actually use this functionality, but that never happened. I wasn't aware of the ide-support mailing list. Would you like me to add automatic filtering in Skara so that changes touching these files are automatically labelled and mailed to that list? That would be welcome, yes! Unfortunately cc'ing ide-support using the PR command doesn't work either, so some changes is needed on the Skara side. Thanks Maurizio - Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/61
Re: [jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any targeted fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ I think reverting this is fine. In the original review, I tried to point out that it needed to be looked at by people who actually use this functionality, but that never happened. I wasn't aware of the ide-support mailing list. Would you like me to add automatic filtering in Skara so that changes touching these files are automatically labelled and mailed to that list? - Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/61
[jdk17] RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
As the title says (please also refer to the JBS issue which describes all the issues in more details), the IDE support for IntelliJ has been updated with many enhancements as part of a seemingly innocuous "path handling" fix. The IDE doesn't appear to be usable in the same way it was in the past and many functionalities have been broken as a result (including support for jtreg test execution using the plugin). For the above reasons, I'm reverting the plugin and idea.sh code to last known working version. Any targeted fix can be re-applied after the revert. Larger enhancements need to be discussed in the proper venue: https://openjdk.java.net/groups/ide-support/ - Commit messages: - Add missing files - Initial push Changes: https://git.openjdk.java.net/jdk17/pull/61/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=61=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268768 Stats: 690 lines in 12 files changed: 492 ins; 63 del; 135 mod Patch: https://git.openjdk.java.net/jdk17/pull/61.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/61/head:pull/61 PR: https://git.openjdk.java.net/jdk17/pull/61
Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any _targeted_ fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ closing - and recreating against 17 - PR: https://git.openjdk.java.net/jdk/pull/4492
Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 15:35:14 GMT, Maurizio Cimadamore wrote: > I can push to 17 if desired, but I'll need a new PR for that pushing to 17 would be nice; the script is equally broken and unusable there. - PR: https://git.openjdk.java.net/jdk/pull/4492
Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any _targeted_ fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ I can push to 17 if desired, but I'll need a new PR for that - PR: https://git.openjdk.java.net/jdk/pull/4492
Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any _targeted_ fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ Does this need backported to 17 (or pushed to 17 and "back"ported into 18)? - PR: https://git.openjdk.java.net/jdk/pull/4492
Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix. The > IDE doesn't appear to be usable in the same way it was in the past and many > functionalities have been broken as a result (including support for jtreg > test execution using the plugin). > > For the above reasons, I'm reverting the plugin and idea.sh code to last > known working version. Any _targeted_ fix can be re-applied after the revert. > Larger enhancements need to be discussed in the proper venue: > > https://openjdk.java.net/groups/ide-support/ Agreed, let's back up and reevaluate. - Marked as reviewed by psandoz (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4492
RFR: 8268768: idea.sh has been updated in surprising and incompatible ways
As the title says (please also refer to the JBS issue which describes all the issues in more details), the IDE support for IntelliJ has been updated with many enhancements as part of a seemingly innocuous "path handling" fix. The IDE doesn't appear to be usable in the same way it was in the past and many functionalities have been broken as a result (including support for jtreg test execution using the plugin). For the above reasons, I'm reverting the plugin and idea.sh code to last known working version. Any _targeted_ fix can be re-applied after the revert. Larger enhancements need to be discussed in the proper venue: https://openjdk.java.net/groups/ide-support/ - Commit messages: - Revert idea.sh - Revert idea support changes Changes: https://git.openjdk.java.net/jdk/pull/4492/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4492=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268768 Stats: 690 lines in 12 files changed: 492 ins; 63 del; 135 mod Patch: https://git.openjdk.java.net/jdk/pull/4492.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4492/head:pull/4492 PR: https://git.openjdk.java.net/jdk/pull/4492
