Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v5]

2021-06-25 Thread Aleksei Efimov
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon  
wrote:

>> Hi,
>> 
>> Could someone please review the second half of my update for the `java.time` 
>> package to make use of switch expressions?
>> 
>> This PR was split into two parts due to the large number of files affected.
>> 
>> Kind regards,
>> 
>> Patrick
>
> Patrick Concannon has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8269124: Added instanceof pattern variables

Marked as reviewed by aefimov (Committer).

-

PR: https://git.openjdk.java.net/jdk/pull/4552


Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v5]

2021-06-24 Thread Iris Clark
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon  
wrote:

>> Hi,
>> 
>> Could someone please review the second half of my update for the `java.time` 
>> package to make use of switch expressions?
>> 
>> This PR was split into two parts due to the large number of files affected.
>> 
>> Kind regards,
>> 
>> Patrick
>
> Patrick Concannon has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8269124: Added instanceof pattern variables

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4552


Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v5]

2021-06-24 Thread Lance Andersen
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon  
wrote:

>> Hi,
>> 
>> Could someone please review the second half of my update for the `java.time` 
>> package to make use of switch expressions?
>> 
>> This PR was split into two parts due to the large number of files affected.
>> 
>> Kind regards,
>> 
>> Patrick
>
> Patrick Concannon has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8269124: Added instanceof pattern variables

Marked as reviewed by lancea (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4552


Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v5]

2021-06-24 Thread Naoto Sato
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon  
wrote:

>> Hi,
>> 
>> Could someone please review the second half of my update for the `java.time` 
>> package to make use of switch expressions?
>> 
>> This PR was split into two parts due to the large number of files affected.
>> 
>> Kind regards,
>> 
>> Patrick
>
> Patrick Concannon has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8269124: Added instanceof pattern variables

Marked as reviewed by naoto (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4552


Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v5]

2021-06-24 Thread Daniel Fuchs
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon  
wrote:

>> Hi,
>> 
>> Could someone please review the second half of my update for the `java.time` 
>> package to make use of switch expressions?
>> 
>> This PR was split into two parts due to the large number of files affected.
>> 
>> Kind regards,
>> 
>> Patrick
>
> Patrick Concannon has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8269124: Added instanceof pattern variables

Marked as reviewed by dfuchs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4552


Re: RFR: 8269124: Update java.time to use switch expressions (part II) [v5]

2021-06-24 Thread Patrick Concannon
> Hi,
> 
> Could someone please review the second half of my update for the `java.time` 
> package to make use of switch expressions?
> 
> This PR was split into two parts due to the large number of files affected.
> 
> Kind regards,
> 
> Patrick

Patrick Concannon has updated the pull request incrementally with one 
additional commit since the last revision:

  8269124: Added instanceof pattern variables

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4552/files
  - new: https://git.openjdk.java.net/jdk/pull/4552/files/0c6c4a2a..3a1b7161

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4552&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4552&range=03-04

  Stats: 12 lines in 3 files changed: 0 ins; 1 del; 11 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4552.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4552/head:pull/4552

PR: https://git.openjdk.java.net/jdk/pull/4552