Re: RFR: 8271302: Regex Test Refresh [v5]

2021-08-31 Thread xpbob 
On Mon, 30 Aug 2021 15:52:05 GMT, Ian Graves  wrote:

>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Removing some notes re JUnit5

https://bugs.openjdk.java.net/browse/JDK-8273169
I'd like to fix it.

--- a/test/jdk/java/util/regex/NegativeArraySize.java
+++ b/test/jdk/java/util/regex/NegativeArraySize.java
@@ -25,7 +25,7 @@
  * @test
  * @bug 8223174
  * @summary Pattern.compile() can throw confusing NegativeArraySizeException
- * @requires os.maxMemory >= 5g
+ * @requires os.maxMemory >= 5g & vm.bits == 64
  * @run testng/othervm -Xms5G -Xmx5G NegativeArraySize
  */

-

PR: https://git.openjdk.java.net/jdk/pull/5092

Re: RFR: 8271302: Regex Test Refresh [v5]

2021-08-31 Thread Sergey Bylokhov 
On Mon, 30 Aug 2021 15:52:05 GMT, Ian Graves  wrote:

>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Removing some notes re JUnit5

Looks like it was missed that the test fails oi a github actions:
https://github.com/igraves/jdk/runs/3463998089

Run if ! grep --include=test-summary.txt -lqr build/*/test-results -e "TEST 
SUCCESS" ; then
newfailures.txt
java/util/regex/NegativeArraySize.java 
Error: Process completed with exit code 1.


Invalid initial heap size: -Xms5G
The specified size exceeds the maximum representable size.
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

-

PR: https://git.openjdk.java.net/jdk/pull/5092

Re: RFR: 8271302: Regex Test Refresh [v5]

2021-08-30 Thread Ian Graves 
> 8271302: Regex Test Refresh

Ian Graves has updated the pull request incrementally with one additional 
commit since the last revision:

  Removing some notes re JUnit5

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5092/files
  - new: https://git.openjdk.java.net/jdk/pull/5092/files/3f01c172..0845a56f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5092=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5092=03-04

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5092.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5092/head:pull/5092

PR: https://git.openjdk.java.net/jdk/pull/5092