Re: RFR: 8273092: Sort classlist in JDK image [v2]

2021-08-31 Thread Ioi Lam 
On Sat, 28 Aug 2021 13:18:37 GMT, Claes Redestad  wrote:

>> Ioi Lam has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   @dfuch comments
>
> Seems OK.

Thanks @cl4es @magicus @dfuch for the review!

-

PR: https://git.openjdk.java.net/jdk/pull/5288

Re: RFR: 8273092: Sort classlist in JDK image [v2]

2021-08-31 Thread Daniel Fuchs 
On Tue, 31 Aug 2021 01:05:05 GMT, Ioi Lam  wrote:

>> When the classlist is generated using build.tools.classlist.HelloClasslist, 
>> its contents may be non-deterministic due to Java thread execution order.
>> 
>> We should sort the generated classlist to make the JDK image's contents more 
>> deterministic.
>> 
>> Tested with Mach5 tier1, tier2, builds-tier5
>
> Ioi Lam has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   @dfuch comments

Thanks Ioi! These changes look good to me.

-

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5288

Re: RFR: 8273092: Sort classlist in JDK image [v2]

2021-08-30 Thread Ioi Lam 
> When the classlist is generated using build.tools.classlist.HelloClasslist, 
> its contents may be non-deterministic due to Java thread execution order.
> 
> We should sort the generated classlist to make the JDK image's contents more 
> deterministic.
> 
> Tested with Mach5 tier1, tier2, builds-tier5

Ioi Lam has updated the pull request incrementally with one additional commit 
since the last revision:

  @dfuch comments

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5288/files
  - new: https://git.openjdk.java.net/jdk/pull/5288/files/dc170ec0..ee710895

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5288=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5288=00-01

  Stats: 15 lines in 1 file changed: 7 ins; 7 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5288.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5288/head:pull/5288

PR: https://git.openjdk.java.net/jdk/pull/5288

Re: RFR: 8273092: Sort classlist in JDK image [v2]

2021-08-30 Thread Ioi Lam 
On Mon, 30 Aug 2021 12:51:43 GMT, Daniel Fuchs  wrote:

>> Ioi Lam has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   @dfuch comments
>
> make/jdk/src/classes/build/tools/classlist/SortClasslist.java line 58:
> 
>> 56: String line = scanner.nextLine();
>> 57: Matcher m = p.matcher(line);
>> 58: if (m.find()) {
> 
> Are we sure that a comment line will not match this regexp, or that if it 
> matches, it is not a comment line?

Thanks for the comments. I've swapper the matching order to check for leading 
`#` and `@` characters first.

-

PR: https://git.openjdk.java.net/jdk/pull/5288