Re: RFR: 8273098: Unnecessary Vector usage in java.naming
On Thu, 26 Aug 2021 07:04:45 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection Vector is unnecessary. It's recommended to > use ArrayList/array if a thread-safe implementation is not needed. In > post-BiasedLocking times, this is gets worse, as every access is synchronized. > I checked only places where Vector was used as local variable. Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5262
Re: RFR: 8273098: Unnecessary Vector usage in java.naming
On Thu, 26 Aug 2021 07:04:45 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection Vector is unnecessary. It's recommended to > use ArrayList/array if a thread-safe implementation is not needed. In > post-BiasedLocking times, this is gets worse, as every access is synchronized. > I checked only places where Vector was used as local variable. Hi Andrey, The changes look good to me. I've run your patch through our CI and all JNDI tests are green. Best, Aleksei - Marked as reviewed by aefimov (Committer). PR: https://git.openjdk.java.net/jdk/pull/5262
RFR: 8273098: Unnecessary Vector usage in java.naming
Usage of thread-safe collection Vector is unnecessary. It's recommended to use ArrayList/array if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized. I checked only places where Vector was used as local variable. - Commit messages: - [PATCH] Unnecessary Vector usage in java.naming Changes: https://git.openjdk.java.net/jdk/pull/5262/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5262=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273098 Stats: 30 lines in 3 files changed: 1 ins; 2 del; 27 mod Patch: https://git.openjdk.java.net/jdk/pull/5262.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5262/head:pull/5262 PR: https://git.openjdk.java.net/jdk/pull/5262
