RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

2021-09-21 Thread Naoto Sato 
Fixing an AIOOBE on normalizing the month value.

-

Commit messages:
 - 8273924: ArrayIndexOutOfBoundsException thrown in 
java.util.JapaneseImperialCalendar.add()

Changes: https://git.openjdk.java.net/jdk/pull/5611/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5611&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8273924
  Stats: 26 lines in 3 files changed: 24 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5611.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5611/head:pull/5611

PR: https://git.openjdk.java.net/jdk/pull/5611

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

2021-09-21 Thread Roger Riggs 
On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato  wrote:

> Fixing an AIOOBE on normalizing the month value.

Marked as reviewed by rriggs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5611

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

2021-09-21 Thread Iris Clark 
On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato  wrote:

> Fixing an AIOOBE on normalizing the month value.

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5611

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

2021-09-21 Thread Joe Wang 
On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato  wrote:

> Fixing an AIOOBE on normalizing the month value.

Marked as reviewed by joehw (Reviewer).

src/java.base/share/classes/sun/util/calendar/BaseCalendar.java line 281:

> 279: month = 13 - (xm % 12);
> 280: if (month == 13) {
> 281: year ++;

Not that it matters, just happen to see it ;-). Is it more common to have no 
space before the increment operator? Code convention seems to suggest no space 
before increment and their operands. 
No update needed should you decide to remove it.

-

PR: https://git.openjdk.java.net/jdk/pull/5611

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() [v2]

2021-09-21 Thread Naoto Sato 
On Tue, 21 Sep 2021 22:03:30 GMT, Joe Wang  wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Removed the unnecessary space
>
> src/java.base/share/classes/sun/util/calendar/BaseCalendar.java line 281:
> 
>> 279: month = 13 - (xm % 12);
>> 280: if (month == 13) {
>> 281: year ++;
> 
> Not that it matters, just happen to see it ;-). Is it more common to have no 
> space before the increment operator? Code convention seems to suggest no 
> space before increment and their operands. 
> No update needed should you decide to remove it.

Thanks. Indeed it was in the coding convention. Removed.

-

PR: https://git.openjdk.java.net/jdk/pull/5611

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() [v2]

2021-09-21 Thread Naoto Sato 
> Fixing an AIOOBE on normalizing the month value.

Naoto Sato has updated the pull request incrementally with one additional 
commit since the last revision:

  Removed the unnecessary space

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5611/files
  - new: https://git.openjdk.java.net/jdk/pull/5611/files/92f81963..98612bf5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5611&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5611&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5611.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5611/head:pull/5611

PR: https://git.openjdk.java.net/jdk/pull/5611

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() [v2]

2021-09-21 Thread Joe Wang 
On Tue, 21 Sep 2021 22:18:07 GMT, Naoto Sato  wrote:

>> Fixing an AIOOBE on normalizing the month value.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Removed the unnecessary space

Marked as reviewed by joehw (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5611

Re: RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() [v2]

2021-09-21 Thread Iris Clark 
On Tue, 21 Sep 2021 22:18:07 GMT, Naoto Sato  wrote:

>> Fixing an AIOOBE on normalizing the month value.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Removed the unnecessary space

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5611