Re: RFR: 8274392: Suppress more warnings on non-serializable non-transient instance fields in java.sql.rowset [v2]

2021-09-27 Thread Joe Darcy
> Follow-up change to JDK-8231442, augmentations to javac's Xlint:serial 
> checking are out for review (#5709) and java.sql.rowset would need some 
> changes to pass under the expanded checks.
> 
> The changes are to suppress warnings where non-transient fields in 
> serializable types are not declared with a type statically known to be 
> serializable. That isn't necessarily a correctness issues, but it does merit 
> further scrutiny.

Joe Darcy has updated the pull request incrementally with one additional commit 
since the last revision:

  Update copyrights.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5719/files
  - new: https://git.openjdk.java.net/jdk/pull/5719/files/70747989..f0faf468

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5719=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5719=00-01

  Stats: 5 lines in 5 files changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5719.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5719/head:pull/5719

PR: https://git.openjdk.java.net/jdk/pull/5719


Re: RFR: 8274392: Suppress more warnings on non-serializable non-transient instance fields in java.sql.rowset

2021-09-27 Thread Lance Andersen
On Mon, 27 Sep 2021 18:51:37 GMT, Joe Darcy  wrote:

> Follow-up change to JDK-8231442, augmentations to javac's Xlint:serial 
> checking are out for review (#5709) and java.sql.rowset would need some 
> changes to pass under the expanded checks.
> 
> The changes are to suppress warnings where non-transient fields in 
> serializable types are not declared with a type statically known to be 
> serializable. That isn't necessarily a correctness issues, but it does merit 
> further scrutiny.

Marked as reviewed by lancea (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5719


Re: RFR: 8274392: Suppress more warnings on non-serializable non-transient instance fields in java.sql.rowset

2021-09-27 Thread Brian Burkhalter
On Mon, 27 Sep 2021 18:51:37 GMT, Joe Darcy  wrote:

> Follow-up change to JDK-8231442, augmentations to javac's Xlint:serial 
> checking are out for review (#5709) and java.sql.rowset would need some 
> changes to pass under the expanded checks.
> 
> The changes are to suppress warnings where non-transient fields in 
> serializable types are not declared with a type statically known to be 
> serializable. That isn't necessarily a correctness issues, but it does merit 
> further scrutiny.

Marked as reviewed by bpb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5719


RFR: 8274392: Suppress more warnings on non-serializable non-transient instance fields in java.sql.rowset

2021-09-27 Thread Joe Darcy
Follow-up change to JDK-8231442, augmentations to javac's Xlint:serial checking 
are out for review (#5709) and java.sql.rowset would need some changes to pass 
under the expanded checks.

The changes are to suppress warnings where non-transient fields in serializable 
types are not declared with a type statically known to be serializable. That 
isn't necessarily a correctness issues, but it does merit further scrutiny.

-

Commit messages:
 - 8274392: Suppress more warnings on non-serializable non-transient instance 
fields in java.sql.rowset

Changes: https://git.openjdk.java.net/jdk/pull/5719/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5719=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8274392
  Stats: 13 lines in 7 files changed: 13 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5719.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5719/head:pull/5719

PR: https://git.openjdk.java.net/jdk/pull/5719