Re: RFR: 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE [v2]

2021-10-11 Thread Martin Buchholz 
On Mon, 11 Oct 2021 18:52:07 GMT, Andrey Turbanov  wrote:

>> 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE
>
> Andrey Turbanov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE
>   update javadoc of 'newCapacity' method to refer 
> ArraysSupport.SOFT_MAX_ARRAY_LENGTH instead

We generally avoid  in javadoc.
Especially in private javadoc.
I would write this more simply/readably as

* {@code SOFT_MAX_ARRAY_LENGTH >> coder}

-

Marked as reviewed by martin (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5878

Re: RFR: 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE [v2]

2021-10-11 Thread Pavel Rappo 
On Mon, 11 Oct 2021 18:52:07 GMT, Andrey Turbanov  wrote:

>> 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE
>
> Andrey Turbanov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE
>   update javadoc of 'newCapacity' method to refer 
> ArraysSupport.SOFT_MAX_ARRAY_LENGTH instead

I'll run tests; if they pass, I'll sponsor the change.

-

PR: https://git.openjdk.java.net/jdk/pull/5878

Re: RFR: 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE [v2]

2021-10-11 Thread Andrey Turbanov 
> 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE

Andrey Turbanov has updated the pull request incrementally with one additional 
commit since the last revision:

  275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE
  update javadoc of 'newCapacity' method to refer 
ArraysSupport.SOFT_MAX_ARRAY_LENGTH instead

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5878/files
  - new: https://git.openjdk.java.net/jdk/pull/5878/files/d679bd3a..4ba785b3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5878=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5878=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5878.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5878/head:pull/5878

PR: https://git.openjdk.java.net/jdk/pull/5878

Re: RFR: 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE [v2]

2021-10-11 Thread Andrey Turbanov 
On Sun, 10 Oct 2021 22:13:29 GMT, Sergey Bylokhov  wrote:

>> Andrey Turbanov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE
>>   update javadoc of 'newCapacity' method to refer 
>> ArraysSupport.SOFT_MAX_ARRAY_LENGTH instead
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 240:
> 
>> 238:  * OutOfMemoryError: Requested array size exceeds VM limit
>> 239:  */
>> 240: private static final int MAX_ARRAY_SIZE = Integer.MAX_VALUE - 8;
> 
> Looks like the usage of this field was removed by the 
> https://github.com/openjdk/lanai/commit/03642a01, note that the doc for the 
> "newCapacity" is still mentioned this field.

doc updated

-

PR: https://git.openjdk.java.net/jdk/pull/5878