Re: RFR: 8276102: JDK-8245095 integration reverted JDK-8247980

2021-10-29 Thread Aleksey Shipilev
On Thu, 28 Oct 2021 11:13:57 GMT, Aleksey Shipilev  wrote:

> See the [integration 
> commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30
> ) for JDK-8245095. It reintroduced `java/util/stream` in 
> `exclusiveAccess.dirs`, which effectively reverts JDK-8247980. I noticed this 
> because jdk:tier1 became slow again. 
> 
> @FrauBoes, that was not intentional, right? 
> 
> The solution is to drop `java/util/stream` again.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `jdk:tier1` tests are fast again

All right, thanks for reviews.

-

PR: https://git.openjdk.java.net/jdk/pull/6153


Re: RFR: 8276102: JDK-8245095 integration reverted JDK-8247980

2021-10-29 Thread Claes Redestad
On Thu, 28 Oct 2021 11:13:57 GMT, Aleksey Shipilev  wrote:

> See the [integration 
> commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30
> ) for JDK-8245095. It reintroduced `java/util/stream` in 
> `exclusiveAccess.dirs`, which effectively reverts JDK-8247980. I noticed this 
> because jdk:tier1 became slow again. 
> 
> @FrauBoes, that was not intentional, right? 
> 
> The solution is to drop `java/util/stream` again.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `jdk:tier1` tests are fast again

Marked as reviewed by redestad (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/6153


Re: RFR: 8276102: JDK-8245095 integration reverted JDK-8247980

2021-10-29 Thread Daniel Fuchs
On Thu, 28 Oct 2021 11:13:57 GMT, Aleksey Shipilev  wrote:

> See the [integration 
> commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30
> ) for JDK-8245095. It reintroduced `java/util/stream` in 
> `exclusiveAccess.dirs`, which effectively reverts JDK-8247980. I noticed this 
> because jdk:tier1 became slow again. 
> 
> @FrauBoes, that was not intentional, right? 
> 
> The solution is to drop `java/util/stream` again.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `jdk:tier1` tests are fast again

Marked as reviewed by dfuchs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/6153


Re: RFR: 8276102: JDK-8245095 integration reverted JDK-8247980

2021-10-29 Thread Julia Boes
On Thu, 28 Oct 2021 11:13:57 GMT, Aleksey Shipilev  wrote:

> See the [integration 
> commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30
> ) for JDK-8245095. It reintroduced `java/util/stream` in 
> `exclusiveAccess.dirs`, which effectively reverts JDK-8247980. I noticed this 
> because jdk:tier1 became slow again. 
> 
> @FrauBoes, that was not intentional, right? 
> 
> The solution is to drop `java/util/stream` again.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `jdk:tier1` tests are fast again

That was definitely not intentional, thanks for spotting @shipilev!

-

PR: https://git.openjdk.java.net/jdk/pull/6153


RFR: 8276102: JDK-8245095 integration reverted JDK-8247980

2021-10-28 Thread Aleksey Shipilev
See the [integration 
commit](https://github.com/openjdk/jdk/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde#diff-5b9b15832385ab8e02ffca3ddef6d65a9dea73f45abbe5e4f0be561be02073ffR30
) for JDK-8245095. It reintroduced `java/util/stream` in 
`exclusiveAccess.dirs`, which effectively reverts JDK-8247980. I noticed this 
because jdk:tier1 became slow again. 

@FrauBoes, that was not intentional, right? 

The solution is to drop `java/util/stream` again.

Additional testing:
 - [x] Linux x86_64 fastdebug `jdk:tier1` tests are fast again

-

Commit messages:
 - Fix

Changes: https://git.openjdk.java.net/jdk/pull/6153/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6153=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8276102
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6153.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6153/head:pull/6153

PR: https://git.openjdk.java.net/jdk/pull/6153