Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F
On Tue, 1 Mar 2022 11:22:35 GMT, Lance Andersen wrote: > Are there any TCK tests that need to be modified or Added? I made a very > quick scan of the open/test/jdk/java/time/tck/java/time/ dirs and did not see > any tests but of course I could have missed it There are test cases in the `TCK` directory that only verify its validity, such as number of digits. Those tests pass with this fix. - PR: https://git.openjdk.java.net/jdk/pull/7640
Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote: > Fixing the definition and implementation of the pattern symbol `F`. Although > it is an incompatible change, I believe it is worth the fix. For that, a CSR > has been drafted. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7640
Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote: > Fixing the definition and implementation of the pattern symbol `F`. Although > it is an incompatible change, I believe it is worth the fix. For that, a CSR > has been drafted. I think the change makes sense. Are there any TCK tests that need to be modified or Added? I made a very quick scan of the open/test/jdk/java/time/tck/java/time/ dirs and did not see any tests but of course I could have missed it - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7640
Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote: > Fixing the definition and implementation of the pattern symbol `F`. Although > it is an incompatible change, I believe it is worth the fix. For that, a CSR > has been drafted. Although there is incompatibility, I believe a fix is the correct choice. The issue arose because of the poor description of the field in LDML. - Marked as reviewed by scolebourne (Author). PR: https://git.openjdk.java.net/jdk/pull/7640
Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote: > Fixing the definition and implementation of the pattern symbol `F`. Although > it is an incompatible change, I believe it is worth the fix. For that, a CSR > has been drafted. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7640
Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F
On Tue, 1 Mar 2022 01:47:45 GMT, Joe Wang wrote: > Was the following assessment in the bug report correct? "the symbol F in > java.time.DateTimeFormatter is no use in any pattern. It just may cause an > exception." No, not correct. It is currently incorrectly tied with the `ChronoField.ALIGNED_DAY_OF_WEEK_IN_MONTH` field, and works as such. > If true, then it seems the compatibility risk would be low since pattern > letter "F" as is currently defined is of no use. Thus, the risk should remain `medium`. > Also, the CSR summary needs to be a summary of the action to be taken, that > is, changing the pattern definition. The current statement is similar to the > problem statement. Thanks, modified. - PR: https://git.openjdk.java.net/jdk/pull/7640
Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote: > Fixing the definition and implementation of the pattern symbol `F`. Although > it is an incompatible change, I believe it is worth the fix. For that, a CSR > has been drafted. Was the following assessment in the bug report correct? "the symbol F in java.time.DateTimeFormatter is no use in any pattern. It just may cause an exception." If true, then it seems the compatibility risk would be low since pattern letter "F" as is currently defined is of no use. Also, the CSR summary needs to be a summary of the action to be taken, that is, changing the pattern definition. The current statement is similar to the problem statement. - PR: https://git.openjdk.java.net/jdk/pull/7640
RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F
Fixing the definition and implementation of the pattern symbol `F`. Although it is an incompatible change, I believe it is worth the fix. For that, a CSR has been drafted. - Commit messages: - 8282081: java.time.DateTimeFormatter: wrong definition of symbol F Changes: https://git.openjdk.java.net/jdk/pull/7640/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7640=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282081 Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/7640.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7640/head:pull/7640 PR: https://git.openjdk.java.net/jdk/pull/7640
